From nobody Sun Apr 28 22:55:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1577175359; cv=none; d=zohomail.com; s=zohoarc; b=HqdwEaijggaUz9iugSkekhkLW9cPyna+H9ddK2MKZOjcJ0YqRXdOnUngjWAtQF+ktdS0247nMznGxIGimsxBwUTlfpdaRS0PK83Mpv9OGSckVM0fZPmBGcoJ2E4b3/VpfejRM1p3i6RZ2oG2vfl8aRN5qMGE8VV/1jcqz4qreh0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577175359; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=lB1uTCPWDMKnbcTb+vYbTyga+xqN7lwxsV/fcQkxaoQ=; b=TIbdEOeJRd59+FG0DH+Z2ba22/GiSM/LrJGd11qTIrPPHI8xK4Zgfp0BZAqCOfylyu0xx8kHxdL+3FrfQ2wS6XkGjAtKnOCOD4d0Qs+7f1QQR8Y/VBOE/3AaPjobfdFlrugNFE+ux3+mtum0fkfXx40FcFMhwMscyIAh2eWnpvU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1577175359567228.32470879113794; Tue, 24 Dec 2019 00:15:59 -0800 (PST) Received: from localhost ([::1]:37072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijfME-0006Cl-4J for importer@patchew.org; Tue, 24 Dec 2019 03:15:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38171) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijfLL-0005gJ-Gn for qemu-devel@nongnu.org; Tue, 24 Dec 2019 03:15:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ijfLK-0003ZO-78 for qemu-devel@nongnu.org; Tue, 24 Dec 2019 03:15:03 -0500 Received: from relay.sw.ru ([185.231.240.75]:58202) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ijfLJ-0003Yd-W2 for qemu-devel@nongnu.org; Tue, 24 Dec 2019 03:15:02 -0500 Received: from dptest2.qa.sw.ru ([10.94.4.71]) by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1ijfLB-0000il-0A; Tue, 24 Dec 2019 11:14:53 +0300 From: Denis Plotnikov To: qemu-devel@nongnu.org Subject: [PATCH v1] virtio-mmio: update queue size on guest write Date: Tue, 24 Dec 2019 11:14:46 +0300 Message-Id: <20191224081446.17003-1-dplotnikov@virtuozzo.com> X-Mailer: git-send-email 2.17.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Some guests read back queue size after writing it. Always update the on size write otherwise they might be confused. Signed-off-by: Denis Plotnikov Reviewed-by: Stefano Garzarella --- hw/virtio/virtio-mmio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index 94d934c44b..1e40a74869 100644 --- a/hw/virtio/virtio-mmio.c +++ b/hw/virtio/virtio-mmio.c @@ -295,8 +295,9 @@ static void virtio_mmio_write(void *opaque, hwaddr offs= et, uint64_t value, break; case VIRTIO_MMIO_QUEUE_NUM: trace_virtio_mmio_queue_write(value, VIRTQUEUE_MAX_SIZE); + virtio_queue_set_num(vdev, vdev->queue_sel, value); + if (proxy->legacy) { - virtio_queue_set_num(vdev, vdev->queue_sel, value); virtio_queue_update_rings(vdev, vdev->queue_sel); } else { proxy->vqs[vdev->queue_sel].num =3D value; --=20 2.17.0