From nobody Tue Apr 30 04:58:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1576851205; cv=none; d=zohomail.com; s=zohoarc; b=O0Y9EB1/EhFB0Rl6oDUMSjUMzTbmrzVgD74krnVKs+547xzc1G0OIas0ryElJeN4bFkTzVIV5WU74Gk8pdTDiWmmOcDkr1jFlS7DoXs5cnBf4tMvS6HfXZ3V4ptRBOGwxKltNIVVa+wqz5XP4/K7Y1bnxvE4gUQwpxA/WYlxnsg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576851205; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Y+o7Kh10+04oJ4as3kvtxk+5ECsJySzd8Rbrfs8gufc=; b=hyUoPF2otHyGV3oQZMYYYfVwZielVqFSuxeq5xeAZe1BLE/kuokPECPEoSQtRiD3i28L+m3539mwnKR4ug9dDbSAzC69w7KoZo6X4vsWT9GjXB8hmJalloOsXJ/INccx4rgCzSsnJLJanFdT0zWKE5yH35kv/Ly4d9JoTGOe83c= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576851205808991.872077585575; Fri, 20 Dec 2019 06:13:25 -0800 (PST) Received: from localhost ([::1]:56590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiJ1w-0001BM-3K for importer@patchew.org; Fri, 20 Dec 2019 09:13:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53979) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiEv3-00080w-MI for qemu-devel@nongnu.org; Fri, 20 Dec 2019 04:50:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iiEv2-0006lT-Bt for qemu-devel@nongnu.org; Fri, 20 Dec 2019 04:50:01 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2281 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iiEv1-0006ID-UY for qemu-devel@nongnu.org; Fri, 20 Dec 2019 04:50:00 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 655753285479021D78DB; Fri, 20 Dec 2019 17:49:52 +0800 (CST) Received: from DESKTOP-RHHE7UD.china.huawei.com (10.173.221.217) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Fri, 20 Dec 2019 17:49:43 +0800 From: Jiajun Chen To: Subject: [PATCH] 9pfs: local: Fix possible memory leak in local_link() Date: Fri, 20 Dec 2019 17:49:34 +0800 Message-ID: <20191220094934.21232-1-chenjiajun8@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.173.221.217] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-Mailman-Approved-At: Fri, 20 Dec 2019 09:01:13 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, xiexiangyou@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" There is a possible memory leak while local_link return -1 without free odirpath and oname. Reported-by: Euler Robot Signed-off-by: Jaijun Chen Signed-off-by: Xiang Zheng Reviewed-by: Christian Schoenebeck Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/9pfs/9p-local.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c index 4708c0bd89..491b08aee8 100644 --- a/hw/9pfs/9p-local.c +++ b/hw/9pfs/9p-local.c @@ -947,7 +947,7 @@ static int local_link(FsContext *ctx, V9fsPath *oldpath, if (ctx->export_flags & V9FS_SM_MAPPED_FILE && local_is_mapped_file_metadata(ctx, name)) { errno =3D EINVAL; - return -1; + goto out; } =20 odirfd =3D local_opendir_nofollow(ctx, odirpath); --=20 2.21.0.windows.1