From nobody Sat May 4 10:23:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1576766291; cv=none; d=zohomail.com; s=zohoarc; b=Dx2LNgz8dGhjvkJ0EUAuoajwWFC835Hu5IexfICYrTUHdlQS0giyGcQdnFu8zaXKIFUity8SdJi5EwuaW25rbd8glHcf288PSVBNFblpuXjWsxevoHZVZ5uwbD5w1uzWoaRQW7EUX0NePEqY63qEmjmgqFJ+hUP7z0pQY2ZBntM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576766291; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Gtm5fOspobo/pneAIMRTZn/yNfwMV5jBwXEgGtMOqyg=; b=Vtn9waBfozUKGQtBaOvgUQJuSmPgzIwGc39khXb5cUwkBeOxnj4eCzl6MUVoDP39rTOBXfVGJ0kiuB0hdEBWDIRh1hClW2MR9W9jYVfcfwQ3fLCv05/5Q+dhPxW6JE+efgWulsEVpbpQfRCk7GLUEkglL3eziT6hwXzfXaA2fMc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576766291663147.2701561111562; Thu, 19 Dec 2019 06:38:11 -0800 (PST) Received: from localhost ([::1]:42758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihwwM-0003r1-2T for importer@patchew.org; Thu, 19 Dec 2019 09:38:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60237) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihwsi-0007Zo-2f for qemu-devel@nongnu.org; Thu, 19 Dec 2019 09:34:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihwsg-0002RN-4Q for qemu-devel@nongnu.org; Thu, 19 Dec 2019 09:34:23 -0500 Received: from relay.sw.ru ([185.231.240.75]:38590) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihwsf-0002FH-PK; Thu, 19 Dec 2019 09:34:21 -0500 Received: from vovaso.qa.sw.ru ([10.94.3.0] helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1ihwsZ-0006jF-UG; Thu, 19 Dec 2019 17:34:16 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH] qapi/block: fix nbd-server-add spec Date: Thu, 19 Dec 2019 17:34:15 +0300 Message-Id: <20191219143415.28490-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-block@nongnu.org, armbru@redhat.com, mreitz@redhat.com, nsoffer@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" "NAME" here may be interpreted like it should match @name, which is export name. But it was never mentioned in such way. Make it obvious, that actual "" (see docs/interop/nbd.txt) will match @bitmap parameter. Fixes: 5fcbeb06812685a2 Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all. This patch follows discussion on Nir's patch [PATCH] block: nbd: Fix dirty bitmap context name ( https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg04309.html ) Let's just fix qapi spec now.=20 qapi/block.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/block.json b/qapi/block.json index 145c268bb6..8042ef78f0 100644 --- a/qapi/block.json +++ b/qapi/block.json @@ -255,7 +255,8 @@ =20 # @bitmap: Also export the dirty bitmap reachable from @device, so the # NBD client can use NBD_OPT_SET_META_CONTEXT with -# "qemu:dirty-bitmap:NAME" to inspect the bitmap. (since 4.0) +# "qemu:dirty-bitmap:BITMAP" to inspect the bitmap (BITMAP here +# matches @bitmap parameter). (since 4.0) # # Returns: error if the server is not running, or export with the same name # already exists. --=20 2.21.0