From nobody Sun Feb 8 20:12:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1576749957; cv=none; d=zohomail.com; s=zohoarc; b=IU0SyMAWIKRSzRaEB8PHKyzgIig4L/E5nrIWkrqQIsStq/F+hhPwcWEfkAjYs9+Q8LekMzPT3CHj+lko6RRrOyQ+JyQMuBpxEWHWnioaVWfGvp8s2woZAoESlRz5+tOwf7XoZRU5hSueARJgnWIGTFuS2YECiBRZbPEnjWWDUNo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576749957; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=T/Dm/ytRwQ+0y7rCNfUPa9tFs5BtPbUfTWEfcX0wamo=; b=I4BGptR77PZ+IS2xCzHB0z6I1IbPc+yiEXEwxvnDjoKu1GpE0/m+3kPD2A6EGg6DQJg5L3V0bLSn5FEoX77uIRvEALgzE2xEqsVf15y52/MzBhWauqtl47qxlR7/zA1NpTjp77cV9CV8FdgHh6cOvmDPgdtgwGFYks8bJmmip7g= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157674995777124.12388970878078; Thu, 19 Dec 2019 02:05:57 -0800 (PST) Received: from localhost ([::1]:38088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihsgu-000500-3E for importer@patchew.org; Thu, 19 Dec 2019 05:05:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39085) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihsf4-0002g0-DN for qemu-devel@nongnu.org; Thu, 19 Dec 2019 05:04:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihsf2-0007vx-Rl for qemu-devel@nongnu.org; Thu, 19 Dec 2019 05:04:02 -0500 Received: from relay.sw.ru ([185.231.240.75]:57604) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihsev-0007Y7-Jf; Thu, 19 Dec 2019 05:03:53 -0500 Received: from vovaso.qa.sw.ru ([10.94.3.0] helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1ihser-0004j2-Ef; Thu, 19 Dec 2019 13:03:49 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH v3 01/10] hbitmap: assert that we don't create bitmap larger than INT64_MAX Date: Thu, 19 Dec 2019 13:03:39 +0300 Message-Id: <20191219100348.24827-2-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191219100348.24827-1-vsementsov@virtuozzo.com> References: <20191219100348.24827-1-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, qemu-devel@nongnu.org, mreitz@redhat.com, den@openvz.org, jsnow@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" We have APIs which returns signed int64_t, to be able to return error. Therefore we can't handle bitmaps with absolute size larger than (INT64_MAX+1). Still, keep maximum to be INT64_MAX which is a bit safer. Note, that bitmaps are used to represent disk images, which can't exceed INT64_MAX anyway. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- util/hbitmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/hbitmap.c b/util/hbitmap.c index 242c6e519c..7f9b3e0cd7 100644 --- a/util/hbitmap.c +++ b/util/hbitmap.c @@ -716,6 +716,7 @@ HBitmap *hbitmap_alloc(uint64_t size, int granularity) HBitmap *hb =3D g_new0(struct HBitmap, 1); unsigned i; =20 + assert(size <=3D INT64_MAX); hb->orig_size =3D size; =20 assert(granularity >=3D 0 && granularity < 64); @@ -746,6 +747,7 @@ void hbitmap_truncate(HBitmap *hb, uint64_t size) uint64_t num_elements =3D size; uint64_t old; =20 + assert(size <=3D INT64_MAX); hb->orig_size =3D size; =20 /* Size comes in as logical elements, adjust for granularity. */ --=20 2.21.0