From nobody Mon Feb 9 00:01:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576697465; cv=none; d=zohomail.com; s=zohoarc; b=STIYCV33u5qsBJGA3unotvtZbVLPpTwoYnJWCwBNj8WlibNwpbCIBD4l3DRJdWA9XISA4bSIzomuGEitnJLbH9reCjEtO4ok4cTFuhT3aPB/P1PEy+klrGnoWetiLzvgjmrJU2x78q109jWlGGkJx43/HDdfY7aZ0S1eScpg0nI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576697465; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Y6YG32m8JkF0CpWQ1Sg7hx1MiUEtHJOD6PbN9L9fnDQ=; b=kdij76bMh+toZ3I8rIyd7CyMhivtpRuSec3CjUjIAhZgRKo/++z/iGa0rEg6jQz0V6Kyd49wZk3ezb6cmoJHZ41TwXjbW/kGohIYeT3qml9ntp+TQiJ/nOK9l/U1Fb+9iCdD49r5TyyYCDghn1yZZF7yVFRxMd24FnRt2v+PMUM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576697465497138.87021861488336; Wed, 18 Dec 2019 11:31:05 -0800 (PST) Received: from localhost ([::1]:59550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihf2F-0004fg-Mp for importer@patchew.org; Wed, 18 Dec 2019 14:31:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34796) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihexk-0008Lw-IO for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihexi-00047E-7H for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:24 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27726 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihexf-00040I-Rh for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:20 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-TnFNLP5ZPDqKdARPyQIwwA-1; Wed, 18 Dec 2019 14:26:14 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C530A12BA84; Wed, 18 Dec 2019 19:26:12 +0000 (UTC) Received: from x1w.redhat.com (ovpn-116-235.ams2.redhat.com [10.36.116.235]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7C51B60C81; Wed, 18 Dec 2019 19:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576697175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y6YG32m8JkF0CpWQ1Sg7hx1MiUEtHJOD6PbN9L9fnDQ=; b=G3LIoWHe7MpEawC90M2Ah2AbGBmAhOqMXGDk4+PRrh7JQZ+YzTTMFI+2OG9O8Sz64xlSsu k9T1cRDsIttFm3rhu628aUcc244d5CY4BVfEF9Btczy1INh+8WXdscJP/Gj/jaraEsi0rA lapxt94JmgMY59eCwpUwF1FK8SUt7Qg= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH v2 6/6] hw/pci-host/designware: Remove unuseful FALLTHROUGH comment Date: Wed, 18 Dec 2019 20:25:26 +0100 Message-Id: <20191218192526.13845-7-philmd@redhat.com> In-Reply-To: <20191218192526.13845-1-philmd@redhat.com> References: <20191218192526.13845-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: TnFNLP5ZPDqKdARPyQIwwA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrey Smirnov , Markus Armbruster , qemu-arm@nongnu.org, Peter Chubb , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We don't need to explicit this obvious switch fall through. Stay consistent with the rest of the codebase. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Aleksandar Markovic Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- Cc: Peter Chubb Cc: Markus Armbruster Cc: Peter Maydell Cc: Andrey Smirnov Cc: qemu-arm@nongnu.org --- hw/pci-host/designware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c index 71e9b0d9b5..dd245516dd 100644 --- a/hw/pci-host/designware.c +++ b/hw/pci-host/designware.c @@ -182,7 +182,7 @@ designware_pcie_root_config_read(PCIDevice *d, uint32_t= address, int len) break; =20 case DESIGNWARE_PCIE_ATU_CR1: - case DESIGNWARE_PCIE_ATU_CR2: /* FALLTHROUGH */ + case DESIGNWARE_PCIE_ATU_CR2: val =3D viewport->cr[(address - DESIGNWARE_PCIE_ATU_CR1) / sizeof(uint32_t)]; break; --=20 2.21.0