From nobody Mon Feb 9 00:01:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576697281; cv=none; d=zohomail.com; s=zohoarc; b=f5boHxF1ZinlR4zYD5M07mbb8jm0dPiZl78S9GK4f4LDl/8Uret8UZw9jAUVN78jZ56D8pt547Frzho6mJJEUJL02wkjkd32aymJCQedpO97+FiUWevWsKYF2qn5vod8JH4EiOcxdbpRU9E54d+XqxaHw2XzBHsm3VdRo2CdEyI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576697281; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EBUSnrX9Xj4Cd46mcJUhEO/KAuVtcVoqZZfjQwOzsSI=; b=arD7pKpc8+9uxVGfOsynE6GjP6+fdLRmReMZ02u8mN+k9J/BreEbWFq5Czzms2+y5y9zrCviM6crf5E5ZhT2DIw6ib/cVp68ZhHeWGSF2oI16fwpeug1YNwEHwWDCpjF1B9AqvCBtsYsiqQrrc2wRIJq4E0ONeYBryKinN4weds= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576697281341102.5339164161445; Wed, 18 Dec 2019 11:28:01 -0800 (PST) Received: from localhost ([::1]:59510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihezH-0001Og-4p for importer@patchew.org; Wed, 18 Dec 2019 14:27:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60933) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihexP-0007wZ-1j for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihexN-0003Gw-HG for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:02 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:36041 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihexN-0003E3-Cx for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:01 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-436-fccG64bLMmC8M51TdRLDmQ-1; Wed, 18 Dec 2019 14:25:59 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 368F812BA80; Wed, 18 Dec 2019 19:25:58 +0000 (UTC) Received: from x1w.redhat.com (ovpn-116-235.ams2.redhat.com [10.36.116.235]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 10B4F60C81; Wed, 18 Dec 2019 19:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576697160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EBUSnrX9Xj4Cd46mcJUhEO/KAuVtcVoqZZfjQwOzsSI=; b=eGGn/XXZuJ7SNNRzUKr19GeY7UuelKYRIML088ReGjS8X36W0D18cntLx3dVXvjj4IymKY JKViGDsBfzc5rixkmtJrqW/ufv9NP9D1raYxnW5x6Jl+RJhtSEqF0MFle2qlqc/5p210lt lZUPWOLp9KmXm0o7BfUV4vPbcSIi0N8= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 2/6] hw/display/tcx: Add missing fall through comments Date: Wed, 18 Dec 2019 20:25:22 +0100 Message-Id: <20191218192526.13845-3-philmd@redhat.com> In-Reply-To: <20191218192526.13845-1-philmd@redhat.com> References: <20191218192526.13845-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: fccG64bLMmC8M51TdRLDmQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Olivier Danet , Aleksandar Markovic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" When building with GCC9 using CFLAG -Wimplicit-fallthrough=3D2 we get: hw/display/tcx.c: In function =E2=80=98tcx_dac_writel=E2=80=99: hw/display/tcx.c:453:26: error: this statement may fall through [-Werror= =3Dimplicit-fallthrough=3D] 453 | s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index = autoincrement */ | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/display/tcx.c:454:9: note: here 454 | default: | ^~~~~~~ hw/display/tcx.c: In function =E2=80=98tcx_dac_readl=E2=80=99: hw/display/tcx.c:412:22: error: this statement may fall through [-Werror= =3Dimplicit-fallthrough=3D] 412 | s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index auto= increment */ | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/display/tcx.c:413:5: note: here 413 | default: | ^~~~~~~ cc1: all warnings being treated as errors Give a hint to GCC by adding the missing fall through comments. Fixes: 55d7bfe22 Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Aleksandar Markovic Reviewed-by: Mark Cave-Ayland --- v2: Reword the description (Aleksandar) Cc: Aleksandar Markovic Cc: Olivier Danet Cc: Mark Cave-Ayland --- hw/display/tcx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 14e829d3fa..abbeb30284 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -410,6 +410,7 @@ static uint64_t tcx_dac_readl(void *opaque, hwaddr addr, case 2: val =3D s->b[s->dac_index] << 24; s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index autoincrement= */ + /* fall through */ default: s->dac_state =3D 0; break; @@ -451,6 +452,7 @@ static void tcx_dac_writel(void *opaque, hwaddr addr, u= int64_t val, s->b[index] =3D val >> 24; update_palette_entries(s, index, index + 1); s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index autoincre= ment */ + /* fall through */ default: s->dac_state =3D 0; break; --=20 2.21.0