From nobody Mon Feb 9 00:19:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576689828; cv=none; d=zohomail.com; s=zohoarc; b=MLijK6AWDBbkqjzU0GnSjYVyRLz9R8QJR9KRoLyhB2T+js929YKPc6FZDyub+w2rr+tmZXZMrgu/zAfOnKt3iVcnYpeHgegUTBUY36Ax4VMZzJ2O/7sOhl92PDZqx4tGWY93+EFhLQxVJIdywPpUkXW3nLIYpnWuf3H0hOZeUlc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576689828; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9ky3L34wejGcJOlarYpvmPgF6QEhFeFdZ1gZXpXoMAo=; b=foY/nSNW0TdQYpnG0ue1ODftdIkoHfmXQblpnWuGQPEmr0ogtrdB5AWNxLTfRwRX03VFgKlZ1ql5vp9vvk9wEvmZmPsMgcbHfDrKjH+neG7AfX0N8NFeeEjsIN8XqXV9SX7yfc7QODyc1ISMli7iOwOd4yOx78AvI5b/PfchrZ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576689828700598.6711748731735; Wed, 18 Dec 2019 09:23:48 -0800 (PST) Received: from localhost ([::1]:58122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihd35-0002JK-9G for importer@patchew.org; Wed, 18 Dec 2019 12:23:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38541) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihd0R-0007qm-5b for qemu-devel@nongnu.org; Wed, 18 Dec 2019 12:21:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihd0P-0000XZ-SV for qemu-devel@nongnu.org; Wed, 18 Dec 2019 12:21:02 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:46018 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihd0P-0000Tj-Cs for qemu-devel@nongnu.org; Wed, 18 Dec 2019 12:21:01 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-TtA3OU3bPdCFHfmAGQgMxQ-1; Wed, 18 Dec 2019 12:20:57 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8677718543A1; Wed, 18 Dec 2019 17:20:56 +0000 (UTC) Received: from x1w.redhat.com (ovpn-116-235.ams2.redhat.com [10.36.116.235]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9EF871001281; Wed, 18 Dec 2019 17:20:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576689660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ky3L34wejGcJOlarYpvmPgF6QEhFeFdZ1gZXpXoMAo=; b=Juq8jQrf6v5flZXkxL20QcbQfb44pwWOgvHqGQzAPHz1OxLPxYVA1+wpSpGD9fnJz1LBlr oMga6J7NaoF2UFG+Wi2dBPDOF8/f3Y/i1+YFCtFhy54r8w0EUuJy3HV4U/ND+0i9v3dd4l By3CSUUqr7yzpTuzMFWJXukq915dAAQ= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH v2 03/14] hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler Date: Wed, 18 Dec 2019 18:19:58 +0100 Message-Id: <20191218172009.8868-4-philmd@redhat.com> In-Reply-To: <20191218172009.8868-1-philmd@redhat.com> References: <20191218172009.8868-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: TtA3OU3bPdCFHfmAGQgMxQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The Chardev events are listed in the QEMUChrEvent enum. To be able to use this enum in the IOEventHandler typedef, we need to explicit all the events ignored by this frontend, to silent the following GCC warning: CC s390x-softmmu/hw/char/terminal3270.o hw/char/terminal3270.c: In function =E2=80=98chr_event=E2=80=99: hw/char/terminal3270.c:156:5: error: enumeration value =E2=80=98CHR_EVENT= _BREAK=E2=80=99 not handled in switch [-Werror=3Dswitch] 156 | switch (event) { | ^~~~~~ hw/char/terminal3270.c:156:5: error: enumeration value =E2=80=98CHR_EVENT= _MUX_IN=E2=80=99 not handled in switch [-Werror=3Dswitch] hw/char/terminal3270.c:156:5: error: enumeration value =E2=80=98CHR_EVENT= _MUX_OUT=E2=80=99 not handled in switch [-Werror=3Dswitch] cc1: all warnings being treated as errors Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Cornelia Huck --- v2: Add all missing enums Cc: Cornelia Huck Cc: Halil Pasic Cc: Christian Borntraeger Cc: "Marc-Andr=C3=A9 Lureau" Cc: Paolo Bonzini Cc: qemu-s390x@nongnu.org --- hw/char/terminal3270.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/char/terminal3270.c b/hw/char/terminal3270.c index 6859c1bcb2..2aab04fd4b 100644 --- a/hw/char/terminal3270.c +++ b/hw/char/terminal3270.c @@ -166,6 +166,11 @@ static void chr_event(void *opaque, int event) sch->curr_status.scsw.dstat =3D SCSW_DSTAT_DEVICE_END; css_conditional_io_interrupt(sch); break; + case CHR_EVENT_BREAK: + case CHR_EVENT_MUX_IN: + case CHR_EVENT_MUX_OUT: + /* Ignore */ + break; } } =20 --=20 2.21.0