From nobody Mon Feb 9 14:14:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576690561; cv=none; d=zohomail.com; s=zohoarc; b=NEUsOqvhD1611RoPHJF5OS4f1v31y2m9hF2fcw4qW+iKb4apEoJS/F37xpfXh+XjjO8axptWcJMo8WYz+hX1VvsDWpLAWx6wikl6V2Jck/8JFgRxaL/NkMv+Taxie9qwv/hAdYcqC767XeZLCk9iPRAsAcBjzLn81klPGvtp/jw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576690561; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MlWpvWjMvO4W7C89QvDgz4j9AkXk/8NNuObfmzICgyo=; b=Bg1LZK3Jer6QFgEZKDuG+aKtPh1IvUrQoyaJ9T1Cs4ahOCAj65ieJ+973hP/QPq1IGcXwxOWUaleEWc8PlDEoXsMV37lWp8nnoJY/JtUAxOxF7IoEQZpE1heNX5jJORUFGy+1nFbAnIry6/24V84rtaV8/o0aWnCPvgcAeTH3tQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576690561225650.8615412437894; Wed, 18 Dec 2019 09:36:01 -0800 (PST) Received: from localhost ([::1]:58356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihdEu-0007ZZ-38 for importer@patchew.org; Wed, 18 Dec 2019 12:36:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42350) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihd0v-0000Ay-3Z for qemu-devel@nongnu.org; Wed, 18 Dec 2019 12:21:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihd0t-0002q4-Ge for qemu-devel@nongnu.org; Wed, 18 Dec 2019 12:21:32 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:27502 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihd0s-0002hM-0B for qemu-devel@nongnu.org; Wed, 18 Dec 2019 12:21:31 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-215-MfL1FuuHMLmkfoL4u8Fepg-1; Wed, 18 Dec 2019 12:21:28 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E441801E6C for ; Wed, 18 Dec 2019 17:21:27 +0000 (UTC) Received: from x1w.redhat.com (ovpn-116-235.ams2.redhat.com [10.36.116.235]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 177631000322; Wed, 18 Dec 2019 17:21:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576689689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MlWpvWjMvO4W7C89QvDgz4j9AkXk/8NNuObfmzICgyo=; b=FJR30WFaE5C8lyRNvBIraEoT0WVl0h+RQH1X5Hb7idc5XjJg36H9TIbABjdKWlgFQVcE9V 2Prv47IGgo4Ol1HS+v/b2iQCrezjurngSmJMOGEm1PJXiYQ1MgynV8s80jLYO2pgsB2NEO K1FVuY9sL4oJanaY0dRXsZUIrQzcCxQ= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH v2 13/14] chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler Date: Wed, 18 Dec 2019 18:20:08 +0100 Message-Id: <20191218172009.8868-14-philmd@redhat.com> In-Reply-To: <20191218172009.8868-1-philmd@redhat.com> References: <20191218172009.8868-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: MfL1FuuHMLmkfoL4u8Fepg-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The Chardev events are listed in the QEMUChrEvent enum. To be able to use this enum in the IOEventHandler typedef, we need to explicit all the events ignored by this frontend, to silent the following GCC warning: chardev/char.c: In function =E2=80=98qemu_chr_be_event=E2=80=99: chardev/char.c:65:5: error: enumeration value =E2=80=98CHR_EVENT_BREAK=E2= =80=99 not handled in switch [-Werror=3Dswitch] 65 | switch (event) { | ^~~~~~ chardev/char.c:65:5: error: enumeration value =E2=80=98CHR_EVENT_MUX_IN= =E2=80=99 not handled in switch [-Werror=3Dswitch] chardev/char.c:65:5: error: enumeration value =E2=80=98CHR_EVENT_MUX_OUT= =E2=80=99 not handled in switch [-Werror=3Dswitch] cc1: all warnings being treated as errors Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v2: Add all missing enums Cc: "Marc-Andr=C3=A9 Lureau" Cc: Paolo Bonzini --- chardev/char.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/chardev/char.c b/chardev/char.c index 7b6b2cb123..739da1155b 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -69,6 +69,11 @@ void qemu_chr_be_event(Chardev *s, int event) case CHR_EVENT_CLOSED: s->be_open =3D 0; break; + case CHR_EVENT_BREAK: + case CHR_EVENT_MUX_IN: + case CHR_EVENT_MUX_OUT: + /* Ignore */ + break; } =20 CHARDEV_GET_CLASS(s)->chr_be_event(s, event); --=20 2.21.0