From nobody Mon Feb 9 13:22:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576604209; cv=none; d=zohomail.com; s=zohoarc; b=Mzd5Rat5KJfeilhT4KzDD8Qm3aYeubsjNpKckYO1EYG8UHzvk2t1ayK9NQ0GuAJqIa+ab22TP4UXUXtAPK2/VWkd1ZvBh6xfqcR9Kt76NKE/07p6NwHjz1zDKXMXXwHQUnmQm7+XCJrpuPhxyHudSQvfV+U6rLLX6dkKr7a0lDM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576604209; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=y+5GQW/D3XfrNd11HlFzSAvLO+49VFKNR/eOAZ5FZJk=; b=UxCrAz6sV9mfvA4iJ4KrQqkjVgct+qaWqRCKcKVH6Ih83QeI0bRV35kq/F92SwMcFi9E3YUCKBIZW4y1moZRf6nFGSaNKmIbwve4/7f4pFdc1vJ+rUg+bthmhRUpF6iiNEE6Dnx+l3evx5GcODYh7lAq92Gb5G2/b+FeUEBXajU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576604209416289.5031926005656; Tue, 17 Dec 2019 09:36:49 -0800 (PST) Received: from localhost ([::1]:44226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihGm7-0003yP-Sn for importer@patchew.org; Tue, 17 Dec 2019 12:36:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46475) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihGke-00026V-7i for qemu-devel@nongnu.org; Tue, 17 Dec 2019 12:35:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihGkd-0000eG-4T for qemu-devel@nongnu.org; Tue, 17 Dec 2019 12:35:16 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:33030 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihGkd-0000dZ-0L for qemu-devel@nongnu.org; Tue, 17 Dec 2019 12:35:15 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-342-0nPwLdugM5mNllHWznEZyw-1; Tue, 17 Dec 2019 12:35:11 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 49E4EDBFB; Tue, 17 Dec 2019 17:35:10 +0000 (UTC) Received: from x1w.redhat.com (ovpn-205-147.brq.redhat.com [10.40.205.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3150826571; Tue, 17 Dec 2019 17:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576604114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y+5GQW/D3XfrNd11HlFzSAvLO+49VFKNR/eOAZ5FZJk=; b=FEUwkMhkciZN3cnRaTxCyJuioITSPNN9xRlpk7BcXFop+jpm6mBjdpArLHXR3Un6pR1ZGu d07BjZ7+Z7smQkEtRtRb4CQ/LRfGJ9NXG/ROABffX3IhWe2EI8qjCQd0kO7D2SqVVXfaKs Ze2evdJrbPf/QKiiWHllzQ6Qz7fEqSw= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 6/6] qemu-io-cmds: Silent GCC9 format-overflow warning Date: Tue, 17 Dec 2019 18:34:25 +0100 Message-Id: <20191217173425.5082-7-philmd@redhat.com> In-Reply-To: <20191217173425.5082-1-philmd@redhat.com> References: <20191217173425.5082-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: 0nPwLdugM5mNllHWznEZyw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Kevin Wolf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" GCC9 is confused when building with CFLAG -O3: In function =E2=80=98help_oneline=E2=80=99, inlined from =E2=80=98help_all=E2=80=99 at qemu-io-cmds.c:2414:9, inlined from =E2=80=98help_f=E2=80=99 at qemu-io-cmds.c:2424:9: qemu-io-cmds.c:2389:9: error: =E2=80=98%s=E2=80=99 directive argument is = null [-Werror=3Dformat-overflow=3D] 2389 | printf("%s ", ct->name); | ^~~~~~~~~~~~~~~~~~~~~~~ Audit shows this can't happen. Give a hint to GCC adding an assert() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Kevin Wolf Cc: Max Reitz Cc: qemu-block@nongnu.org --- qemu-io-cmds.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 1b7e700020..9e956a5dd4 100644 --- a/qemu-io-cmds.c +++ b/qemu-io-cmds.c @@ -2411,6 +2411,7 @@ static void help_all(void) const cmdinfo_t *ct; =20 for (ct =3D cmdtab; ct < &cmdtab[ncmds]; ct++) { + assert(ct->name); help_oneline(ct->name, ct); } printf("\nUse 'help commandname' for extended help.\n"); --=20 2.21.0