From nobody Mon Feb 9 13:22:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576604320; cv=none; d=zohomail.com; s=zohoarc; b=BySnlJ8cJRUw1AS5v+cWZxBzC5KFspoxri52uiQ8A62az73DKf6laPMHT9y5+o8SkdLd5HOmbszW+6VmJry/PB8oNXb2r8uivm0JJJYp+gaW7R+PdKcl6holpHKD0jsRj+K5goJvhu3bh2dQKUc8UNPNDOC6qFoCOvBjCRcCd1o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576604320; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=024EQHq67Rd7USQOwAS6CFKa3pM0k1rzZuTHwHmHWb8=; b=oEAWO/De8ei07NMfP3LnZPok4If1bKOWYMF1RHnUv3HHlO32QMhF9yk+c/Ct3K98MWrRp7mwq4GwLgfevR8pI8K/jnGNhov4VQ2hiltKO3ZTG/jYGDt32iZ0QNnxHsym8ijufkj045u8x2kA1OE0uxLb14XfRhm24vh16HnE2Jw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576604320084238.01536209108713; Tue, 17 Dec 2019 09:38:40 -0800 (PST) Received: from localhost ([::1]:44256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihGnu-0007Lx-LV for importer@patchew.org; Tue, 17 Dec 2019 12:38:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46142) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihGkM-0001ba-U0 for qemu-devel@nongnu.org; Tue, 17 Dec 2019 12:34:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihGkL-0008JF-S7 for qemu-devel@nongnu.org; Tue, 17 Dec 2019 12:34:58 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:30818 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihGkL-0008IM-P6 for qemu-devel@nongnu.org; Tue, 17 Dec 2019 12:34:57 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-Q2qQ9ZUJNjKv8sUJ0YPWfA-1; Tue, 17 Dec 2019 12:34:54 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB0F18024E9; Tue, 17 Dec 2019 17:34:52 +0000 (UTC) Received: from x1w.redhat.com (ovpn-205-147.brq.redhat.com [10.40.205.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 00CC719C4F; Tue, 17 Dec 2019 17:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576604097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=024EQHq67Rd7USQOwAS6CFKa3pM0k1rzZuTHwHmHWb8=; b=KZcC1NSSloQAUp0xqaZjKc3mcVbWo6GgMpvUpFI73pPyjSEodvPA7prU5Lcpqod02Lyxwm pF2mMUejYkpWU/k8rg/MlhSp5TBnafpq77Ko1gk+10EFbKn8sNJdEA8pitibUG4Xp2sfNg geq8Vp+L95KPL0AWMebKBkDWG2ZUQ2Q= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/6] hw/display/tcx: Add missing fall through comments Date: Tue, 17 Dec 2019 18:34:21 +0100 Message-Id: <20191217173425.5082-3-philmd@redhat.com> In-Reply-To: <20191217173425.5082-1-philmd@redhat.com> References: <20191217173425.5082-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: Q2qQ9ZUJNjKv8sUJ0YPWfA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Olivier Danet Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=3D2: hw/display/tcx.c: In function =E2=80=98tcx_dac_writel=E2=80=99: hw/display/tcx.c:453:26: error: this statement may fall through [-Werror= =3Dimplicit-fallthrough=3D] 453 | s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index = autoincrement */ | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/display/tcx.c:454:9: note: here 454 | default: | ^~~~~~~ hw/display/tcx.c: In function =E2=80=98tcx_dac_readl=E2=80=99: hw/display/tcx.c:412:22: error: this statement may fall through [-Werror= =3Dimplicit-fallthrough=3D] 412 | s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index auto= increment */ | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/display/tcx.c:413:5: note: here 413 | default: | ^~~~~~~ cc1: all warnings being treated as errors Add the missing fall through comments. Fixes: 55d7bfe22 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- Cc: Olivier Danet Cc: Mark Cave-Ayland --- hw/display/tcx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 14e829d3fa..abbeb30284 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -410,6 +410,7 @@ static uint64_t tcx_dac_readl(void *opaque, hwaddr addr, case 2: val =3D s->b[s->dac_index] << 24; s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index autoincrement= */ + /* fall through */ default: s->dac_state =3D 0; break; @@ -451,6 +452,7 @@ static void tcx_dac_writel(void *opaque, hwaddr addr, u= int64_t val, s->b[index] =3D val >> 24; update_palette_entries(s, index, index + 1); s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index autoincre= ment */ + /* fall through */ default: s->dac_state =3D 0; break; --=20 2.21.0