From nobody Thu May 2 00:34:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576595260; cv=none; d=zohomail.com; s=zohoarc; b=mlHer+A1QDPoS3JTrm5crfjGam4xlbyDFVcGhKoW1AGwUAAg4Ljm73/P2FDk58Qpwha27VYpumurHxwqmXCxGQnAwFjE8iF8+g3xsbZT0FHfbcgn6fG5CJyF0VM174Oh1cAq9FenVzJEKeGPS5ysNDkV2zb1fgYH5+48jMWT1A0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576595260; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=w1NTDSSbVt0UV5fVN8/Oq8z3wDEy4qKOZPHKybkPFO4=; b=aEf7eJdQQ9JBtOWo8ngyyocjOJC5KX8/PqLCYLBin1CVzikSNvitYMrQhWxHT6B4ip9D/PjS1slLu0d7shO6b62iUs+Gz35k0w30l7rx77TrFHskXzWpUEK9GgN3ZxhkD1NSa5J0oU759EmMl2KUW/WLzfEHWpB8dG49/r3ZL48= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576595260315288.36450373891626; Tue, 17 Dec 2019 07:07:40 -0800 (PST) Received: from localhost ([::1]:41644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihERl-0004IU-KR for importer@patchew.org; Tue, 17 Dec 2019 10:07:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41948) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihER2-0003sG-9n for qemu-devel@nongnu.org; Tue, 17 Dec 2019 10:06:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihER1-0005hE-6j for qemu-devel@nongnu.org; Tue, 17 Dec 2019 10:06:52 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:27255 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihER1-0005gr-3d for qemu-devel@nongnu.org; Tue, 17 Dec 2019 10:06:51 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-Rgi8LtcLPNaM-I3MQO1g1g-1; Tue, 17 Dec 2019 10:06:47 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4458E800D4E; Tue, 17 Dec 2019 15:06:46 +0000 (UTC) Received: from thuth.com (ovpn-116-149.ams2.redhat.com [10.36.116.149]) by smtp.corp.redhat.com (Postfix) with ESMTP id 05C1610016DA; Tue, 17 Dec 2019 15:06:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576595210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w1NTDSSbVt0UV5fVN8/Oq8z3wDEy4qKOZPHKybkPFO4=; b=OwkiPiFZfEXrfrLVoUIY5l7+D26gbPRxfmKm5yVF03bIQB6dlFQ3+lGwSku8ZkDbJfeXcc S61+cYPYZzcnJQtnuRt2S/+zMwOb84QhLN+8CZsTU8yZdNyKXr0G/JdKqZoBo5HnNQcmlZ 1DIwfdsoEAy4tL30zomiPFbeAU58514= From: Thomas Huth To: Cornelia Huck , qemu-devel@nongnu.org Subject: [PATCH] tests/boot-sector: Fix the bad s390x assembler code Date: Tue, 17 Dec 2019 16:06:42 +0100 Message-Id: <20191217150642.27946-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: Rgi8LtcLPNaM-I3MQO1g1g-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, Janosch Frank Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" There are currently two bugs in s390x_code[]: First, the initial jump uses the wrong offset, so it was jumping to 0x1014 instead of 0x1010. Second, LHI only loads the lower 32-bit of the register. Everything worked fine as long as the s390-ccw bios code was jumping here with r3 containing zeroes in the uppermost 48 bit - which just happened to be the case so far by accident. But we can not rely on this fact, and indeed one of the recent suggested patches to jump2ipl.c cause the newer GCCs to put different values into r3. In that case the code from s390x_code[] crashes very ungracefully. Thus let's make sure to jump to the right instruction, and use LGHI instead of LHI to make sure that we always zero out the upper bits of the register. Signed-off-by: Thomas Huth Reviewed-by: Christian Borntraeger --- tests/boot-sector.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/boot-sector.c b/tests/boot-sector.c index 7824286b9a..9e66c6d013 100644 --- a/tests/boot-sector.c +++ b/tests/boot-sector.c @@ -75,11 +75,11 @@ static const uint8_t s390x_psw_and_magic[] =3D { 0x40, 0x40, 0x40, 0x40, 0x40, 0x40, 0x40, 0x40 /* in the s390-ccw bi= os */ }; static const uint8_t s390x_code[] =3D { - 0xa7, 0xf4, 0x00, 0x0a, /* j 0x10010 */ + 0xa7, 0xf4, 0x00, 0x08, /* j 0x10010 */ 0x00, 0x00, 0x00, 0x00, 'S', '3', '9', '0', 'E', 'P', 0x00, 0x01, - 0xa7, 0x38, HIGH(SIGNATURE_ADDR), LOW(SIGNATURE_ADDR), /* lhi r3,0x7c1= 0 */ + 0xa7, 0x39, HIGH(SIGNATURE_ADDR), LOW(SIGNATURE_ADDR), /* lghi r3,0x7c= 10 */ 0xa7, 0x48, LOW(SIGNATURE), HIGH(SIGNATURE), /* lhi r4,0xadd= e */ 0x40, 0x40, 0x30, 0x00, /* sth r4,0(r3)= */ 0xa7, 0xf4, 0xff, 0xfa /* j 0x10010 */ --=20 2.18.1