From nobody Thu Dec 18 17:55:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1576495171; cv=none; d=zohomail.com; s=zohoarc; b=jzV5ITWeanjwdbPyBR1iTfDKerVOFjFuMbU1TvgaMxdMdnNPPpBI1kNA9+yg8nVzVnAtNO3w8OFk61KecsEQK6Q/Dyxw1/5KXpNKh5/4HV65QNDD+T9xhNHOB9POCTJj3HwfTx8sRqCenVFaCOQp6M6mZOiaosv6ZumWxtdWvKg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576495171; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QD+79veTer7FPiPBdF+SAJ8aBHWDVP6IlE9SRsgpnIk=; b=SLfpg8wYdT5Lv01GuoAW4+DmLPbJFnWfkI37ItdQvYF+lbZGAVHp0VJc9QRDa7rZnUwOWAdA47YKZ6l5oZ1BFSLtNJkLhNAAyv7Hs93QLq9QwTDmuQlktqQ/T+1LjlzfOx5QrD6ImoXWHtJ2QYRlIbU3MqrP5kdu+Ft6vVVAndk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576495171448994.692380035424; Mon, 16 Dec 2019 03:19:31 -0800 (PST) Received: from localhost ([::1]:51476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igoPR-0002YB-UV for importer@patchew.org; Mon, 16 Dec 2019 06:19:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50890) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igoFd-0007c8-Fc for qemu-devel@nongnu.org; Mon, 16 Dec 2019 06:09:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igoFb-0007lM-8j for qemu-devel@nongnu.org; Mon, 16 Dec 2019 06:09:21 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:35868) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igoFb-0007kH-2P for qemu-devel@nongnu.org; Mon, 16 Dec 2019 06:09:19 -0500 Received: by mail-wr1-x436.google.com with SMTP id z3so6731899wru.3 for ; Mon, 16 Dec 2019 03:09:19 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id x10sm20976131wrp.58.2019.12.16.03.09.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2019 03:09:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=QD+79veTer7FPiPBdF+SAJ8aBHWDVP6IlE9SRsgpnIk=; b=cDIr5UjBL8ljfe4FCdbjYixpga6PbOSVaVEEwERydB8SSbV2jL6/45nKYk8HZsetrc pTbdBXO8PWgC0mvrJf3Xb/h2gimHYQTAz0miOH97yz9YapPL9dsnH+0pk3GuRmD6cMN9 Ze1z6MhNGZN33v5XnKTjuCFO0Ag4aNR56r0JXVx65L/3kSSFClt7jnrI3wTQnUzxofC2 J9o1SIkP32UeGd5L6kEExkHeTxi9niUEzGBfW0xNsvFY8GOBZtMqqVWFnhUU0uGfWjUm TRCwidkV7nWz5chgVoovltkM6iZkK4QPjJ1/YmhiLbPLLFLMR+kpxkq/LhUgpVzLLDJV RvSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QD+79veTer7FPiPBdF+SAJ8aBHWDVP6IlE9SRsgpnIk=; b=oHtAWgXHrFwUGAHiIYgjHQEbfuks6UPAKPDSpCYwXq2VCilsmqnNedlYzkbg14w0+8 UD9Xub4hNWx9V9SND6xbH/44Gf80YPFo7NG/plisqhVfnKSH4jTeXuVrxp55TiGS9fvn DJcWnDSNrrYdfgfiSpS1f7cMiFZByUCIc4u/4L5aX7h8k4ub3PRy9wgcc3oDVsAFsG4U 7rdJlxhduAxPoBvtpvIxVhh96nWuLbJmRWIr8cT+I8811F2wBeB8NRcjxiUO2z4rt1aQ 9YCnN3zwVuKjEBGUhFmeXX+ARwTzLoD77LkOjqXoPPcXRjvevOLOsAFHg71HlxmUDMv5 LGyA== X-Gm-Message-State: APjAAAW/iTMGeF+Sc4l9YWoNapU5GwGZ3bJ+cz76xW28gVT/lVl8Nkx1 49IW015VuYQtukkRS5TmrZUqVfP9hYOpzQ== X-Google-Smtp-Source: APXvYqwAnmK5wEykYwcKL8U8sceOxLdk0DZjq1OaHsnP61DlZQjVFJp1mZ8OQAmup8mng3iBSG3LQw== X-Received: by 2002:adf:f1d0:: with SMTP id z16mr28467027wro.209.1576494557935; Mon, 16 Dec 2019 03:09:17 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 09/34] aspeed/scu: Fix W1C behavior Date: Mon, 16 Dec 2019 11:08:39 +0000 Message-Id: <20191216110904.30815-10-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191216110904.30815-1-peter.maydell@linaro.org> References: <20191216110904.30815-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::436 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) From: Joel Stanley This models the clock write one to clear registers, and fixes up some incorrect behavior in all of the write to clear registers. There was also a typo in one of the register definitions. Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Joel Stanley Signed-off-by: C=C3=A9dric Le Goater Message-id: 20191119141211.25716-8-clg@kaod.org [clg: checkpatch.pl fixes ] Signed-off-by: C=C3=A9dric Le Goater Signed-off-by: Peter Maydell --- hw/misc/aspeed_scu.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c index 717509bc546..f62fa25e347 100644 --- a/hw/misc/aspeed_scu.c +++ b/hw/misc/aspeed_scu.c @@ -98,7 +98,7 @@ #define AST2600_CLK_STOP_CTRL TO_REG(0x80) #define AST2600_CLK_STOP_CTRL_CLR TO_REG(0x84) #define AST2600_CLK_STOP_CTRL2 TO_REG(0x90) -#define AST2600_CLK_STOP_CTR2L_CLR TO_REG(0x94) +#define AST2600_CLK_STOP_CTRL2_CLR TO_REG(0x94) #define AST2600_SDRAM_HANDSHAKE TO_REG(0x100) #define AST2600_HPLL_PARAM TO_REG(0x200) #define AST2600_HPLL_EXT TO_REG(0x204) @@ -532,11 +532,13 @@ static uint64_t aspeed_ast2600_scu_read(void *opaque,= hwaddr offset, return s->regs[reg]; } =20 -static void aspeed_ast2600_scu_write(void *opaque, hwaddr offset, uint64_t= data, - unsigned size) +static void aspeed_ast2600_scu_write(void *opaque, hwaddr offset, + uint64_t data64, unsigned size) { AspeedSCUState *s =3D ASPEED_SCU(opaque); int reg =3D TO_REG(offset); + /* Truncate here so bitwise operations below behave as expected */ + uint32_t data =3D data64; =20 if (reg >=3D ASPEED_AST2600_SCU_NR_REGS) { qemu_log_mask(LOG_GUEST_ERROR, @@ -563,15 +565,22 @@ static void aspeed_ast2600_scu_write(void *opaque, hw= addr offset, uint64_t data, /* fall through */ case AST2600_SYS_RST_CTRL: case AST2600_SYS_RST_CTRL2: + case AST2600_CLK_STOP_CTRL: + case AST2600_CLK_STOP_CTRL2: /* W1S (Write 1 to set) registers */ s->regs[reg] |=3D data; return; case AST2600_SYS_RST_CTRL_CLR: case AST2600_SYS_RST_CTRL2_CLR: + case AST2600_CLK_STOP_CTRL_CLR: + case AST2600_CLK_STOP_CTRL2_CLR: case AST2600_HW_STRAP1_CLR: case AST2600_HW_STRAP2_CLR: - /* W1C (Write 1 to clear) registers */ - s->regs[reg] &=3D ~data; + /* + * W1C (Write 1 to clear) registers are offset by one address from + * the data register + */ + s->regs[reg - 1] &=3D ~data; return; =20 case AST2600_RNG_DATA: --=20 2.20.1