From nobody Mon Feb 9 09:33:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576234452; cv=none; d=zohomail.com; s=zohoarc; b=FqqE58JlZmtnDjWWhTHlDKge0+VFpLgzl9zc3T5NXUcmWf+56Vf4ed9RBGKMz2jaL3wWsuCIZcaZC0ncQz/XIkWuR1lVaMoFIp4kMA339MpirWTzpFfczdWGnrtiqkeEYXIV8EaPws60Ire0sgrmECRMIK/ufKqUWUHGnSXSH+s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576234452; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qldGLiiIvORkmocMy3ZfZ/9V4HJH7IaEKp8UIxpLO4E=; b=iTUQ5ZfER33zjxJEEKawZNcAOfMNb69MRgqTw7uxr4c0/kBV9s4NuQEHz++M/sIrLkT9wFcKvZsprFfXesQzwHVxPiDYE7U1g8WDQ1P3Zl9N+riEDmlNm37hWctZUnIQcSQc8Xe9GCFMdKIL+MCyjpMEea1yrJbbVQg/ew2eX44= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157623445291854.92640386762821; Fri, 13 Dec 2019 02:54:12 -0800 (PST) Received: from localhost ([::1]:46056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifiaJ-0008EF-5y for importer@patchew.org; Fri, 13 Dec 2019 05:54:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60022) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifiXY-0005Xu-V3 for qemu-devel@nongnu.org; Fri, 13 Dec 2019 05:51:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifiXY-0001XP-10 for qemu-devel@nongnu.org; Fri, 13 Dec 2019 05:51:20 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:36755 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ifiXX-0001WZ-T1 for qemu-devel@nongnu.org; Fri, 13 Dec 2019 05:51:19 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-61-0UTCnE0HMZKOPAo3aeUShw-1; Fri, 13 Dec 2019 05:51:18 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 45039107ACC5; Fri, 13 Dec 2019 10:51:17 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-134.brq.redhat.com [10.40.204.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD27C1001901; Fri, 13 Dec 2019 10:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576234279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qldGLiiIvORkmocMy3ZfZ/9V4HJH7IaEKp8UIxpLO4E=; b=SmhfqhXw2AoFCz6bXwZEs1oK6ztDoA0cN1lhoLgmXHTw555F7tzPxkqLZuktiTgenCBTCF b26UIWyErSfAwDHePfotA6KFh3i6U0f2EwoxH7/aQgLNzXljyztT+Z4NMwMiyepnbszG0o LuRaArRoRwdK+8cr1lGv02rEdDHak5M= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/4] hw/i386/pc: Use TYPE_PORT92 instead of hardcoded string Date: Fri, 13 Dec 2019 11:50:58 +0100 Message-Id: <20191213105100.8173-3-philmd@redhat.com> In-Reply-To: <20191213105100.8173-1-philmd@redhat.com> References: <20191213105100.8173-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: 0UTCnE0HMZKOPAo3aeUShw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , "Michael S. Tsirkin" , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" By using the TYPE_* definitions for devices, we can: - quickly find where devices are used with 'git-grep' - easily rename a device (one-line change). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 66a30cfdf5..2c2ae27447 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1353,7 +1353,7 @@ static void pc_superio_init(ISABus *isa_bus, bool cre= ate_fdctrl, bool no_vmport) qdev_prop_set_ptr(dev, "ps2_mouse", i8042); qdev_init_nofail(dev); } - port92 =3D isa_create_simple(isa_bus, "port92"); + port92 =3D isa_create_simple(isa_bus, TYPE_PORT92); =20 a20_line =3D qemu_allocate_irqs(handle_a20_line_change, first_cpu, 2); i8042_setup_a20_line(i8042, a20_line[0]); --=20 2.21.0