From nobody Thu Nov 13 03:23:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1576084443; cv=none; d=zohomail.com; s=zohoarc; b=ImkX0H4xKIwhY3fXPVK92m/BYMRes8+kNqrxmGAbV8NZLts0tlLs9G1gts6ZO/tCtW03jc8THV+L2D1Vd4KVczm201rxSMG7wijcaf4Z/aWde85l6Gv/Ceh7djw6RLsXZJWMLoNVLWjr0dObcr26UROnLnFqEdT0LnpqjlFLchs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576084443; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1HpaLHcELOKuPjtThJu7f56C+AUGyKN1UycOs1q17Gw=; b=ZgE1GiTM9hZUWrkP/7hLxKH4iv1/XJUs7qIDeJBFjWPj6PNluzZ/9YopBEwP0ZuRUECkQnDQZ9flmY3yCyxhVP/r9cccG6WvEnS5Oz4wIFrQEyM/pVkBmQY/t+YsAvEspXCr+cUTKaYEzWpHAkqEQyXwUVj/mZZ5pRpMnPQP31Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157608444306629.198574348291572; Wed, 11 Dec 2019 09:14:03 -0800 (PST) Received: from localhost ([::1]:46518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1if5Ym-0005iu-Bn for importer@patchew.org; Wed, 11 Dec 2019 12:14:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39844) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1if5Qi-0005EW-S3 for qemu-devel@nongnu.org; Wed, 11 Dec 2019 12:05:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1if5Qf-0003PD-Ue for qemu-devel@nongnu.org; Wed, 11 Dec 2019 12:05:40 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:36767) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1if5Qf-0003NV-LT for qemu-devel@nongnu.org; Wed, 11 Dec 2019 12:05:37 -0500 Received: by mail-wm1-x343.google.com with SMTP id p17so7794616wma.1 for ; Wed, 11 Dec 2019 09:05:37 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id 25sm2237549wmi.32.2019.12.11.09.05.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 09:05:30 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 3173F1FF98; Wed, 11 Dec 2019 17:05:23 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1HpaLHcELOKuPjtThJu7f56C+AUGyKN1UycOs1q17Gw=; b=HW6vD3KqiSy869G9W7mvhE0KqffByMyihNiUgP9BAYccIpS/a2HfGKhcQ8GabkbtZb 5s/JIlKbDmo2BmZoDlXCvSxi1L9+YNcubpqi927+Ui+atUHu/WoGI0pB4yeDCqHxrndQ mjAkrAbXcx+/qr2WgOKx/aV11jymftQde/Vxuny4qanOmHxe15Axiz0aFXucWN/Jlyn8 Cuote+yxOeFBhCNjwolWOXrx45glfa0XtquiPjy0FWXz8cfQ20PljoeF4oqy2aSFfqJV Il5hWJSe02aV/yMyfM0qn/IWAGCLYmh1L8JDCLcQ2QFJmZTxeAIU/mfynPnZuqzd9M78 reRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1HpaLHcELOKuPjtThJu7f56C+AUGyKN1UycOs1q17Gw=; b=JjPtZ0CNLWWMVOLuqpSwGJ7Cb2Z8cy/r+Vyv/rKaoETkvNdSrOF8e6WiCDtD1LBNUW kxtjzsQ20cNoRw+4KyrRz2DhGz+abZ5LrqbDZIuQWfzWZDVjNCcf54H2iJiFN+/Ru00J cbiqLPdLgD4G1ZUcK/Au2yaDZIdTGNs+Dx1HALDlNnhK420mydh+4H8X81dT/hYiTq+y WzH4MUQbq2KnuEqMREecHa9M1dXfOWlkQYyz0hv1WB7Qdd/rVLgniVQcA30hQV8++KhA qmC8AB0fGahZXSO+ijhwaH8AyQ5XoppR6vx4nJpGEJknb+gEisQyJTMDVkW+Qd07uTAP yMWQ== X-Gm-Message-State: APjAAAUcZ+emDHj4uWix+ZxP5MatgleqbGlR5C5n6H11nlYbcSFCd4sv hNtAeqhaZVS5aKKUFffrVVsnvA== X-Google-Smtp-Source: APXvYqzrM0iWBf9CGjPr7yOfq9DZLBHXGdJqC1bxuIjHIoISvWEc4ICMEiiJg5AoOGIgY8o85vEV2Q== X-Received: by 2002:a7b:cb02:: with SMTP id u2mr880479wmj.142.1576083936293; Wed, 11 Dec 2019 09:05:36 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v3 09/20] target/arm: prepare for multiple dynamic XMLs Date: Wed, 11 Dec 2019 17:05:09 +0000 Message-Id: <20191211170520.7747-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191211170520.7747-1-alex.bennee@linaro.org> References: <20191211170520.7747-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: damien.hedde@greensocs.com, Peter Maydell , luis.machado@linaro.org, richard.henderson@linaro.org, "open list:ARM TCG CPUs" , alan.hayward@arm.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) We will want to generate similar dynamic XML for gdbstub support of SVE registers (the upstream doesn't use XML). To that end lightly rename a few things to make the distinction. Signed-off-by: Alex Benn=C3=A9e --- target/arm/cpu.h | 20 +++++++++++++------- target/arm/gdbstub.c | 30 +++++++++++++++--------------- target/arm/helper.c | 4 ++-- 3 files changed, 30 insertions(+), 24 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index cf16f915c82..a31c7a36d6b 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -128,14 +128,20 @@ enum { /** * DynamicGDBXMLInfo: * @desc: Contains the XML descriptions. - * @num_cpregs: Number of the Coprocessor registers seen by GDB. - * @cpregs_keys: Array that contains the corresponding Key of - * a given cpreg with the same order of the cpreg in the XML description. + * @num: Number of the registers in this XML seen by GDB. + * @data: A union with data specific to the set of registers + * @cpregs_keys: Array that contains the corresponding Key of + * a given cpreg with the same order of the cpreg + * in the XML description. */ typedef struct DynamicGDBXMLInfo { char *desc; - int num_cpregs; - uint32_t *cpregs_keys; + int num; + union { + struct { + uint32_t *keys; + } cpregs; + } data; } DynamicGDBXMLInfo; =20 /* CPU state for each instance of a generic timer (in cp15 c14) */ @@ -748,7 +754,7 @@ struct ARMCPU { uint64_t *cpreg_vmstate_values; int32_t cpreg_vmstate_array_len; =20 - DynamicGDBXMLInfo dyn_xml; + DynamicGDBXMLInfo dyn_sysreg_xml; =20 /* Timers used by the generic (architected) timer */ QEMUTimer *gt_timer[NUM_GTIMERS]; @@ -955,7 +961,7 @@ int arm_cpu_gdb_write_register(CPUState *cpu, uint8_t *= buf, int reg); /* Dynamically generates for gdb stub an XML description of the sysregs fr= om * the cp_regs hashtable. Returns the registered sysregs number. */ -int arm_gen_dynamic_xml(CPUState *cpu); +int arm_gen_dynamic_sysreg_xml(CPUState *cpu); =20 /* Returns the dynamically generated XML for the gdb stub. * Returns a pointer to the XML contents for the specified XML file or NULL diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c index 4557775d245..1f68ab98c3b 100644 --- a/target/arm/gdbstub.c +++ b/target/arm/gdbstub.c @@ -106,15 +106,15 @@ int arm_cpu_gdb_write_register(CPUState *cs, uint8_t = *mem_buf, int n) return 0; } =20 -static void arm_gen_one_xml_reg_tag(GString *s, DynamicGDBXMLInfo *dyn_xml, - ARMCPRegInfo *ri, uint32_t ri_key, - int bitsize) +static void arm_gen_one_xml_sysreg_tag(GString *s, DynamicGDBXMLInfo *dyn_= xml, + ARMCPRegInfo *ri, uint32_t ri_key, + int bitsize) { g_string_append_printf(s, "name); g_string_append_printf(s, " bitsize=3D\"%d\"", bitsize); g_string_append_printf(s, " group=3D\"cp_regs\"/>"); - dyn_xml->num_cpregs++; - dyn_xml->cpregs_keys[dyn_xml->num_cpregs - 1] =3D ri_key; + dyn_xml->data.cpregs.keys[dyn_xml->num] =3D ri_key; + dyn_xml->num++; } =20 static void arm_register_sysreg_for_xml(gpointer key, gpointer value, @@ -126,12 +126,12 @@ static void arm_register_sysreg_for_xml(gpointer key,= gpointer value, GString *s =3D param->s; ARMCPU *cpu =3D ARM_CPU(param->cs); CPUARMState *env =3D &cpu->env; - DynamicGDBXMLInfo *dyn_xml =3D &cpu->dyn_xml; + DynamicGDBXMLInfo *dyn_xml =3D &cpu->dyn_sysreg_xml; =20 if (!(ri->type & (ARM_CP_NO_RAW | ARM_CP_NO_GDB))) { if (arm_feature(env, ARM_FEATURE_AARCH64)) { if (ri->state =3D=3D ARM_CP_STATE_AA64) { - arm_gen_one_xml_reg_tag(s , dyn_xml, ri, ri_key, 64); + arm_gen_one_xml_sysreg_tag(s , dyn_xml, ri, ri_key, 64); } } else { if (ri->state =3D=3D ARM_CP_STATE_AA32) { @@ -140,30 +140,30 @@ static void arm_register_sysreg_for_xml(gpointer key,= gpointer value, return; } if (ri->type & ARM_CP_64BIT) { - arm_gen_one_xml_reg_tag(s , dyn_xml, ri, ri_key, 64); + arm_gen_one_xml_sysreg_tag(s , dyn_xml, ri, ri_key, 64= ); } else { - arm_gen_one_xml_reg_tag(s , dyn_xml, ri, ri_key, 32); + arm_gen_one_xml_sysreg_tag(s , dyn_xml, ri, ri_key, 32= ); } } } } } =20 -int arm_gen_dynamic_xml(CPUState *cs) +int arm_gen_dynamic_sysreg_xml(CPUState *cs) { ARMCPU *cpu =3D ARM_CPU(cs); GString *s =3D g_string_new(NULL); RegisterSysregXmlParam param =3D {cs, s}; =20 - cpu->dyn_xml.num_cpregs =3D 0; - cpu->dyn_xml.cpregs_keys =3D g_new(uint32_t, g_hash_table_size(cpu->cp= _regs)); + cpu->dyn_sysreg_xml.num =3D 0; + cpu->dyn_sysreg_xml.data.cpregs.keys =3D g_new(uint32_t, g_hash_table_= size(cpu->cp_regs)); g_string_printf(s, ""); g_string_append_printf(s, "= "); g_string_append_printf(s, ""); g_hash_table_foreach(cpu->cp_regs, arm_register_sysreg_for_xml, ¶m= ); g_string_append_printf(s, ""); - cpu->dyn_xml.desc =3D g_string_free(s, false); - return cpu->dyn_xml.num_cpregs; + cpu->dyn_sysreg_xml.desc =3D g_string_free(s, false); + return cpu->dyn_sysreg_xml.num; } =20 const char *arm_gdb_get_dynamic_xml(CPUState *cs, const char *xmlname) @@ -171,7 +171,7 @@ const char *arm_gdb_get_dynamic_xml(CPUState *cs, const= char *xmlname) ARMCPU *cpu =3D ARM_CPU(cs); =20 if (strcmp(xmlname, "system-registers.xml") =3D=3D 0) { - return cpu->dyn_xml.desc; + return cpu->dyn_sysreg_xml.desc; } return NULL; } diff --git a/target/arm/helper.c b/target/arm/helper.c index 6476245e789..4bf133e2f42 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -207,7 +207,7 @@ static int arm_gdb_get_sysreg(CPUARMState *env, GByteAr= ray *buf, int reg) const ARMCPRegInfo *ri; uint32_t key; =20 - key =3D cpu->dyn_xml.cpregs_keys[reg]; + key =3D cpu->dyn_sysreg_xml.data.cpregs.keys[reg]; ri =3D get_arm_cp_reginfo(cpu->cp_regs, key); if (ri) { if (cpreg_field_is_64bit(ri)) { @@ -6995,7 +6995,7 @@ void arm_cpu_register_gdb_regs_for_features(ARMCPU *c= pu) 19, "arm-vfp.xml", 0); } gdb_register_coprocessor(cs, arm_gdb_get_sysreg, arm_gdb_set_sysreg, - arm_gen_dynamic_xml(cs), + arm_gen_dynamic_sysreg_xml(cs), "system-registers.xml", 0); } =20 --=20 2.20.1