From nobody Mon Feb 9 12:09:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575896002; cv=none; d=zohomail.com; s=zohoarc; b=Wt5ouxC77RkuX+6JZC32E0F3t1BtopcyI3mnF/4XEKo55haxlSJcss1tU3Tc70DGmWx0ueYUau90OqZ+GQr8mwZGwjTREYdQXJ80QpUzOHbKjPKWWQlyJGC8R+ym5VR4kUcFAcccr6TND6FoGnhy7zRFCgGAEdEtUZSjY1dQ5sM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575896002; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=P4DMweKpaEuJLTHp09Hv1B3YpFQgfO9G8MW94DJ2RQw=; b=IJyWRES5l6r/uzOvk7LZfbeEOVf5TsEyI0zwidpVDOfvhggfzoQAqwPndNNc6jm0iRAIoN4BspgORnwz4HYhnyCbgDymri6Ccq55dF480sPL1YEuAZsJXRNSGmp1NpWeIcONqiySaPXOoOKy/Ml0dsWtklJhLQ3oX74CxRuEFL0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1575896002034700.147909995121; Mon, 9 Dec 2019 04:53:22 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-411-5dyrNFedM46XPpEXIAxHtQ-1; Mon, 09 Dec 2019 07:53:19 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 424D3800D5B; Mon, 9 Dec 2019 12:53:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 16C8D6E3FB; Mon, 9 Dec 2019 12:53:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A5C3783557; Mon, 9 Dec 2019 12:53:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xB9Cr5w1023060 for ; Mon, 9 Dec 2019 07:53:05 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8FADA46; Mon, 9 Dec 2019 12:53:05 +0000 (UTC) Received: from thuth.com (ovpn-116-121.ams2.redhat.com [10.36.116.121]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8114C6E3FB; Mon, 9 Dec 2019 12:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575896000; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=P4DMweKpaEuJLTHp09Hv1B3YpFQgfO9G8MW94DJ2RQw=; b=c1nGJtl4o4YABFNJQyHeY0LxO/7YZYgwRc6pRT4+1Nd5UMODDCB9OpRsIE17kwXVS4KM+8 ZsWLTgHHhJ+yEYvQoxn6H4FjCdBk91Bu81O9swo1mBxhE/h6OkIfiNr+aeZ1OCPz5j/b0k qLvnDx3v1l5XGHGJ9hfu1AX06SpTksA= From: Thomas Huth To: Paolo Bonzini , qemu-devel@nongnu.org, Eduardo Habkost , "Michael S. Tsirkin" Date: Mon, 9 Dec 2019 13:52:46 +0100 Message-Id: <20191209125248.5849-3-thuth@redhat.com> In-Reply-To: <20191209125248.5849-1-thuth@redhat.com> References: <20191209125248.5849-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: libvir-list@redhat.com, Gerd Hoffmann , Marcel Apfelbaum Subject: [libvirt] [PATCH v2 2/4] hw/audio: Remove the "use_broken_id" hack from the AC97 device X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: 5dyrNFedM46XPpEXIAxHtQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Now that the old pc-0.x machine types are gone, we do not need the "use_broken_id" hack anymore. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth --- hw/audio/ac97.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c index a136b97f68..78cda88333 100644 --- a/hw/audio/ac97.c +++ b/hw/audio/ac97.c @@ -161,7 +161,6 @@ typedef struct AC97BusMasterRegs { typedef struct AC97LinkState { PCIDevice dev; QEMUSoundCard card; - uint32_t use_broken_id; uint32_t glob_cnt; uint32_t glob_sta; uint32_t cas; @@ -1373,13 +1372,6 @@ static void ac97_realize(PCIDevice *dev, Error **err= p) c[PCI_BASE_ADDRESS_0 + 6] =3D 0x00; c[PCI_BASE_ADDRESS_0 + 7] =3D 0x00; =20 - if (s->use_broken_id) { - c[PCI_SUBSYSTEM_VENDOR_ID] =3D 0x86; - c[PCI_SUBSYSTEM_VENDOR_ID + 1] =3D 0x80; - c[PCI_SUBSYSTEM_ID] =3D 0x00; - c[PCI_SUBSYSTEM_ID + 1] =3D 0x00; - } - c[PCI_INTERRUPT_LINE] =3D 0x00; /* intr_ln interrupt line rw */ c[PCI_INTERRUPT_PIN] =3D 0x01; /* intr_pn interrupt pin ro */ =20 @@ -1411,7 +1403,6 @@ static int ac97_init (PCIBus *bus) =20 static Property ac97_properties[] =3D { DEFINE_AUDIO_PROPERTIES(AC97LinkState, card), - DEFINE_PROP_UINT32 ("use_broken_id", AC97LinkState, use_broken_id, 0), DEFINE_PROP_END_OF_LIST (), }; =20 --=20 2.18.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list