From nobody Sat May 18 23:23:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1575645849; cv=none; d=zohomail.com; s=zohoarc; b=cw7H+vf04UF9yNulDVeUthR+2vwNcZ9U76gWHchmif4Xz/AXn9n1XEkE1hCB5Kql8DHFu08gmlgFb1KM0dMJdTULNaOqOVWz/nY9AWrFyzqRuwBkDUMCLnULXO70KjH2YnxrRx9727PSqVvZe0tCqMKMs7koj8R8umG/Zg7ymIo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575645849; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=o29je3etiO/05nSUEXSMJxvGe5t1umAhmRrnSm2/qFg=; b=BeycwHLfXZzOQK20SObOqqwM4yO2M3wFlpnLyPpfG/+A2Ajl6etHtgDmFGBaIw3cHY+0RcxjRXWNUIqIpihw8oQsD/8R8LPjCmqrnfVPgQq2RAcG0CZy+pC/vug6Zsbuvnn2V/XbtBOoPb13mTHjKm90XYkGvLR+0v/E4rm5Ss8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1575645849307378.5003455897231; Fri, 6 Dec 2019 07:24:09 -0800 (PST) Received: from localhost ([::1]:39662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idFSh-00008T-Ik for importer@patchew.org; Fri, 06 Dec 2019 10:24:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55434) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idEh1-0004PI-UR for qemu-devel@nongnu.org; Fri, 06 Dec 2019 09:34:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idEh0-0003Tu-O7 for qemu-devel@nongnu.org; Fri, 06 Dec 2019 09:34:51 -0500 Received: from mga09.intel.com ([134.134.136.24]:17868) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1idEh0-0003FH-DS for qemu-devel@nongnu.org; Fri, 06 Dec 2019 09:34:50 -0500 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2019 23:07:42 -0800 Received: from he.bj.intel.com ([10.238.157.85]) by orsmga002.jf.intel.com with ESMTP; 05 Dec 2019 23:07:40 -0800 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,283,1571727600"; d="scan'208";a="223913919" From: Yang Zhong To: pbonzini@redhat.com Subject: [PATCH] target/i386: disable VMX features if nested=0 Date: Fri, 6 Dec 2019 15:11:11 +0800 Message-Id: <20191206071111.12128-1-yang.zhong@intel.com> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.24 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yang.zhong@intel.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" If kvm does not support VMX feature by nested=3D0, the kvm_vmx_basic can't get the right value from MSR_IA32_VMX_BASIC register, which make qemu coredump when qemu do KVM_SET_MSRS. The coredump info: error: failed to set MSR 0x480 to 0x0 kvm_put_msrs: Assertion `ret =3D=3D cpu->kvm_msr_buf->nmsrs' failed. Signed-off-by: Yang Zhong --- target/i386/kvm.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index bf1655645b..e8841dcdb9 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -2572,6 +2572,14 @@ static void kvm_msr_entry_add_vmx(X86CPU *cpu, Featu= reWordArray f) uint64_t kvm_vmx_basic =3D kvm_arch_get_supported_msr_feature(kvm_state, MSR_IA32_VMX_BASIC); + if (!kvm_vmx_basic) { + /* If the kernel does't support VMX feature(nested=3D0 in kvm) + * and kvm_vmx_basic will be 0. This will set 0 value to + * MSR_IA32_VMX_BASIC MSR. + */ + return; + } + uint64_t kvm_vmx_misc =3D kvm_arch_get_supported_msr_feature(kvm_state, MSR_IA32_VMX_MISC); --=20 2.17.1