From nobody Fri Apr 26 00:25:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575281550; cv=none; d=zohomail.com; s=zohoarc; b=XGhDlWm9NBsIrTFU9GkDQFfsNdCB6D9WRbM8HgB+Lgz61GT8P38CbCHuJw0+BuN2yZa3yTKckVWcS7YVBNLVvcgFBfGj1y+NfShoycZlc+TFTjpLz2tQjiCrnGPw5SXVxAQYWK0+SlCm91e9ZNLmp+tvFC8cpOUbBxQK4N+WmGg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575281550; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=LW9vfVfP6WQf/BBc/u6uwPPW40eTp/44+B947kMH/G0=; b=kTRWSUsaAh4M+QI9VYPt3aTL4rCI7iXWn8oACctQu+PiFetcw011AsgiLfSbVHLyZXuGr7Po7PI9qZ3QR8IS8UnHwMK5BQ2RmmvUeUZjUYVCuxZU0hXXtsB9mrq9WRa4VLymZchWaBGaygpvbms0NrzBM1294heOLTzCYqT3kgI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1575281550088145.77460616762767; Mon, 2 Dec 2019 02:12:30 -0800 (PST) Received: from localhost ([::1]:33304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibigu-0003F5-L0 for importer@patchew.org; Mon, 02 Dec 2019 05:12:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59996) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibifO-0001Zv-9S for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:10:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibifM-0004sM-QC for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:10:54 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:23924 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ibifM-0004s4-M2 for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:10:52 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-n4ZoMZHpNYaOFIYiC3aG8A-1; Mon, 02 Dec 2019 05:10:49 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1B8C800EB7; Mon, 2 Dec 2019 10:10:48 +0000 (UTC) Received: from thuth.com (ovpn-117-196.ams2.redhat.com [10.36.117.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59DBC19C68; Mon, 2 Dec 2019 10:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575281452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LW9vfVfP6WQf/BBc/u6uwPPW40eTp/44+B947kMH/G0=; b=S3ws1Z6ghmo1aToTk+K5IGvuLbwXqnVAYaesn5p9IzfVXQy7Q1DYxTZt1pwo/BA/wP4laG 8FrVqmaxLgFYlL89cMmAGpm+ZIykzIq5BudIRhssZEiciDjTckKa9EJeQv6edJ+lojS3jV j8Ked9kpDQwxGts0IPMV4voGCrI08RI= From: Thomas Huth To: qemu-block@nongnu.org, Kevin Wolf , Max Reitz Subject: [PATCH v4 1/6] iotests: remove 'linux' from default supported platforms Date: Mon, 2 Dec 2019 11:10:34 +0100 Message-Id: <20191202101039.8981-2-thuth@redhat.com> In-Reply-To: <20191202101039.8981-1-thuth@redhat.com> References: <20191202101039.8981-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: n4ZoMZHpNYaOFIYiC3aG8A-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effe= ct of enabling these tests on non-linux platforms. For tests that always specified linux explicitly, there is no change. For Python tests on FreeBSD at least; only seven python tests fail: 045 147 149 169 194 199 211 045 and 149 appear to be misconfigurations, 147 and 194 are the AF_UNIX path too long error, 169 and 199 are bitmap migration bugs, and 211 is a bug that shows up on Linux platforms, too. This is at least good evidence that these tests are not Linux-only. If they aren't suitable for other platforms, they should be disabled on a per-platform basis as appropriate. Therefore, let's switch these on and deal with the failures. Reviewed-by: Max Reitz Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index df0708923d..de8b904d87 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -896,9 +896,14 @@ def verify_protocol(supported=3D[], unsupported=3D[]): if not_sup or (imgproto in unsupported): notrun('not suitable for this protocol: %s' % imgproto) =20 -def verify_platform(supported_oses=3D['linux']): - if True not in [sys.platform.startswith(x) for x in supported_oses]: - notrun('not suitable for this OS: %s' % sys.platform) +def verify_platform(supported=3DNone, unsupported=3DNone): + if unsupported is not None: + if any((sys.platform.startswith(x) for x in unsupported)): + notrun('not suitable for this OS: %s' % sys.platform) + + if supported is not None: + if not any((sys.platform.startswith(x) for x in supported)): + notrun('not suitable for this OS: %s' % sys.platform) =20 def verify_cache_mode(supported_cache_modes=3D[]): if supported_cache_modes and (cachemode not in supported_cache_modes): @@ -989,7 +994,8 @@ def execute_unittest(output, verbosity, debug): sys.stderr.write(out) =20 def execute_test(test_function=3DNone, - supported_fmts=3D[], supported_oses=3D['linux'], + supported_fmts=3D[], + supported_platforms=3DNone, supported_cache_modes=3D[], unsupported_fmts=3D[], supported_protocols=3D[], unsupported_protocols=3D[]): """Run either unittest or script-style tests.""" @@ -1006,7 +1012,7 @@ def execute_test(test_function=3DNone, verbosity =3D 1 verify_image_format(supported_fmts, unsupported_fmts) verify_protocol(supported_protocols, unsupported_protocols) - verify_platform(supported_oses) + verify_platform(supported=3Dsupported_platforms) verify_cache_mode(supported_cache_modes) =20 if debug: --=20 2.18.1 From nobody Fri Apr 26 00:25:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575281648; cv=none; d=zohomail.com; s=zohoarc; b=Ibfp+d7nVZiocn+tXDXMQdsjsK+SHba4fec6axyk5JfEatgbgnQjGBMP8wyd4lH3eel5S6twi18QU0qeO84rzEJ+2sxSiAgI+N++7xRsMn97iQudxBM/gIIHRNfmQ9PIdcYr67ypUo1TVyHRucdv6ltNhMpwsxnPnSbqrjhCxOw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575281648; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=F6xpS5jn3FPueHeHNbHmw7PW4u/jvYS3g/pddsd2v1A=; b=mSTAXzoNctvkOyok0jD8UmP7ccjQjmZgfHLZSzpRlDNZ2Eo6gP4/IIK4bM8WsvvLwkUO09s2hlFRSxCGwMLlDkq6QgAUfcKzNVgSh7wG+hQa9e4X0OoKubnsePOQtcDVMUhxd9VRWGj2JaA0GAA5Vy8kGpC+LbkwtF+4zjNpYEo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1575281648977179.47304360654698; Mon, 2 Dec 2019 02:14:08 -0800 (PST) Received: from localhost ([::1]:33340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibiiV-0005jt-TD for importer@patchew.org; Mon, 02 Dec 2019 05:14:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60009) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibifP-0001b2-5i for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:10:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibifO-0004tJ-5i for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:10:55 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:56240 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ibifO-0004t7-2C for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:10:54 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-n13LhOoUOaK26A141wEq1g-1; Mon, 02 Dec 2019 05:10:52 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 78192800D4C; Mon, 2 Dec 2019 10:10:51 +0000 (UTC) Received: from thuth.com (ovpn-117-196.ams2.redhat.com [10.36.117.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1AFE319C68; Mon, 2 Dec 2019 10:10:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575281453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F6xpS5jn3FPueHeHNbHmw7PW4u/jvYS3g/pddsd2v1A=; b=UFDp5nfgYrCY6SE6z87vjUyCPLoBlF2kpA4UL0cU3iQWjVzONbjeoNYEyFWd645/2tIG+/ t5D9UMyPtGAQOr3PERI69txUV1E1XexB4xBbmnSqwtkbmIXoZAm8zf+ZIMUwtYNE5IlZeB WuMoUAeSt/cBKsD8forq/3B/znuDfoI= From: Thomas Huth To: qemu-block@nongnu.org, Kevin Wolf , Max Reitz Subject: [PATCH v4 2/6] iotests: Test 041 only works on certain systems Date: Mon, 2 Dec 2019 11:10:35 +0100 Message-Id: <20191202101039.8981-3-thuth@redhat.com> In-Reply-To: <20191202101039.8981-1-thuth@redhat.com> References: <20191202101039.8981-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: n13LhOoUOaK26A141wEq1g-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" 041 works fine on Linux, FreeBSD, NetBSD and OpenBSD, but fails on macOS. Let's mark it as only supported on the systems where we know that it is working fine. Signed-off-by: Thomas Huth Reviewed-by: Max Reitz --- tests/qemu-iotests/041 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index 8568426311..0326888c98 100755 --- a/tests/qemu-iotests/041 +++ b/tests/qemu-iotests/041 @@ -1123,4 +1123,5 @@ class TestOrphanedSource(iotests.QMPTestCase): =20 if __name__ =3D=3D '__main__': iotests.main(supported_fmts=3D['qcow2', 'qed'], - supported_protocols=3D['file']) + supported_protocols=3D['file'], + supported_platforms=3D['linux', 'freebsd', 'netbsd', 'ope= nbsd']) --=20 2.18.1 From nobody Fri Apr 26 00:25:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575281552; cv=none; d=zohomail.com; s=zohoarc; b=YMngYAaG5b0Oi2JWae8KYkR/1HuTXMqA2c+nOYg9AG+z8+ZH6+7Ddbfb3ZG2Vk6Iw6Q1fY2fgQkkDxL3e376XUCX2aJzdx3zzqadIL11iIpXrWyA8k01bUocGfugCX0mjC5InpynWUR0cW17Rwzi7Yeh/hMibizWXI+BKlZPq+k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575281552; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=O2Z3+As+UUjZZvK4a3KeXRi6hSKm32Oq0U6w7Ks/Y0U=; b=aCcrgQ2ha7Jgxr4jFVuo+32BRoOIHhoCHlwWMbkj1oeCGZBikiPM9PyWefFclJqA+QSFqTvLcHGw7VpjijYX0otfZZjuTcFbjoOvGZrhM9zpxkOC4OWrOyLnKwul9y+dz3qv3Dr5qT9GGP862j21T4eRTDjeKENpn8yVdK2z2HA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1575281552416207.6632671368776; Mon, 2 Dec 2019 02:12:32 -0800 (PST) Received: from localhost ([::1]:33306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibigw-0003Mj-Qn for importer@patchew.org; Mon, 02 Dec 2019 05:12:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60050) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibifS-0001iJ-JJ for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:10:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibifR-0004wa-Ho for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:10:58 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:53606 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ibifR-0004wK-EP for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:10:57 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-65-AMy0sVu2NX6K8nzevX3hXw-1; Mon, 02 Dec 2019 05:10:55 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1AC3C18B5FA3; Mon, 2 Dec 2019 10:10:54 +0000 (UTC) Received: from thuth.com (ovpn-117-196.ams2.redhat.com [10.36.117.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id D7D8C19C68; Mon, 2 Dec 2019 10:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575281457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O2Z3+As+UUjZZvK4a3KeXRi6hSKm32Oq0U6w7Ks/Y0U=; b=TwEU5MEZ0m7GH3po1qWkqL4c2xf37vZQ8O+JPJ/31ELaUj2lR+KU2WZCMEA8gQwNdounKV PD8gxLSiM3RflB6Up73jCiWpcHHwB0c6Ind2vjLlqmZRwlRWedOhOEmg2aup79q4qUDrBP l+839AkgcDwOmZFeIXzoVhsAmuWQcS8= From: Thomas Huth To: qemu-block@nongnu.org, Kevin Wolf , Max Reitz Subject: [PATCH v4 3/6] iotests: Test 183 does not work on macOS and OpenBSD Date: Mon, 2 Dec 2019 11:10:36 +0100 Message-Id: <20191202101039.8981-4-thuth@redhat.com> In-Reply-To: <20191202101039.8981-1-thuth@redhat.com> References: <20191202101039.8981-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: AMy0sVu2NX6K8nzevX3hXw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In the long term, we might want to add test 183 to the "auto" group (but it still fails occasionally, so we cannot do that yet). However, when running 183 in Cirrus-CI on macOS, or with our vm-build-openbsd target, it currently always fails with an "Timeout waiting for return on handle 0" error. Let's mark it as supported only on systems where the test is working fine (i.e. Linux, FreeBSD and NetBSD). Signed-off-by: Thomas Huth Reviewed-by: Max Reitz --- tests/qemu-iotests/183 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/183 b/tests/qemu-iotests/183 index bced83fae0..0bbae13647 100755 --- a/tests/qemu-iotests/183 +++ b/tests/qemu-iotests/183 @@ -42,6 +42,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 . ./common.filter . ./common.qemu =20 +_supported_os Linux FreeBSD NetBSD _supported_fmt qcow2 raw qed quorum _supported_proto file =20 --=20 2.18.1 From nobody Fri Apr 26 00:25:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575281844; cv=none; d=zohomail.com; s=zohoarc; b=MmLIYIp40EDbKrt3fRu6ew8dEvaxeX2QE0pDAxyXDVzqFCGuaJfljtAbT7Sgl5YgA87E9+Si1TGkX7YeO/ihGVk6ph8vFNm5AYcJYWbXWYaqiQgZq6+mrw7P2Mf01o3tQAqDN+MIbO8LZlVUiOiXeBmhC1mB36fkglHtUQFCTrE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575281844; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=puEfc5jF0/P7uJ8jt9sYIJzKomt/3a3r+moaOK4a4pE=; b=do+icpAsjVpY4R6hkxcdbDrC4Dp1Gfa1gT9BC9ImnWtrtVwp9v1m/aSNqBDSs0Otw5tQaUbVz4t6hCoo7m/sSqANVTbNbmviauTtQ5my1QklWO3WygCBltRHdV13pZD/VD76f9VquHIg+h0PMqiBjYbWiUuhb7mmACuFO0xarCM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1575281844669576.0339770812345; Mon, 2 Dec 2019 02:17:24 -0800 (PST) Received: from localhost ([::1]:33370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibilf-00082I-0V for importer@patchew.org; Mon, 02 Dec 2019 05:17:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60105) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibifX-0001qW-3N for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:11:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibifV-0004z9-RE for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:11:03 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:53070 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ibifV-0004yz-OE for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:11:01 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-69-5azACmADOMKJDqIVff8CFQ-1; Mon, 02 Dec 2019 05:10:56 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9F49E107ACC5; Mon, 2 Dec 2019 10:10:55 +0000 (UTC) Received: from thuth.com (ovpn-117-196.ams2.redhat.com [10.36.117.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 68E1719C68; Mon, 2 Dec 2019 10:10:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575281461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=puEfc5jF0/P7uJ8jt9sYIJzKomt/3a3r+moaOK4a4pE=; b=Ja6bMWCCsIixCmPYlN9bIEH2rxyPq0ucTTI2C3lqF9MyKq5QIFJPPkAPu42ltMZHqc+paa BV5z2jLIbgoeMgZt0M58z+UW+nEvdIl//UY5bQ7byxSerrOld3vAS0qReqNAOa3M+KXUlC JefOHAu33USHOsbUQgxb7kePxW4pYPo= From: Thomas Huth To: qemu-block@nongnu.org, Kevin Wolf , Max Reitz Subject: [PATCH v4 4/6] iotests: Check for the availability of the required devices in 267 and 127 Date: Mon, 2 Dec 2019 11:10:37 +0100 Message-Id: <20191202101039.8981-5-thuth@redhat.com> In-Reply-To: <20191202101039.8981-1-thuth@redhat.com> References: <20191202101039.8981-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: 5azACmADOMKJDqIVff8CFQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We are going to enable 127 in the "auto" group, but it only works if virtio-scsi and scsi-hd are available - which is not the case with QEMU binaries like qemu-system-tricore for example, so we need a proper check for the availability of these devices here. A very similar problem exists in iotest 267 - it has been added to the "auto" group already, but requires virtio-blk and thus currently fails with qemu-system-tricore for example. Let's also add aproper check there. Signed-off-by: Thomas Huth Reviewed-by: Max Reitz --- tests/qemu-iotests/127 | 2 ++ tests/qemu-iotests/267 | 2 ++ tests/qemu-iotests/common.rc | 14 ++++++++++++++ 3 files changed, 18 insertions(+) diff --git a/tests/qemu-iotests/127 b/tests/qemu-iotests/127 index b64926ab31..a4fc866038 100755 --- a/tests/qemu-iotests/127 +++ b/tests/qemu-iotests/127 @@ -43,6 +43,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 _supported_fmt qcow2 _supported_proto file =20 +_require_devices virtio-scsi scsi-hd + IMG_SIZE=3D64K =20 _make_test_img $IMG_SIZE diff --git a/tests/qemu-iotests/267 b/tests/qemu-iotests/267 index 170e173c0a..17ac640a83 100755 --- a/tests/qemu-iotests/267 +++ b/tests/qemu-iotests/267 @@ -44,6 +44,8 @@ _supported_os Linux # Internal snapshots are (currently) impossible with refcount_bits=3D1 _unsupported_imgopts 'refcount_bits=3D1[^0-9]' =20 +_require_devices virtio-blk + do_run_qemu() { echo Testing: "$@" diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index 0cc8acc9ed..38e949cf69 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests/common.rc @@ -643,5 +643,19 @@ _require_drivers() done } =20 +# Check that a set of devices is available in the QEMU binary +# +_require_devices() +{ + available=3D$($QEMU -M none -device help | \ + grep ^name | sed -e 's/^name "//' -e 's/".*$//') + for device + do + if ! echo "$available" | grep -q "$device" ; then + _notrun "$device not available" + fi + done +} + # make sure this script returns success true --=20 2.18.1 From nobody Fri Apr 26 00:25:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575281848; cv=none; d=zohomail.com; s=zohoarc; b=KvP+ZrmSQnCsd0/9YV99W1Y7TLQ/gTYXcU9ej1h4hsb6jYfJaEIxHyzsv0UgLxpiAKJgsP8BTtjiKWFXpivI2x1uvVRSRps/Xu7UCaTqhQ91IyUCMrSm8T7NGdRGSWmI76dDyCAbvB7Lx+lwj8NxoN0+uvahw4DOIxLkc4lSHWA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575281848; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=0sSaJ5Yo6VbNBzWtV5Wh3mBfYOPEEqnlgqFoIqQwA2w=; b=KtAL7CPgu2pqoM8TrhgemzWu0AGzzn3OHezA0H9jxpPfVjGeVsPQUOnP/ABLPaDHyKeL/fDKq4j3D4diH5o1lfEHZGB+Qv1SJ6FmEFzQJIi22NBHXNpC2kyk/9hfr/DsuIdNR1fACBJFn7o+owJ10a5tq+eC7ALOFq7xfUH8jVs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1575281848151213.07968545216102; Mon, 2 Dec 2019 02:17:28 -0800 (PST) Received: from localhost ([::1]:33372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibili-00088C-JL for importer@patchew.org; Mon, 02 Dec 2019 05:17:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60130) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibifb-0001xM-0K for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:11:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibifZ-00051f-Va for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:11:06 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:42457 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ibifZ-00051P-Rx for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:11:05 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-130-D7qeQ5J6OOOLmZnbCMbWMA-1; Mon, 02 Dec 2019 05:10:58 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D332800D4C; Mon, 2 Dec 2019 10:10:57 +0000 (UTC) Received: from thuth.com (ovpn-117-196.ams2.redhat.com [10.36.117.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC93F19C68; Mon, 2 Dec 2019 10:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575281465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0sSaJ5Yo6VbNBzWtV5Wh3mBfYOPEEqnlgqFoIqQwA2w=; b=KoULo5JiOZR71nFNST4pKMLLeSdfbGmpVTi9CAm9prqAkziIRMU7VApe2THB81e3J4XeDr w/bzzPQU1cbOLZkYGsoKY07c7N4Kg7xK6ddAelwvO2hYzahxr+2A7vSurHjcGaRHohyPyU NkSmpzOga0Y+DKdzPItaRVakGP0MxJk= From: Thomas Huth To: qemu-block@nongnu.org, Kevin Wolf , Max Reitz Subject: [PATCH v4 5/6] iotests: Skip Python-based tests if QEMU does not support virtio-blk Date: Mon, 2 Dec 2019 11:10:38 +0100 Message-Id: <20191202101039.8981-6-thuth@redhat.com> In-Reply-To: <20191202101039.8981-1-thuth@redhat.com> References: <20191202101039.8981-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: D7qeQ5J6OOOLmZnbCMbWMA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We are going to enable some of the python-based tests in the "auto" group, and these tests require virtio-blk to work properly. Running iotests without virtio-blk likely does not make too much sense anyway, so instead of adding a check for the availability of virtio-blk to each and every test (which does not sound very appealing), let's rather add a check for this a central spot in the "check" script instead (so that it is still possible to run "make check" for qemu-system-tricore for example). Signed-off-by: Thomas Huth Reviewed-by: Max Reitz --- tests/qemu-iotests/check | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index 90970b0549..bce3035d5a 100755 --- a/tests/qemu-iotests/check +++ b/tests/qemu-iotests/check @@ -642,7 +642,11 @@ fi python_usable=3Dfalse if $PYTHON -c 'import sys; sys.exit(0 if sys.version_info >=3D (3,6) else = 1)' then - python_usable=3Dtrue + # Our python framework also requires virtio-blk + if "$QEMU_PROG" -M none -device help | grep -q virtio-blk >/dev/null 2= >&1 + then + python_usable=3Dtrue + fi fi =20 default_machine=3D$($QEMU_PROG -machine help | sed -n '/(default)/ s/ .*//= p') @@ -830,7 +834,7 @@ do run_command=3D"$PYTHON $seq" else run_command=3D"false" - echo "Unsupported Python version" > $seq.notrun + echo "Unsupported Python version or missing virtio-blk" > = $seq.notrun fi else run_command=3D"./$seq" --=20 2.18.1 From nobody Fri Apr 26 00:25:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575281646; cv=none; d=zohomail.com; s=zohoarc; b=JwgDJpXEzahQ8eaXpDZywnzkvYIQZjQhT73bZTrZzM1Rs2Hwicd4tLNoLZB4rTEynGKJGVR0hOFnAIQIr0k+MYMmqxB/cd9qFWu6JXqJ55yXUB0ZC/ygPlg9pWZe0KOoPVafjLqTVHt7Kq0oFG+CjDzfDkfUjTqjJ0bxZAU3npI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575281646; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Xf7c8Wn8ZMA8+E/9j9O/2nzZifo9pxZYq54Hva9fVrA=; b=BGg2faPvC2+TBpJInE1DNrQxR7/5/QWvZw8dgKpptRTF2wkcOdPgXhAMAqiPkt9dA4WK8SasHNo5gTIW21i5P0BBOVBX61o1hEJaUmDcv6j0lkP4w7CVh7NNU9shw9fiW7Ir6CpHfTw+C/2OuSzPyd6/fdiswHpTaWEJcnR5PxU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1575281646516443.3184416210079; Mon, 2 Dec 2019 02:14:06 -0800 (PST) Received: from localhost ([::1]:33338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibiiT-0005hC-DD for importer@patchew.org; Mon, 02 Dec 2019 05:14:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60094) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibifW-0001p2-8Y for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:11:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibifV-0004yd-4R for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:11:02 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:26714 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ibifV-0004yU-0W for qemu-devel@nongnu.org; Mon, 02 Dec 2019 05:11:01 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-277-lt2QRzt9MiuXCXNVEvl65Q-1; Mon, 02 Dec 2019 05:10:59 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BB54618B5FA0; Mon, 2 Dec 2019 10:10:58 +0000 (UTC) Received: from thuth.com (ovpn-117-196.ams2.redhat.com [10.36.117.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A47919C68; Mon, 2 Dec 2019 10:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575281460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xf7c8Wn8ZMA8+E/9j9O/2nzZifo9pxZYq54Hva9fVrA=; b=VVz814oCrTvjAA6mgFqYDNrAX94hDEDtafSduw5vOYI/wusnk8nGsHOylcltwYTGp+wOmq 8WO1O9d1tS1kuYTMbRCZQg2hd8Tmme7DYsUXSK1r86wHFgAAIkPI2PfpvtuDSZY3g6d83G chHlZ8fFDnMTEiCUobQjAYMuyIZgOtk= From: Thomas Huth To: qemu-block@nongnu.org, Kevin Wolf , Max Reitz Subject: [PATCH v4 6/6] iotests: Enable more tests in the 'auto' group to improve test coverage Date: Mon, 2 Dec 2019 11:10:39 +0100 Message-Id: <20191202101039.8981-7-thuth@redhat.com> In-Reply-To: <20191202101039.8981-1-thuth@redhat.com> References: <20191202101039.8981-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: lt2QRzt9MiuXCXNVEvl65Q-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" According to Kevin, tests 030, 040 and 041 are among the most valuable tests that we have, so we should always run them if possible, even if they take a little bit longer. According to Max, it would be good to have a test for iothreads and migration. 127 and 256 seem to be good candidates for iothreads. For migration, let's enable 181 and 203 (which also tests iothreads). (091 would be a good candidate for migration, too, but Alex Benn=C3=A9e reported that this test fails on ZFS file systems, so it can't be included yet) Signed-off-by: Thomas Huth Reviewed-by: Max Reitz --- tests/qemu-iotests/group | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index 6b10a6a762..2b56392e31 100644 --- a/tests/qemu-iotests/group +++ b/tests/qemu-iotests/group @@ -51,7 +51,7 @@ 027 rw auto quick 028 rw backing quick 029 rw auto quick -030 rw backing +030 rw auto backing 031 rw auto quick 032 rw auto quick 033 rw auto quick @@ -61,8 +61,8 @@ 037 rw auto backing quick 038 rw auto backing quick 039 rw auto quick -040 rw -041 rw backing +040 rw auto +041 rw auto backing 042 rw auto quick 043 rw auto backing 044 rw @@ -148,7 +148,7 @@ 124 rw backing 125 rw 126 rw auto backing -127 rw backing quick +127 rw auto backing quick 128 rw quick 129 rw quick 130 rw quick @@ -197,7 +197,7 @@ 177 rw auto quick 178 img 179 rw auto quick -181 rw migration +181 rw auto migration 182 rw quick 183 rw migration 184 rw auto quick @@ -218,7 +218,7 @@ 200 rw 201 rw migration 202 rw quick -203 rw migration +203 rw auto migration 204 rw quick 205 rw quick 206 rw @@ -270,7 +270,7 @@ 253 rw quick 254 rw backing quick 255 rw quick -256 rw quick +256 rw auto quick 257 rw 258 rw quick 260 rw quick --=20 2.18.1