From nobody Mon Feb 9 06:00:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1574938216; cv=none; d=zohomail.com; s=zohoarc; b=ZxX/CkC7ylmA9xK7avQcPwvWdIVuDCzjXc9ey55LeeIX9+LKZO7w7aaBU540ZX5HWZwQB9VNpxMrQ7/YFcxVYoC4CfjetuDQfsz6LALePVENEHDZ5K+GU17tqpBmlmMrKnq2q/RTnt0t8985uHKo0d+3E3kB5vWmNSoRqEN+nHA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1574938216; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=17RkeYDWridxywAnVAaOpHHRoXawPDSazaZNQZaZtDg=; b=eONsX95cWZSBS+X0+nSa/FYC4CSqsG34Ta8/Fxk6gHgTzu9kESC+AkabFHwOHt7J7zfYrlBd80POqSG9WCvI6o60HjKuqJxDMSraCf/jk5HahjGi8LxmOg00hx3cfaZvhzRJd2xPWEDUMua6O+UZILcQiyOQrnja66O2d2n3cgI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1574938216244475.5534798909687; Thu, 28 Nov 2019 02:50:16 -0800 (PST) Received: from localhost ([::1]:47544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaHND-00007Z-83 for importer@patchew.org; Thu, 28 Nov 2019 05:50:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51826) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaHF3-0003PP-8s for qemu-devel@nongnu.org; Thu, 28 Nov 2019 05:41:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iaHF2-0006OL-8s for qemu-devel@nongnu.org; Thu, 28 Nov 2019 05:41:45 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:26327 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iaHF2-00067i-2z for qemu-devel@nongnu.org; Thu, 28 Nov 2019 05:41:44 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26--CZf_fJPNYWrt0kANaZ2RA-1; Thu, 28 Nov 2019 05:41:38 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17AC6107ACC9; Thu, 28 Nov 2019 10:41:37 +0000 (UTC) Received: from dritchie.redhat.com (unknown [10.33.36.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7922D10013A7; Thu, 28 Nov 2019 10:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574937699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=17RkeYDWridxywAnVAaOpHHRoXawPDSazaZNQZaZtDg=; b=XIyt0PdeDprQVWEBGxcbqxiOSOHzP6e6/DCqhCDa4VbfbOlIb7fkoXNLw8GrnTGAvoy5hu UJoBepBZ0YAV/TCqpGot0QDmXZQrgDGpe5E8dmyuAlpDVkNuOa+k44SkVDgJihkTDF1OhV 7Rcb3J/E9Z/a2gca2jj0T9Lm5hwvz/s= From: Sergio Lopez To: qemu-devel@nongnu.org Subject: [PATCH v5 1/4] blockdev: fix coding style issues in drive_backup_prepare Date: Thu, 28 Nov 2019 11:41:26 +0100 Message-Id: <20191128104129.250206-2-slp@redhat.com> In-Reply-To: <20191128104129.250206-1-slp@redhat.com> References: <20191128104129.250206-1-slp@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: -CZf_fJPNYWrt0kANaZ2RA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Sergio Lopez , Markus Armbruster , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Fix a couple of minor coding style issues in drive_backup_prepare. Signed-off-by: Sergio Lopez Reviewed-by: Max Reitz --- blockdev.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 8e029e9c01..553e315972 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3620,7 +3620,7 @@ static BlockJob *do_drive_backup(DriveBackup *backup,= JobTxn *txn, =20 if (!backup->has_format) { backup->format =3D backup->mode =3D=3D NEW_IMAGE_MODE_EXISTING ? - NULL : (char*) bs->drv->format_name; + NULL : (char *) bs->drv->format_name; } =20 /* Early check to avoid creating target */ @@ -3630,8 +3630,10 @@ static BlockJob *do_drive_backup(DriveBackup *backup= , JobTxn *txn, =20 flags =3D bs->open_flags | BDRV_O_RDWR; =20 - /* See if we have a backing HD we can use to create our new image - * on top of. */ + /* + * See if we have a backing HD we can use to create our new image + * on top of. + */ if (backup->sync =3D=3D MIRROR_SYNC_MODE_TOP) { source =3D backing_bs(bs); if (!source) { --=20 2.23.0