From nobody Mon Feb 9 19:52:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1574331557; cv=none; d=zoho.com; s=zohoarc; b=ROHMtnlhfo415BKCBMm7PuaE6eaprHDR6/kUZd4ASMea5MREV+q+8ocXh2ajkj8oXu7r1gMiiZq5RPyY0xD33v8NOqtXckVp5Gb0K5ZR9hG4dz/WArS2Wl5IPMXh/hcFBAdSI6mYBMRC36fsCpLAajK9KiFMm0+87VXcDMd5JJE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1574331557; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=AlBLTUfmNbmfVPJn2njrpT5+GfbBLtiHY4uB+NBxM4I=; b=d5iDqyJqCT04KII44S1zKirhiOxsT15bQ2AjcnkG277v8tZw5s0Xn+2EmfXBSnqL9QBwb6Xn48K94bnKyU7xnnPz0ufwllnzw4KIiRk8uopVkjnTcKnh9JXv4iZO4+bCBH/gezuad3Ec3DRgiOPv8ZuZPBeEWVwaUkeJgHImQWk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1574331557599558.1477810557067; Thu, 21 Nov 2019 02:19:17 -0800 (PST) Received: from localhost ([::1]:38388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXjYQ-0000S8-RF for importer@patchew.org; Thu, 21 Nov 2019 05:19:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42251) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXjVl-0007Bm-Hn for qemu-devel@nongnu.org; Thu, 21 Nov 2019 05:16:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXjVk-0007Vj-GW for qemu-devel@nongnu.org; Thu, 21 Nov 2019 05:16:29 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:36197 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iXjVk-0007V1-CD for qemu-devel@nongnu.org; Thu, 21 Nov 2019 05:16:28 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-74-yrZ0f6DNNLe4rc9OJdIPWA-1; Thu, 21 Nov 2019 05:16:24 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 04213107ACC4; Thu, 21 Nov 2019 10:16:23 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-67.ams2.redhat.com [10.36.116.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 89A2452FC5; Thu, 21 Nov 2019 10:16:19 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 93FC317536; Thu, 21 Nov 2019 11:16:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574331387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AlBLTUfmNbmfVPJn2njrpT5+GfbBLtiHY4uB+NBxM4I=; b=IE30K6vUqxYEWJIoEm3MxrPJe3ccnw1bl8FunKeEflqcPOV9bdGNpt7a9mEmkAaooUHOrX aZ75MA+DoJOcuY05wbr8Z3/TCiEYzXecvlBaxddlvXbHNEHie4LRTZM1GIZ4BYi/UtBUYL p4oFV+pmkts41V9om8W8cUmlaPO9kDc= From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 2/3] display: xlnx_dp: Provide sufficient bytes for silent audio channel Date: Thu, 21 Nov 2019 11:16:17 +0100 Message-Id: <20191121101618.29289-3-kraxel@redhat.com> In-Reply-To: <20191121101618.29289-1-kraxel@redhat.com> References: <20191121101618.29289-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: yrZ0f6DNNLe4rc9OJdIPWA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sai Pavan Boddu , Alistair Francis , qemu-arm@nongnu.org, Gerd Hoffmann , "Edgar E. Iglesias" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Sai Pavan Boddu Fill the audio channel with required number of bytes to cover the elapsed time. This prevents rate control reset, and avoids debug prints like below log: Resetting rate control (65692 samples) ... Resetting rate control (65721 samples) ... Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis Message-id: 1573833408-2388-1-git-send-email-sai.pavan.boddu@xilinx.com Signed-off-by: Gerd Hoffmann --- hw/display/xlnx_dp.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c index fde3b21ea5f4..705844379794 100644 --- a/hw/display/xlnx_dp.c +++ b/hw/display/xlnx_dp.c @@ -394,13 +394,18 @@ static void xlnx_dp_audio_callback(void *opaque, int = avail) written =3D AUD_write(s->amixer_output_stream, &s->out_buffer[s->data_ptr], s->byte_left); } else { + int len_to_copy; /* * There is nothing to play.. We don't have any data! Fill the * buffer with zero's and send it. */ written =3D 0; - memset(s->out_buffer, 0, 1024); - AUD_write(s->amixer_output_stream, s->out_buffer, 1024); + while (avail) { + len_to_copy =3D MIN(AUD_CHBUF_MAX_DEPTH, avail); + memset(s->out_buffer, 0, len_to_copy); + avail -=3D AUD_write(s->amixer_output_stream, s->out_buffe= r, + len_to_copy); + } } } else { written =3D AUD_write(s->amixer_output_stream, --=20 2.18.1