[PATCH for 4.2?] tests/vm/centos: fix centos build target

Alex Bennée posted 1 patch 4 years, 4 months ago
Test asan passed
Test checkpatch passed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191120161436.13937-1-alex.bennee@linaro.org
tests/vm/centos | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH for 4.2?] tests/vm/centos: fix centos build target
Posted by Alex Bennée 4 years, 4 months ago
To be able to run the docker tests centos has here we have to install
python3 as well as the basic tools.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/vm/centos | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/vm/centos b/tests/vm/centos
index 53976f1c4c9..b9e851f2d33 100755
--- a/tests/vm/centos
+++ b/tests/vm/centos
@@ -73,7 +73,7 @@ class CentosVM(basevm.BaseVM):
         self.wait_ssh()
         self.ssh_root_check("touch /etc/cloud/cloud-init.disabled")
         self.ssh_root_check("yum update -y")
-        self.ssh_root_check("yum install -y docker make git")
+        self.ssh_root_check("yum install -y docker make git python3")
         self.ssh_root_check("systemctl enable docker")
         self.ssh_root("poweroff")
         self.wait()
-- 
2.20.1


Re: [PATCH for 4.2?] tests/vm/centos: fix centos build target
Posted by Philippe Mathieu-Daudé 4 years, 4 months ago
On 11/20/19 5:14 PM, Alex Bennée wrote:
> To be able to run the docker tests centos has here we have to install
> python3 as well as the basic tools.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tests/vm/centos | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/vm/centos b/tests/vm/centos
> index 53976f1c4c9..b9e851f2d33 100755
> --- a/tests/vm/centos
> +++ b/tests/vm/centos
> @@ -73,7 +73,7 @@ class CentosVM(basevm.BaseVM):
>           self.wait_ssh()
>           self.ssh_root_check("touch /etc/cloud/cloud-init.disabled")
>           self.ssh_root_check("yum update -y")
> -        self.ssh_root_check("yum install -y docker make git")
> +        self.ssh_root_check("yum install -y docker make git python3")
>           self.ssh_root_check("systemctl enable docker")
>           self.ssh_root("poweroff")
>           self.wait()
> 

It would be nice to have this fixed in 4.2.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


Re: [PATCH for 4.2?] tests/vm/centos: fix centos build target
Posted by Wainer dos Santos Moschetta 4 years, 4 months ago
On 11/20/19 2:14 PM, Alex Bennée wrote:
> To be able to run the docker tests centos has here we have to install
> python3 as well as the basic tools.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tests/vm/centos | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>


>
> diff --git a/tests/vm/centos b/tests/vm/centos
> index 53976f1c4c9..b9e851f2d33 100755
> --- a/tests/vm/centos
> +++ b/tests/vm/centos
> @@ -73,7 +73,7 @@ class CentosVM(basevm.BaseVM):
>           self.wait_ssh()
>           self.ssh_root_check("touch /etc/cloud/cloud-init.disabled")
>           self.ssh_root_check("yum update -y")
> -        self.ssh_root_check("yum install -y docker make git")
> +        self.ssh_root_check("yum install -y docker make git python3")
>           self.ssh_root_check("systemctl enable docker")
>           self.ssh_root("poweroff")
>           self.wait()