From nobody Wed May 8 10:15:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1574150446; cv=none; d=zoho.com; s=zohoarc; b=Buo/PtTUvE5y4Zk2r48NtuocJKWgcQ6bAfUifNwC5caML+NYR3PeWw5gPtcKn3a3HOUc9fLGglTNJ8M39XE12RI7uoBOGla8HtjzgViLSJpnPxGiyfIDktiiKcymM/MyFu9X/Yq/BZMP0HhWf9cwtGXO0X3D5uq3VNVZEUT7dpk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1574150446; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=soZDC3sPcccwkB8omLFcU90lXC+pRJIUN6L41pTdSf4=; b=iNnyLwJFPhnc70OIfYnBywlId3y87IhLhToHJpW5t9WTViYGmrEPcfWuEsmLGfLiNe4EHUiOaKz30FBqW1ESo7wsSrFKjq6pSyGK2UgVFlpdN7Iw8OodXwctQZwRvN1vNT79eC9vG6hzWn7Tyv1DMtDAj2iu7UaMKd/UYJagkc8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1574150446119112.24601669083802; Tue, 19 Nov 2019 00:00:46 -0800 (PST) Received: from localhost ([::1]:42434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWyRI-0002jj-OR for importer@patchew.org; Tue, 19 Nov 2019 03:00:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46961) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWyOj-0000d4-U5 for qemu-devel@nongnu.org; Tue, 19 Nov 2019 02:58:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWyOi-0003Va-Ub for qemu-devel@nongnu.org; Tue, 19 Nov 2019 02:58:05 -0500 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:36030) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWyOi-0003Th-LZ for qemu-devel@nongnu.org; Tue, 19 Nov 2019 02:58:04 -0500 Received: by mail-pl1-x643.google.com with SMTP id d7so11329305pls.3 for ; Mon, 18 Nov 2019 23:58:04 -0800 (PST) Received: from localhost ([116.247.112.152]) by smtp.gmail.com with ESMTPSA id 7sm12855352pgk.25.2019.11.18.23.58.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Nov 2019 23:58:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=soZDC3sPcccwkB8omLFcU90lXC+pRJIUN6L41pTdSf4=; b=lgWVpmrog50P2sobJieRZgOV2cnGFvcSVDDgS8IcxTOy2hnPEXDR3w9VoUEbJm/pXu A9pk2ipKcGdB0XHXtri+z5hsyq6uwsclqM/9+fKrroW+XQojuqSBBCsvxVCk00Y4+/C9 Qnd4Y52NeV5VPoBJW2qr/cdNElEXhoH1IK8JbPBDIDQ4s12wx3O83tQT2aYGNto6jO2C VI2yW2k8WERIoC9kCR3X7rJw//s2NcWcP+nro2DJrEqM7Bbd9w3ApbBA322yoZab6d+e s4DjcCnkIKg1Krjdg7W3QXCrY8TzRPCnW+1EJCjto5z2CmWp4y0sxUcIMljXttXNvD/8 fS0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=soZDC3sPcccwkB8omLFcU90lXC+pRJIUN6L41pTdSf4=; b=k1oBGqmGpU8Aj+mOBdvwGWiJi7EbI6vYWIYYIjverE9Ppgbr3bbYLH6a/2FhRGFIva zHbM33ZW4xIVIFbITn4BtYhSC60BAbugEnrOQA/P/PZp4jYzPsc3+spuyGRyDmu6MTh6 8eJNdGguuL+oj7l6wD+7NjwdHLs0ILfKVXNr9WVOYUMXH8fbj8QBLnIAc+gkHjavHS07 fhZDnpEUTcITtpolD7/iII7yyrzCaP0xHPU7IHivSxMi9GUiQ3LG8Iqhy/8VSqLPQt8e VifOhXwoiE/O2aAjivgKRgYocKUgLEV4pNuDvCAM87l2gABBsaPcisdBJt4uWMQguDab qV8Q== X-Gm-Message-State: APjAAAU29FVHe4/BjlFzPAt4T+io+STwPr7LkmExZyYuSXYlisyKjFEY 3CxlARBXU7RbPcGcSDSFrOM= X-Google-Smtp-Source: APXvYqx6MvhoVeGXUGqkXzm59EuXG4l0dcHnUJ+/ahjw0bOtJnSog9Xaqsl7/ZLno36DAEJg1hvRlg== X-Received: by 2002:a17:902:b715:: with SMTP id d21mr33464161pls.312.1574150283165; Mon, 18 Nov 2019 23:58:03 -0800 (PST) From: elohimes@gmail.com X-Google-Original-From: xieyongji@baidu.com To: mst@redhat.com, marcandre.lureau@redhat.com Subject: [PATCH v2] libvhost-user: Zero memory allocated for VuVirtqInflightDesc Date: Tue, 19 Nov 2019 15:57:59 +0800 Message-Id: <20191119075759.4334-1-xieyongji@baidu.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::643 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xie Yongji , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Xie Yongji Use a zero-initialized VuVirtqInflightDesc struct to avoid that scan-build reports that vq->resubmit_list[0].counter may be garbage value in vu_check_queue_inflights(). Fixes: 5f9ff1eff ("libvhost-user: Support tracking inflight I/O in shared memory") Reported-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Xie Yongji Reviewed-by: Marc-Andr=C3=A9 Lureau --- contrib/libvhost-user/libvhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/= libvhost-user.c index 68c27136ae..ec27b78ff1 100644 --- a/contrib/libvhost-user/libvhost-user.c +++ b/contrib/libvhost-user/libvhost-user.c @@ -992,7 +992,7 @@ vu_check_queue_inflights(VuDev *dev, VuVirtq *vq) vq->shadow_avail_idx =3D vq->last_avail_idx =3D vq->inuse + vq->used_i= dx; =20 if (vq->inuse) { - vq->resubmit_list =3D malloc(sizeof(VuVirtqInflightDesc) * vq->inu= se); + vq->resubmit_list =3D calloc(vq->inuse, sizeof(VuVirtqInflightDesc= )); if (!vq->resubmit_list) { return -1; } --=20 2.17.1