From nobody Tue Feb 10 05:44:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573767410; cv=none; d=zoho.com; s=zohoarc; b=kyUZQSB1SoPoB89Bw7fHGuneLdZoDuONmmEDfvllr1YZLpuPzz2xicAzo3+7x2v2T47x7YjHcavGbGN46Qj0KO35VUGbZAA4TzWKBLpvT2cNPJac3ubCyZ63UxHxX1VKYARJ6jbIINP3uVyg2Djz2ZqnTAfl25Yq3FPG2Hyk+eg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573767410; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ErE597zNsknTpXwjlbggVGyQOq4x4Cnoeq1ubYOh5+o=; b=HTguW9ocSTlGs7BSO5RhbrzGv+Q5xyzfx3x2EPGJVYthOVgfWwyGp7dNrr4ruK7Dvqr/vdrSohbBY0RXQHDhqsJZHc8igcrB36jXlSnNHGcyRFEwJwhghi/Qx4HXDn1NA72GGDabFF99PLE3Ylt+mm6rYaInYLbKbB5f1E6dU98= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1573767410117406.42965397256853; Thu, 14 Nov 2019 13:36:50 -0800 (PST) Received: from localhost ([::1]:33950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVMnI-0005RL-UV for importer@patchew.org; Thu, 14 Nov 2019 16:36:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49438) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVMky-0002Ug-76 for qemu-devel@nongnu.org; Thu, 14 Nov 2019 16:34:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVMkx-0004Ma-3d for qemu-devel@nongnu.org; Thu, 14 Nov 2019 16:34:24 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:20350 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iVMkw-0004MB-WD for qemu-devel@nongnu.org; Thu, 14 Nov 2019 16:34:23 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-WvLMB20wNCGxRy4Q93-PDg-1; Thu, 14 Nov 2019 16:34:19 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3DD3B1005502; Thu, 14 Nov 2019 21:34:18 +0000 (UTC) Received: from blue.redhat.com (ovpn-116-242.phx2.redhat.com [10.3.116.242]) by smtp.corp.redhat.com (Postfix) with ESMTP id D129067661; Thu, 14 Nov 2019 21:34:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573767262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ErE597zNsknTpXwjlbggVGyQOq4x4Cnoeq1ubYOh5+o=; b=J4vZJQKkMAGroRVg7sf1eJ8ezH/LkADPpN0nKm0egWm4CUkgi8h+SFod6zKedYyR7Khbwd vJI8nuIq+B3WSpw7aR8ogCHnYHZP0hxhRwLLsudA57ho44xBFl6MPW21GWxx4k97XMl9Wm IZcIwZaTPy1am9VGF2QR98bF7VTLECE= From: Eric Blake To: qemu-devel@nongnu.org Subject: [PATCH v3 1/4] iotests: Fix 173 Date: Thu, 14 Nov 2019 15:34:12 -0600 Message-Id: <20191114213415.23499-2-eblake@redhat.com> In-Reply-To: <20191114213415.23499-1-eblake@redhat.com> References: <20191114213415.23499-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: WvLMB20wNCGxRy4Q93-PDg-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "open list:Block layer core" , mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This test has been broken since 3.0. It used TEST_IMG to influence the name of a file created during _make_test_img, but commit 655ae6bb changed things so that the wrong file name is being created, which then caused _launch_qemu to fail. In the meantime, the set of events issued for the actions of the test has increased. Why haven't we noticed the failure? Because the test rarely gets run: './check -qcow2 173' is insufficient (that defaults to using file protocol) './check -nfs 173' is insufficient (that defaults to using raw format) so the test is only run with: ./check -qcow2 -nfs 173 Note that we already have a number of other problems with -nfs: ./check -nfs (fails 18/30) ./check -qcow2 -nfs (fails 45/76 after this patch, if exports does not permit 'insecure') and it's not on my priority list to fix those. Rather, I found this because of my next patch's work on tests using _send_qemu_cmd. Fixes: 655ae6b Signed-off-by: Eric Blake Reviewed-by: Max Reitz --- tests/qemu-iotests/173 | 4 ++-- tests/qemu-iotests/173.out | 6 +++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/173 b/tests/qemu-iotests/173 index 9e2fa2e73cb9..29dcaa1960df 100755 --- a/tests/qemu-iotests/173 +++ b/tests/qemu-iotests/173 @@ -47,9 +47,9 @@ size=3D100M BASE_IMG=3D"${TEST_DIR}/image.base" TOP_IMG=3D"${TEST_DIR}/image.snp1" -TEST_IMG=3D"${BASE_IMG}" _make_test_img $size +TEST_IMG_FILE=3D"${BASE_IMG}" _make_test_img $size -TEST_IMG=3D"${TOP_IMG}" _make_test_img $size +TEST_IMG_FILE=3D"${TOP_IMG}" _make_test_img $size echo echo =3D=3D=3D Running QEMU, using block-stream to find backing image =3D= =3D=3D diff --git a/tests/qemu-iotests/173.out b/tests/qemu-iotests/173.out index f477a0099a32..e83d17ec2f64 100644 --- a/tests/qemu-iotests/173.out +++ b/tests/qemu-iotests/173.out @@ -7,6 +7,10 @@ Formatting 'TEST_DIR/image.snp1', fmt=3DIMGFMT size=3D1048= 57600 {"return": {}} {"return": {}} {"return": {}} +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event"= : "JOB_STATUS_CHANGE", "data": {"status": "created", "id": "disk2"}} +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event"= : "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "disk2"}} {"return": {}} -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event"= : "BLOCK_JOB_COMPLETED", "data": {"device": "disk2", "len": 104857600, "off= set": 104857600, "speed": 0, "type": "stream"}} +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event"= : "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id": "disk2"}} +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event"= : "JOB_STATUS_CHANGE", "data": {"status": "pending", "id": "disk2"}} +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event"= : "BLOCK_JOB_COMPLETED", "data": {"device": "disk2", "len": 0, "offset": 0,= "speed": 0, "type": "stream"}} *** done --=20 2.21.0