From nobody Thu May 2 02:42:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1573667662; cv=none; d=zoho.com; s=zohoarc; b=gHhmSp6q6reE1FyeE56ATe18+9vqwpMg2XSUQpbH9CkljZ6XUvrYRQmExQMxaHbsuJGaUx55s12gnJCHYfeRdLZ63GE5eBjNP057cRZRrnWoOvdSubfIjqYmAHAUX5+8bFO8wHkt/+7oPNrURb/liyIMpV7MfB7q2QPQzuR0UNU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573667662; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ZTk8lipT115+oBxt9CoEBhDBVS84u2b6o05pZTOdUPM=; b=RW4nEau5GqKA0KM319O5FqjOtLB8DQni7742eczjV9SwfPVjHjWTLihIaAGJLhc99KZnmAOpSVTX2J16oJBqx9GcbYsQwMyEhFFenyXAUu6I7hX72p9uKUPcU00+FHTO0CETllShFFtq6KcADCPNw7TY1mSYpawJKoapBYIWG/0= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1573667662250228.46084678203158; Wed, 13 Nov 2019 09:54:22 -0800 (PST) Received: from localhost ([::1]:49426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUwqS-0001SV-Np for importer@patchew.org; Wed, 13 Nov 2019 12:54:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60144) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUwpo-00010u-PP for qemu-devel@nongnu.org; Wed, 13 Nov 2019 12:53:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUwpl-0004zW-Sz for qemu-devel@nongnu.org; Wed, 13 Nov 2019 12:53:38 -0500 Received: from forwardcorp1j.mail.yandex.net ([2a02:6b8:0:1619::183]:54942) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUwpl-0004xD-Cy for qemu-devel@nongnu.org; Wed, 13 Nov 2019 12:53:37 -0500 Received: from mxbackcorp1o.mail.yandex.net (mxbackcorp1o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::301]) by forwardcorp1j.mail.yandex.net (Yandex) with ESMTP id DBF6A2E1332; Wed, 13 Nov 2019 20:53:31 +0300 (MSK) Received: from vla1-5826f599457c.qloud-c.yandex.net (vla1-5826f599457c.qloud-c.yandex.net [2a02:6b8:c0d:35a1:0:640:5826:f599]) by mxbackcorp1o.mail.yandex.net (mxbackcorp/Yandex) with ESMTP id 5LGN0FAm7r-rU48nnAI; Wed, 13 Nov 2019 20:53:31 +0300 Received: from dynamic-red.dhcp.yndx.net (dynamic-red.dhcp.yndx.net [2a02:6b8:0:408:9c6c:1931:9853:bdc5]) by vla1-5826f599457c.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id nN38Y7fY7i-rUVa6qpD; Wed, 13 Nov 2019 20:53:30 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1573667611; bh=kiaYtEDJRHAH27d5egZ84LWQurvEf0kKTPc7W4M1eAM=; h=Message-Id:Date:Subject:To:From:Cc; b=HUhjHgE2dAdfkHTFkt/i2PIdyNJctZWLbwethLJ47roPGUmzwcmtKepLpaxvUySq1 mhVkanN4WtDaC1CN8nknqEeqg+BCXmFbfS1PBh2EDIsoRH81JQG6AwOnwwiM+SUrfr YqFCSbva66WSvoToXLIIxYpp+Oyr6ntm5vDPEHQg= Authentication-Results: mxbackcorp1o.mail.yandex.net; dkim=pass header.i=@yandex-team.ru From: Yury Kotov To: "Dr. David Alan Gilbert" , Juan Quintela Subject: [PATCH] migration: Fix the re-run check of the migrate-incoming command Date: Wed, 13 Nov 2019 20:53:25 +0300 Message-Id: <20191113175325.29765-1-yury-kotov@yandex-team.ru> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a02:6b8:0:1619::183 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, yc-core@yandex-team.ru Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Computed bodyhash is different from the expected one) Content-Type: text/plain; charset="utf-8" The current check sets an error but doesn't fail the command. This may cause a problem if new connection attempt by the same URI affects the first connection. Signed-off-by: Yury Kotov Reviewed-by: Darren Kenny Reviewed-by: Juan Quintela --- migration/migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/migration.c b/migration/migration.c index 354ad072fa..fa2005b49f 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1784,6 +1784,7 @@ void qmp_migrate_incoming(const char *uri, Error **er= rp) } if (!once) { error_setg(errp, "The incoming migration has already been started"= ); + return; } =20 qemu_start_incoming_migration(uri, &local_err); --=20 2.24.0