From nobody Thu May 16 14:31:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1573571578; cv=none; d=zoho.com; s=zohoarc; b=Rmnrs6uThO7h7ZVQMplSUNz9NeCY0NFrIOndvN/YXZpK7hXj6H4qfxQXYq/wYtAJ2tb/y08KIHNFeeeqEdbQ8rZoiIHBGQ6RrIf99l21L6YgyYlT//YtAGPGIogawKFt2qAuW2w9CNNovOH2m8VsKEg4IOjIZpW8HyGKBetEP98= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573571578; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=5WNDL2lokmvGs6pNFIyUYmSZANDD27WTJq6Cldgl7IE=; b=nSgX5fGX1zIcOP3H1ox2/TmlSUQsc0oTQSRep6q57DpihhDAWwS2BCKBi6f7RcgiZylxZrLYvlhr+Yyq+ijLIgufV3DW3VA5Wve1eUqQMr5Bujt+dV0EV5wTFgawC3OlE1JPNtObvZR8DtuaEDIaT6YJIbLa04OsJ+S8gNvl4PM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157357157851369.92372340823977; Tue, 12 Nov 2019 07:12:58 -0800 (PST) Received: from localhost ([::1]:36374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUXqh-0001hY-Ma for importer@patchew.org; Tue, 12 Nov 2019 10:12:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41249) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUXor-00082A-GV for qemu-devel@nongnu.org; Tue, 12 Nov 2019 10:11:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUXoq-0007F0-5t for qemu-devel@nongnu.org; Tue, 12 Nov 2019 10:11:01 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:35825) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUXop-0007Ea-W0 for qemu-devel@nongnu.org; Tue, 12 Nov 2019 10:11:00 -0500 Received: by mail-wm1-x334.google.com with SMTP id 8so3364096wmo.0 for ; Tue, 12 Nov 2019 07:10:59 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id n65sm5225445wmf.28.2019.11.12.07.10.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 07:10:57 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7A3041FF87; Tue, 12 Nov 2019 15:10:56 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5WNDL2lokmvGs6pNFIyUYmSZANDD27WTJq6Cldgl7IE=; b=hlIJxwMD39RjYx4a77Xtbjr6EgLAbJK6XAzWlpc8F0hb97esyN8/dcZmZBfU7c5ZBo aHLj5CHWeweO3nlEnl9AqMRvGr6xnkBLeWQbWT6yf6/tV56E0Se4WuFsFx1M2oTDKB+Y XWA9sCOTr3IBe1a0djMEFcGrLNkd0WLlXdKPhPaADcbVFYHdumwn3YPH887lUzGjxgBb 7xmdgu8Eb6Yfkm0ZlS+AdtKeS+XyPNoYKg9EEfxuYNZcxOBG45flmbZsnqRus1NiA0b2 PgiNKs7jqPn+yJnPz5DwTjN0n1rgJ7qOjXBMJYJE4ErW/8JtLiXmuTSS17VoZLXIPmUc hmPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5WNDL2lokmvGs6pNFIyUYmSZANDD27WTJq6Cldgl7IE=; b=dCb1qXinjCeNWliMjWLeX1bG2Q57gAA6wv9otg2cP4etvFXU71xefj+9htHBFlk8CF VkMTj4ZyEdkq1Fjf1M/nyjPTFJKToRWOyI3iPReeIzp+Kb2oLDxj11GBLxD1GeYGWPCF TSezXcpO2ZOLMSZ4meWoNzp9mdnc3eVObSy0p+tl19MpjDpXxaWqJL3o4ksYxF6OhTVk rDaWjqoI7fNejkCFEfhKZzTu2OySpMXN3ucCL+x29titRJiiof/TNmQSp0rDiZwY1B8S mRalUxgqC2ZiHQE/RS/LFqpZmQXHYYJ40i7XHNj1UHHaKs6KWH6PZO/hp++kYNXvpNRf vjNg== X-Gm-Message-State: APjAAAVNc+w4bYY1YO1UiQN2pMMuZQmXdz+cgkD+8rohJPRUDTHB5WBX 9FZs+5SBJhgdF+bimiGeg4KgGw== X-Google-Smtp-Source: APXvYqz1SowmPxeQv+JommMs8WTKgC1QWOkW+qCI8bRh8q24/yrZnGUwME/mJ0xPzkdKh8oenTK6mg== X-Received: by 2002:a7b:ce11:: with SMTP id m17mr3958194wmc.123.1573571458334; Tue, 12 Nov 2019 07:10:58 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [RFC PATCH] tests/vm: make --interactive (and therefor DEBUG=1) unconditional Date: Tue, 12 Nov 2019 15:10:51 +0000 Message-Id: <20191112151051.2205-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::334 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) While the concepts of only dropping to ssh if a test fails is nice it is more useful for this to be unconditional. You usually just want to get the build up and running and then noodle around debugging or attempting to replicate. Cc: Peter Maydell Signed-off-by: Alex Benn=C3=A9e --- tests/vm/basevm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 91a9226026d..0b8c1b26576 100755 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -403,7 +403,7 @@ def main(vmcls): exitcode =3D 0 if vm.ssh(*cmd) !=3D 0: exitcode =3D 3 - if exitcode !=3D 0 and args.interactive: + if args.interactive: vm.ssh() =20 if not args.snapshot: --=20 2.20.1