From nobody Thu May 16 19:21:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573541294; cv=none; d=zoho.com; s=zohoarc; b=QSRGgXwVPXDGmgY7ouBvL/qVe5Zeio9+sfZ3+f8sbltAetKQRYrmQbYh0wEl9j/FP/9Vs28K+GPsU3PIrHBT1m6DpUJFlivLz6NhaZ/zQ1FHTdbC9DBRaYlemd7QN38cjG6RDxLAXwQywKAnku4RirBMb6/lcC38B4+BMOt3OWY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573541294; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rIq20hq5LLLQ1PoTEInTGiLiS27XjiBB63xA8xhCUmc=; b=Rmxz6qgvW7NNa3su5bx2ckRn4dZ+PFJ4sqsrdrNG7GN45dj3y/1CajNqaIN2QR0GOvJ3RJZvU2sPdBo4oGl/TxbfrLJB9vy/4YKTz+3R9dvhN+pDFsWlITd+nlcm+Gc29evJlN3HDZ7iFvp6RGpSXS7kKYY2w2nEuhSzP7GD/dU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1573541294601767.2920598973689; Mon, 11 Nov 2019 22:48:14 -0800 (PST) Received: from localhost ([::1]:59508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUPyH-0000fG-6D for importer@patchew.org; Tue, 12 Nov 2019 01:48:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58109) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUPtx-0005U2-R8 for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUPtw-0000Rv-3D for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:45 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:53881 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUPtv-0000RT-W1 for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:44 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-usK_cD3JM5yUkwFdAmWkNg-1; Tue, 12 Nov 2019 01:43:42 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 369021852E22; Tue, 12 Nov 2019 06:43:41 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-124.ams2.redhat.com [10.36.116.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id 27C195DDA8; Tue, 12 Nov 2019 06:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573541023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rIq20hq5LLLQ1PoTEInTGiLiS27XjiBB63xA8xhCUmc=; b=YqcALcNHbnw012ipCr8FKdbSbmdCSju66FMrC6DQ1eXJPtM4vfH8dNNM9c9cDtvknKt5wv MYZjEuaZfm8+Y2v11wODiP/hQgv1l1XgRC+iaibSgwiVaNgqm9byRZRrwcqQImejWutIm9 w/b9dZw6nXMUl7notyJZWOgngy5KYbA= From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 1/6] qtest: fix qtest_qmp_device_add leak Date: Tue, 12 Nov 2019 07:43:27 +0100 Message-Id: <20191112064332.5074-2-thuth@redhat.com> In-Reply-To: <20191112064332.5074-1-thuth@redhat.com> References: <20191112064332.5074-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: usK_cD3JM5yUkwFdAmWkNg-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Marc-Andr=C3=A9 Lureau Spotted by ASAN. Signed-off-by: Marc-Andr=C3=A9 Lureau Message-Id: <20191107192731.17330-3-marcandre.lureau@redhat.com> Reviewed-by: Thomas Huth Fixes: b4510bb4109f5f ("tests: add qtest_qmp_device_add_qdict() helper") Signed-off-by: Thomas Huth --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 3706bccd8d..91e9cb220c 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -1274,6 +1274,7 @@ void qtest_qmp_device_add(QTestState *qts, const char= *driver, const char *id, qdict_put_str(args, "id", id); =20 qtest_qmp_device_add_qdict(qts, driver, args); + qobject_unref(args); } =20 static void device_deleted_cb(void *opaque, const char *name, QDict *data) --=20 2.23.0 From nobody Thu May 16 19:21:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573541387; cv=none; d=zoho.com; s=zohoarc; b=nBynITOe+DSPNocl7UrWunvJlRvxGuLUE42NqMlrg0F1yDGIKRBMCmleLMgLchM3yFEjDo7SzP0R6W3iZYc2a8DeTnK5UaiEMPCFd7RMIdMaF6rIQTBy/pnko0buOga55zRuCKfwHtthAZk0H2G3VxUsqkVPAS3e01Df/DILarQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573541387; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nrILqC3AU3m5t+SirPvHklNkfBjrHQ8H9rbBOdAsI5E=; b=mfx/yBYOBz6tyqeCjr/9ibvzBQlf5z4qCgvflspOLSmFVcKxS2l3Mr5R1AFhfO1vA/LJ/L1vpmRRUXuGMJ6SwY27mzM6H6j7NyEQl86jxwWGY4YBQlwll0Xi/cZlQHefBOTayC7q8pFsxOh9PaOLYuYhR3FukYHKzQ++Lm0JWf4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1573541387604407.89209596338003; Mon, 11 Nov 2019 22:49:47 -0800 (PST) Received: from localhost ([::1]:59512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUPzm-0001p3-3p for importer@patchew.org; Tue, 12 Nov 2019 01:49:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58127) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUPty-0005VB-8v for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUPtx-0000US-AC for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:46 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:36273 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUPtx-0000Ss-6W for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:45 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-300-YYkXLsASOD6G6vK8J8B_OA-1; Tue, 12 Nov 2019 01:43:43 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90DA18017E0; Tue, 12 Nov 2019 06:43:42 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-124.ams2.redhat.com [10.36.116.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id 854375DF2A; Tue, 12 Nov 2019 06:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573541024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nrILqC3AU3m5t+SirPvHklNkfBjrHQ8H9rbBOdAsI5E=; b=Nuzg6hxvuPJarOq7+p6xpBfOrjQeMeasfyRaahRzwOa20u2TS0f2Xp+jAdp0I66E9ihEF1 CpDs+NLzuw8FWZWV2iUFDqN/GkuVDt6yLwu85ecOoKWXNlWlBEuRhMwb1LSZeZ9PLy8DmN CVlixwTdfI2ZH3MDhdeKoICBSGXaNLw= From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 2/6] cpu-plug-test: fix leaks Date: Tue, 12 Nov 2019 07:43:28 +0100 Message-Id: <20191112064332.5074-3-thuth@redhat.com> In-Reply-To: <20191112064332.5074-1-thuth@redhat.com> References: <20191112064332.5074-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: YYkXLsASOD6G6vK8J8B_OA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Marc-Andr=C3=A9 Lureau Spotted by ASAN. Signed-off-by: Marc-Andr=C3=A9 Lureau Message-Id: <20191107192731.17330-4-marcandre.lureau@redhat.com> Reviewed-by: Thomas Huth Fixes: 021a007efc3 ("cpu-plug-test: fix device_add for pc/q35 machines") Signed-off-by: Thomas Huth --- tests/cpu-plug-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cpu-plug-test.c b/tests/cpu-plug-test.c index 058cef5ac1..30e514bbfb 100644 --- a/tests/cpu-plug-test.c +++ b/tests/cpu-plug-test.c @@ -99,6 +99,7 @@ static void test_plug_with_device_add(gconstpointer data) =20 cpu =3D qobject_to(QDict, e); if (qdict_haskey(cpu, "qom-path")) { + qobject_unref(e); continue; } =20 @@ -107,6 +108,7 @@ static void test_plug_with_device_add(gconstpointer dat= a) =20 qtest_qmp_device_add_qdict(qts, td->device_model, props); hotplugged++; + qobject_unref(e); } =20 /* make sure that there were hotplugged CPUs */ --=20 2.23.0 From nobody Thu May 16 19:21:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573541525; cv=none; d=zoho.com; s=zohoarc; b=muDuJxVbrLaO5oVYdfdFmB2AdFeBdmB8xWkQDbO3CBcVvVxfSG3t0vCk8JyqtjhQTz3U94irtgvRqKRpKoNxJn+5B1B3vSoDJh/YQ4dsu3IzAd8Z34HhnE4tqB2rPVNL4UtreJJ6/U/CnCEZplbMdi1a/zRwtjwUhsqXQI/4zMk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573541525; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mPporNFL0AHIftOFO7b/4qzwt0OV6ge/YucoGK+qrCc=; b=KzJGCtmVxRmsguDjVe8BTbgOrvqWXoO/iwUatNajANI5cSTkKRisTzMbqyOBv3IUEdyBIBlD6dZS/Fg1fKIidKfwaibd3hD2gh1n5L37751l5EuRj6yqAQPAEqFzWGkpUS/UEwZCfHVqcz1tK3vDzNQ0qzjx2cHbIwnG1TjXBoE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1573541525094679.623872297814; Mon, 11 Nov 2019 22:52:05 -0800 (PST) Received: from localhost ([::1]:59534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUQ1y-00057n-JE for importer@patchew.org; Tue, 12 Nov 2019 01:52:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58152) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUPu0-0005Xo-Cz for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUPtz-0000WV-28 for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:48 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:40440 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUPty-0000Vp-Uq for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:46 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-61-rnmoRC4BOXqaA37EvYeELg-1; Tue, 12 Nov 2019 01:43:44 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EAA3F800C61; Tue, 12 Nov 2019 06:43:43 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-124.ams2.redhat.com [10.36.116.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE76B5DDA8; Tue, 12 Nov 2019 06:43:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573541026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mPporNFL0AHIftOFO7b/4qzwt0OV6ge/YucoGK+qrCc=; b=c+NQEjmCxmwjC1Jkh3/n3MaPAJqHTgxlVAlDT0KLqUmV7n9BpJIQUCTiBTQWp+q+7awwJB JbsLUV6Q5PXWtE3yIJl6uXm4VKe2uXXjdIZ+mwi1atbOBy4bSG9aqDw2ydHWDMOTeVSXCv s5lWRY/4YBVUkc6NotyoCPl7nplBdMQ= From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 3/6] MAINTAINERS: slirp: Remove myself as maintainer Date: Tue, 12 Nov 2019 07:43:29 +0100 Message-Id: <20191112064332.5074-4-thuth@redhat.com> In-Reply-To: <20191112064332.5074-1-thuth@redhat.com> References: <20191112064332.5074-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: rnmoRC4BOXqaA37EvYeELg-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Jan Kiszka I haven't been doing anything here for a long time, nor does my git repo still play a role. Signed-off-by: Jan Kiszka Message-Id: <759f8f44-9a01-a9f1-c7cf-65d40151a93a@web.de> Reviewed-by: Marc-Andr=C3=A9 Lureau Acked-by: Samuel Thibault Signed-off-by: Thomas Huth --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 363e72a467..ff8d0d29f4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2143,13 +2143,11 @@ F: include/hw/registerfields.h =20 SLIRP M: Samuel Thibault -M: Jan Kiszka S: Maintained F: slirp/ F: net/slirp.c F: include/net/slirp.h T: git https://people.debian.org/~sthibault/qemu.git slirp -T: git git://git.kiszka.org/qemu.git queues/slirp =20 Stubs M: Paolo Bonzini --=20 2.23.0 From nobody Thu May 16 19:21:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573541484; cv=none; d=zoho.com; s=zohoarc; b=RWUsd+ouo4q+w6iRGeosWobFC6iTHoknHsE/uXw8hYBRJJVJvt+iPmLjfPonfFcmtzAWI0wCtw21M95qZkRR+AvnH6w00N51dQlm4buyI8/Qf+xubqAztzudKG3SjsRBN5B7S+TT09M3lwm/1dD0XCF1fPndYpb1oRYBiud5jQc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573541484; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6iCWevDexXrkaS1kfDd68H5ZWVkTwAlq1mUQVDZIR9A=; b=IhsocZ+e+299/tAA1Mjaj17A0Y3rl8v91cTW3VwRPPek3amV3qJ+ez2QH567NXpO1je8AMbfpLndVnxD9pBQH/VEoZrRJrZk8f4sFKitJTsO6mPTPp2/jVSap2KLIfWsT8jyi0vqtz8ydYKlnccO1xbxX7U47wEibYMh7Oa9PR0= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1573541484288929.5315755667121; Mon, 11 Nov 2019 22:51:24 -0800 (PST) Received: from localhost ([::1]:59530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUQ1K-00041A-Uf for importer@patchew.org; Tue, 12 Nov 2019 01:51:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58164) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUPu1-0005Zl-Nk for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUPu0-0000ZR-N7 for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:49 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:28791 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUPu0-0000YJ-JM for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:48 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-170-6atOdEtbNr-4cCyX4uocuQ-1; Tue, 12 Nov 2019 01:43:46 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5283A100550E; Tue, 12 Nov 2019 06:43:45 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-124.ams2.redhat.com [10.36.116.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id 461011B42C; Tue, 12 Nov 2019 06:43:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573541027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6iCWevDexXrkaS1kfDd68H5ZWVkTwAlq1mUQVDZIR9A=; b=J1bgSOIxUUbBMnTVIQcb+zYfZ3zuUg18tNxmVVesOuZiwQus49bHS7KlWBlH1v2kWxpR0Q xXX+WP0xWm1bE2v3grZHEyX/rTpvt/rIEhuT+C+7MfeufFpYCbAwZDWjBwHk7Ykb2Bet0f G/2AoHCA6fBLfjZDJhjZllVpKw7TWfc= From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 4/6] tests/migration: Print some debug on bad status Date: Tue, 12 Nov 2019 07:43:30 +0100 Message-Id: <20191112064332.5074-5-thuth@redhat.com> In-Reply-To: <20191112064332.5074-1-thuth@redhat.com> References: <20191112064332.5074-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 6atOdEtbNr-4cCyX4uocuQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" We're seeing occasional asserts in 'wait_for_migraiton_fail', that I can't reliably reproduce, and where the cores don't have any useful state. Print the 'status' out, so we can see which unexpected state we're ending up in. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20191108104307.125020-1-dgilbert@redhat.com> Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth --- tests/migration-test.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 59f291c654..ac780dffda 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@ -899,8 +899,13 @@ static void wait_for_migration_fail(QTestState *from, = bool allow_active) =20 do { status =3D migrate_query_status(from); - g_assert(!strcmp(status, "setup") || !strcmp(status, "failed") || - (allow_active && !strcmp(status, "active"))); + bool result =3D !strcmp(status, "setup") || !strcmp(status, "faile= d") || + (allow_active && !strcmp(status, "active")); + if (!result) { + fprintf(stderr, "%s: unexpected status status=3D%s allow_activ= e=3D%d\n", + __func__, status, allow_active); + } + g_assert(result); failed =3D !strcmp(status, "failed"); g_free(status); } while (!failed); --=20 2.23.0 From nobody Thu May 16 19:21:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573541602; cv=none; d=zoho.com; s=zohoarc; b=HlGKCUDju4aFJjdwBbAP1/ZqEfvE5ytqeqbD40rJVlDHFcWaqBkJxRNV3xh7e3sA1/a9gPHUIAVYahoQo2L10z4gWeidcS8iONw6aOnrYve+OtjW+u/XpiVL/RR2T1WvB2L+Ij3GKOtU1hMm7t0V1AzaUP30jA+sWuBEmTzx74w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573541602; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yVBGcNV8cXbEQTRHK5E3eqn9uEby5ZYMQ51+2U37af0=; b=gCRbAEjLGOaB5narKJ557MVYUPZCVwOzXImMEGyfQEmdImlsvRoHec8iPeoFKQhnhgNuBb42Sw6lKq38r9Q+9Jm/ibbHmzgcFXyIoiovZBw0dwlHpLQXvdyDeInSQ/3YhRZwI5LZ3egvkgfEVTgI2rMKOlOgZ1ObaL+d4xF+1F0= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1573541602440592.6714624332581; Mon, 11 Nov 2019 22:53:22 -0800 (PST) Received: from localhost ([::1]:59556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUQ3F-0006zX-7n for importer@patchew.org; Tue, 12 Nov 2019 01:53:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58196) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUPu4-0005dj-L0 for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUPu3-0000cd-IG for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:52 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:50125 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUPu3-0000cN-Cp for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:51 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-175-uGhUem4oMCKXGl35l6psMg-1; Tue, 12 Nov 2019 01:43:47 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB3D81800D7A; Tue, 12 Nov 2019 06:43:46 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-124.ams2.redhat.com [10.36.116.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id A03325DDA8; Tue, 12 Nov 2019 06:43:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573541031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yVBGcNV8cXbEQTRHK5E3eqn9uEby5ZYMQ51+2U37af0=; b=EGNvAKYnvqhowHIHapPLVHmSKnI8y0giKxxO0itVd8MZ/idvotETraEZL8lGfZkytonhFp hzNkvBbmLEQlIDG4l4gh/U/d/yx+E7BSmzhJPM8Jv3071XipRWR1mlZanM0ORtxIWL0pQM lcHHAQ1T0yhFGBYRxGS4iKsP2FhkpCQ= From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 5/6] configure: Only decompress EDK2 blobs for X86/ARM targets Date: Tue, 12 Nov 2019 07:43:31 +0100 Message-Id: <20191112064332.5074-6-thuth@redhat.com> In-Reply-To: <20191112064332.5074-1-thuth@redhat.com> References: <20191112064332.5074-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: uGhUem4oMCKXGl35l6psMg-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 The EDK2 firmware blobs only target the X86/ARM architectures. Define the DECOMPRESS_EDK2_BLOBS variable and only decompress the blobs when the variable exists. See also: 536d2173b2b ("roms: build edk2 firmware binaries ...") Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20191108114531.21518-2-philmd@redhat.com> Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Luc Michel Reviewed-by: Laszlo Ersek Signed-off-by: Thomas Huth --- Makefile | 2 ++ configure | 13 +++++++++++++ 2 files changed, 15 insertions(+) diff --git a/Makefile b/Makefile index aa9d1a42aa..3430eca532 100644 --- a/Makefile +++ b/Makefile @@ -480,7 +480,9 @@ $(SOFTMMU_ALL_RULES): $(chardev-obj-y) $(SOFTMMU_ALL_RULES): $(crypto-obj-y) $(SOFTMMU_ALL_RULES): $(io-obj-y) $(SOFTMMU_ALL_RULES): config-all-devices.mak +ifdef DECOMPRESS_EDK2_BLOBS $(SOFTMMU_ALL_RULES): $(edk2-decompressed) +endif =20 .PHONY: $(TARGET_DIRS_RULES) # The $(TARGET_DIRS_RULES) are of the form SUBDIR/GOAL, so that diff --git a/configure b/configure index efe165edf9..9b322284c3 100755 --- a/configure +++ b/configure @@ -427,6 +427,7 @@ softmmu=3D"yes" linux_user=3D"no" bsd_user=3D"no" blobs=3D"yes" +edk2_blobs=3D"no" pkgversion=3D"" pie=3D"" qom_cast_debug=3D"yes" @@ -2146,6 +2147,14 @@ case " $target_list " in ;; esac =20 +for target in $target_list; do + case "$target" in + arm-softmmu | aarch64-softmmu | i386-softmmu | x86_64-softmmu) + edk2_blobs=3D"yes" + ;; + esac +done + feature_not_found() { feature=3D$1 remedy=3D$2 @@ -7526,6 +7535,10 @@ if test "$libudev" !=3D "no"; then echo "LIBUDEV_LIBS=3D$libudev_libs" >> $config_host_mak fi =20 +if test "$edk2_blobs" =3D "yes" ; then + echo "DECOMPRESS_EDK2_BLOBS=3Dy" >> $config_host_mak +fi + # use included Linux headers if test "$linux" =3D "yes" ; then mkdir -p linux-headers --=20 2.23.0 From nobody Thu May 16 19:21:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573541382; cv=none; d=zoho.com; s=zohoarc; b=i5pFQU8S2aq4VRKUWL7BQLHJjBiPj6ckZ6wx4Gy0P7fIa/QCdze+D2jIpKIvEsWTaAMmE9g0VUkBI5DHxFLKXWLUfqcP1XuqTaOHlDiUYULEfpFWTOUkKp4B1y8/ofpn5eHV/zXjYwDuloV+GpxZLXQ5UaC2MZSCUNpEI/zfBPc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573541382; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=aCLLqG38888t2sVO5GwFFujL32t2nwGBtSf6KfG0fDg=; b=BwXvQMCgNZiKgc4u9NVL4i+vwMRAgloS7TjvcmUr1FS0t3c9uFguB8OrCY0PKkYT17+JY02+SQkHzwRCPCt6da8PkAXmVbcbYavTvG/JLpstlSo6CLNpPxeEt87E+w+yLOJBwiFzJ4w2jrpqxqLJuOzYC+2RZnl/S8kC06bjWXg= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1573541382082504.03146283683157; Mon, 11 Nov 2019 22:49:42 -0800 (PST) Received: from localhost ([::1]:59510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUPzc-0001YS-9d for importer@patchew.org; Tue, 12 Nov 2019 01:49:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58182) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUPu3-0005cI-RT for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUPu2-0000c2-Ot for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:51 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:55668 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUPu2-0000bd-LP for qemu-devel@nongnu.org; Tue, 12 Nov 2019 01:43:50 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-83-p6rp4FgGP6qciuABM-TjBA-1; Tue, 12 Nov 2019 01:43:48 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 10DC18017E0; Tue, 12 Nov 2019 06:43:48 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-116-124.ams2.redhat.com [10.36.116.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id 04C3E5DF2A; Tue, 12 Nov 2019 06:43:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573541030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aCLLqG38888t2sVO5GwFFujL32t2nwGBtSf6KfG0fDg=; b=MKLZ1nP+DlFL7h6a6BXZ6ddxVSqSHJiHUv27vA+s4AwaNgC+jipn+FzDdAjWK+PSTP1ElQ pBpVNJWIJT/tqNEQnJNXf09hGrRYrAeebNDEa9LTc1mxFeby0zpPcTgmrHkYW5vSW67Wnx jbmZi86JI6XFbBL5UbdLEWk0ShWjHa8= From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 6/6] configure: Check bzip2 is available Date: Tue, 12 Nov 2019 07:43:32 +0100 Message-Id: <20191112064332.5074-7-thuth@redhat.com> In-Reply-To: <20191112064332.5074-1-thuth@redhat.com> References: <20191112064332.5074-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: p6rp4FgGP6qciuABM-TjBA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh: bzip2: command not found make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127 make: *** Deleting file 'pc-bios/edk2-i386-secure-code.fd' make: *** Waiting for unfinished jobs.... Add a check in ./configure to warn the user if bzip2 is missing. See also: 536d2173b2b ("roms: build edk2 firmware binaries ...") Reported-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20191108114531.21518-3-philmd@redhat.com> Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Laszlo Ersek Reviewed-by: Luc Michel Signed-off-by: Thomas Huth --- configure | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 9b322284c3..6099be1d84 100755 --- a/configure +++ b/configure @@ -2154,6 +2154,10 @@ for target in $target_list; do ;; esac done +# The EDK2 binaries are compressed with bzip2 +if test "$edk2_blobs" =3D "yes" && ! has bzip2; then + error_exit "The bzip2 program is required for building QEMU" +fi =20 feature_not_found() { feature=3D$1 --=20 2.23.0