From nobody Mon Feb 9 21:37:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573488521; cv=none; d=zoho.com; s=zohoarc; b=PLm5TH0ieL27vJgrjv2mYo5qPYNUj8ytV09/vtkRnXd3E5+fU8zV6fj0N3RAjeXbImItbBbwQDRHE0TdrW0ZRcFmFrUY+KgUVCdIa4uroA75S6y1jkV106zNGoKTSM3+4zLlc5xR/+LuxyouB3jU06XKmVPbS50jlVUuldZe9H0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573488521; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6JuuBg3yIfbXvKOIwpye2mO65C0TEQ6XQ2POeXscqTY=; b=mOVK8Cp03Ll8eMCCTW13hd6/BtcclAcVhVbbKqn+B4jYA18iOrz7rJde8W397lE5CGTHhZmrgWE8TdfLt/TMRJRrHki39sRUQs2ADxsClTbHaHlMopfkDkns+ALhQ9fgfN9XbRzQGifkSWKHwn/+cj8jc4vTJgakFSIoSWxn+Ec= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1573488521390809.5746625155182; Mon, 11 Nov 2019 08:08:41 -0800 (PST) Received: from localhost ([::1]:54586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUCF5-0006Id-J7 for importer@patchew.org; Mon, 11 Nov 2019 11:08:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38942) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUC9G-0007k8-Uw for qemu-devel@nongnu.org; Mon, 11 Nov 2019 11:02:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUC9F-0002ic-L7 for qemu-devel@nongnu.org; Mon, 11 Nov 2019 11:02:38 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:32132 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUC9F-0002iR-GO for qemu-devel@nongnu.org; Mon, 11 Nov 2019 11:02:37 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-340-bqG8W5D-M4SgmCJoz4t_SQ-1; Mon, 11 Nov 2019 11:02:32 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A57F7805D84; Mon, 11 Nov 2019 16:02:31 +0000 (UTC) Received: from localhost (ovpn-117-116.ams2.redhat.com [10.36.117.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20EA54521; Mon, 11 Nov 2019 16:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573488157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6JuuBg3yIfbXvKOIwpye2mO65C0TEQ6XQ2POeXscqTY=; b=ccoNezzCLV4SaJgy7VAafNMj6qb+snARgNZoXAKeFdp6/8hcjwwSNAN6Snu3T0bGPWVCa9 2zXR4OCRxaCNL0rKdLyVt2Yk6rtpuEy0GpoaO5+5dXYI60AKJY1XnqTvA+2Dqn5IsiVJrh +/foaroSoW4XSnIOyo48A8dAp87xSdI= From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH for-5.0 v2 04/23] iotests: Let 041 use -blockdev for quorum children Date: Mon, 11 Nov 2019 17:01:57 +0100 Message-Id: <20191111160216.197086-5-mreitz@redhat.com> In-Reply-To: <20191111160216.197086-1-mreitz@redhat.com> References: <20191111160216.197086-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: bqG8W5D-M4SgmCJoz4t_SQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Alberto Garcia , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Using -drive with default options means that a virtio-blk drive will be created that has write access to the to-be quorum children. Quorum should have exclusive write access to them, so we should use -blockdev instead. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/041 | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index d7be30b62b..3c60c07b01 100755 --- a/tests/qemu-iotests/041 +++ b/tests/qemu-iotests/041 @@ -884,7 +884,10 @@ class TestRepairQuorum(iotests.QMPTestCase): # Assign a node name to each quorum image in order to manipula= te # them opts =3D "node-name=3Dimg%i" % self.IMAGES.index(i) - self.vm =3D self.vm.add_drive(i, opts) + opts +=3D ',driver=3D%s' % iotests.imgfmt + opts +=3D ',file.driver=3Dfile' + opts +=3D ',file.filename=3D%s' % i + self.vm =3D self.vm.add_blockdev(opts) =20 self.vm.launch() =20 --=20 2.23.0