From nobody Tue Apr 23 16:09:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573154995; cv=none; d=zoho.com; s=zohoarc; b=oVyExJu1rmMeOuvV8OOXFpGRngF2QwwIgec/KSjIIbUKzI3tHHNfSd8Mlx5AO+tTVetc5UYpLbrNXTGjO5RXHt68rGI4mX2EEmuOX6RSeAQyfUG4pBE+21nErfGMy7bnfD1RoagQY9mmrCKNHNLoZKYPVoPS7yqqmMcwDp/9c6I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573154995; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ShqYAUE5QiCFY7MJ/v0mrQWsfecWkN91u+xbjdRw0b0=; b=ONiwZldSsEQacoIS3hVa4xL2SRGNQ9fWyVFfl8+ozy64HXaFsCX1FJpWHNIInA1dGjCb/8oq2iBYV4tbMzDyPtznl5Enmr66pktchMJ3rH5hFWJ22k5JDjCwvNI2/FAartNyRB26H2dpxoFkAKNy2WyNpBKVNUyysKv+bHWORFg= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157315499593586.04819554145138; Thu, 7 Nov 2019 11:29:55 -0800 (PST) Received: from localhost ([::1]:47600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSnTe-0002SG-QC for importer@patchew.org; Thu, 07 Nov 2019 14:29:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49870) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSnRs-0001NP-9I for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSnRq-0008WJ-4n for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:04 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:59885 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSnRq-0008Vn-14 for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:02 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-127-ejkqC6-bNdmd4b0R4MEnDg-1; Thu, 07 Nov 2019 14:28:00 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3976B800C61 for ; Thu, 7 Nov 2019 19:27:59 +0000 (UTC) Received: from localhost (ovpn-112-60.ams2.redhat.com [10.36.112.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 159515C57C; Thu, 7 Nov 2019 19:27:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573154881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ShqYAUE5QiCFY7MJ/v0mrQWsfecWkN91u+xbjdRw0b0=; b=Oo4RjFXPLt2arCHdQuXyyP1iK2lJIh49aVgqWxjfoUA9BUUL24uM/CilEiXDF+HEZPltg3 bJb6t9i6EsHsiDRkmK27g7EFWRACllOabcbh+TIzYigFI0iWFa3S48YVUhnfSW/KKaQPsP olgqkBw2ongFxDyEfVvEyo3T79MFxuU= From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Subject: [PATCH 1/3] virtio-input: fix memory leak on unrealize Date: Thu, 7 Nov 2019 23:27:29 +0400 Message-Id: <20191107192731.17330-2-marcandre.lureau@redhat.com> In-Reply-To: <20191107192731.17330-1-marcandre.lureau@redhat.com> References: <20191107192731.17330-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: ejkqC6-bNdmd4b0R4MEnDg-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , "Michael S. Tsirkin" , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Spotted by ASAN + minor stylistic change. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Michael S. Tsirkin --- hw/input/virtio-input.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/input/virtio-input.c b/hw/input/virtio-input.c index 51617a5885..ec54e46ad6 100644 --- a/hw/input/virtio-input.c +++ b/hw/input/virtio-input.c @@ -275,6 +275,7 @@ static void virtio_input_finalize(Object *obj) =20 g_free(vinput->queue); } + static void virtio_input_device_unrealize(DeviceState *dev, Error **errp) { VirtIOInputClass *vic =3D VIRTIO_INPUT_GET_CLASS(dev); @@ -288,6 +289,8 @@ static void virtio_input_device_unrealize(DeviceState *= dev, Error **errp) return; } } + virtio_del_queue(vdev, 0); + virtio_del_queue(vdev, 1); virtio_cleanup(vdev); } =20 --=20 2.24.0.rc0.20.gd81542e6f3 From nobody Tue Apr 23 16:09:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573155301; cv=none; d=zoho.com; s=zohoarc; b=ccOe/9lons2Zhvp9PxwEqgNAmqszmE2UgRDKsETQsbTKPqCJ5OXVstMKTORfvufS7WMmnot//nJiThL3DD+fGnZviowUPx/0EKbW73L3xQhzzHLFWHwOl49OLWuyk119aasttSmjQS4vm7ByWar1jTuAGWuoZ7VKY5vekPmImAs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573155301; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=beU4vFS75DQxJnwJWlGlrCxUCCfEj1fKrvK5Zq90pnU=; b=JEqGq9ICOUIm6K0TlQ/hQNNlrf17wDpfWW+2yeMka3EbB4ZrDo/2qTfSbRyKnemH0BqzUbS9MXnn2bAyOQ8HKKyIxZFLF4xiGfnJF6GF0QhVV0ljk1Vw5LhJgrwnMvH3EjSIMg9gReYgPSUnUerupvd3Iw6BwLnyLHJivOZPUuw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1573155301787888.0707911895879; Thu, 7 Nov 2019 11:35:01 -0800 (PST) Received: from localhost ([::1]:47646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSnYZ-000635-NU for importer@patchew.org; Thu, 07 Nov 2019 14:34:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49973) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSnS9-0001TM-K5 for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSnS8-0000DR-N2 for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:21 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:56868 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSnS8-0000D3-Ja for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:20 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49-qWX8aI3bO-OIsLAgEVei-g-1; Thu, 07 Nov 2019 14:28:17 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 80820107ACC3 for ; Thu, 7 Nov 2019 19:28:16 +0000 (UTC) Received: from localhost (ovpn-112-60.ams2.redhat.com [10.36.112.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 07CAD608B4; Thu, 7 Nov 2019 19:28:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573154899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=beU4vFS75DQxJnwJWlGlrCxUCCfEj1fKrvK5Zq90pnU=; b=fte1GIoFtvs1Lk4hFMgn7AfdvnjjGob/0E1r6H+OFhBKVUC3jLzNZ11qv9aNl2JklKiV+7 EQYuUokr5Rf7jR9+c145cr+kyo35eDCrwnR//TiIuAMKpvIAuvf7Fn3i6OaMm1fiipp+Zs E/aaD6xYmL+9Vpe8KpFyQz8a0mkdHpY= From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Subject: [PATCH 2/3] qtest: fix qtest_qmp_device_add leak Date: Thu, 7 Nov 2019 23:27:30 +0400 Message-Id: <20191107192731.17330-3-marcandre.lureau@redhat.com> In-Reply-To: <20191107192731.17330-1-marcandre.lureau@redhat.com> References: <20191107192731.17330-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: qWX8aI3bO-OIsLAgEVei-g-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , "Michael S. Tsirkin" , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Spotted by ASAN. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Thomas Huth --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 3706bccd8d..91e9cb220c 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -1274,6 +1274,7 @@ void qtest_qmp_device_add(QTestState *qts, const char= *driver, const char *id, qdict_put_str(args, "id", id); =20 qtest_qmp_device_add_qdict(qts, driver, args); + qobject_unref(args); } =20 static void device_deleted_cb(void *opaque, const char *name, QDict *data) --=20 2.24.0.rc0.20.gd81542e6f3 From nobody Tue Apr 23 16:09:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573155173; cv=none; d=zoho.com; s=zohoarc; b=EwlKb4/H6dEKI6+4My72wAXCsJPL4/o+S+FkE8QloxkGiMG8+PIxNuiyBS2XFhW2uf5cVqqzXlxgUvMPUhUIpaCYI1dcWucdfWKRzMua+sRltnUfKCPbUMwFThFmVeL220f6S8mHfUcF4ftqkC+pg+zVXOsgO7O0tjeirk+yCvE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573155173; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OvrhF9UNepAsMD3c4PvKr5DRGDwu5IQWuq2svRUoahE=; b=Hf7qNdnz5IFbm8vOdXAlUyHPZfn1qAprWYKL/miHlrCSfTToDY3CFkyHwYe4uoKCX9/vPNVa16CD0ck0A1AZth0X+XmEBeAVmjawH6vDNBFu2qo8xBgP5auK8MOcoxD/nO/Z6VTx1fQRmfmFupGBGbbQl7pQnm+Zi9olN19YKXg= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15731551731631023.3939612931077; Thu, 7 Nov 2019 11:32:53 -0800 (PST) Received: from localhost ([::1]:47608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSnWU-0003AN-Ed for importer@patchew.org; Thu, 07 Nov 2019 14:32:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50242) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSnSP-0001l4-7d for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSnSO-0000Yi-8w for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:37 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:25399 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSnSO-0000YH-4w for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:36 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-hEMCibHaO2OBS4nSb9LI2w-1; Thu, 07 Nov 2019 14:28:34 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 589C3477 for ; Thu, 7 Nov 2019 19:28:33 +0000 (UTC) Received: from localhost (ovpn-112-60.ams2.redhat.com [10.36.112.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C35F5D9E5; Thu, 7 Nov 2019 19:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573154915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OvrhF9UNepAsMD3c4PvKr5DRGDwu5IQWuq2svRUoahE=; b=Y+VvgQcjJj/RaUn7XDayHmmhYOrEfrNchGN/py5YkB4oKDp5EY+5BQkImh7sk8KZb1Po/X AB4mjo4rjg0Nc97rWZ0UEQY1Ed3IgBnpUSQNgvB2XgW6FY2bczIFexd6JGeIhlrHiDpG3D x6VEhFaUjYXKzJxkoQN3AjFm9ZHDye8= From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Subject: [PATCH 3/3] cpu-plug-test: fix leaks Date: Thu, 7 Nov 2019 23:27:31 +0400 Message-Id: <20191107192731.17330-4-marcandre.lureau@redhat.com> In-Reply-To: <20191107192731.17330-1-marcandre.lureau@redhat.com> References: <20191107192731.17330-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: hEMCibHaO2OBS4nSb9LI2w-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , "Michael S. Tsirkin" , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Spotted by ASAN. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Thomas Huth --- tests/cpu-plug-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cpu-plug-test.c b/tests/cpu-plug-test.c index 058cef5ac1..30e514bbfb 100644 --- a/tests/cpu-plug-test.c +++ b/tests/cpu-plug-test.c @@ -99,6 +99,7 @@ static void test_plug_with_device_add(gconstpointer data) =20 cpu =3D qobject_to(QDict, e); if (qdict_haskey(cpu, "qom-path")) { + qobject_unref(e); continue; } =20 @@ -107,6 +108,7 @@ static void test_plug_with_device_add(gconstpointer dat= a) =20 qtest_qmp_device_add_qdict(qts, td->device_model, props); hotplugged++; + qobject_unref(e); } =20 /* make sure that there were hotplugged CPUs */ --=20 2.24.0.rc0.20.gd81542e6f3