From nobody Sat Apr 20 16:37:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1573057834; cv=none; d=zoho.com; s=zohoarc; b=Els2G2ljk5E8fyQgmbJZBIqo32m+NzMejTjUdApirdTtPTeG5UUNc6ottNAhNsjmxl46+rWCyNUzvmCXheDbVnuRpz6TtofXWKac6bmqcfmO+BsH9E7YaoQI2RPUSUM/1L+xr2cJ/0xVBXncGC+yC+jePM2MoYe4z3MIEQyJaho= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573057834; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DyLw0ZjFbtB4U5K0OSrn0ARlZQCk6TqjMJ11xU0KmWc=; b=FPzIZS9E0KXkwbJL9926WT5R3VtYdjE4BA2hY+JC4tBSPy7Lgz3G7MJ6nEzmVZ7c7HKfvBkylv4QqkKejgn70oeJPoI4/FHknH0g+iCSYNBP1htlLrqF/AZ9uqchHGopJwo6L3+3eDENbEj2KG/EWeDEJwjOKonjk0EJM5rWGDM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1573057834532366.7920711689625; Wed, 6 Nov 2019 08:30:34 -0800 (PST) Received: from localhost ([::1]:32812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSOCW-0008Sb-7U for importer@patchew.org; Wed, 06 Nov 2019 11:30:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33812) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSO6V-0002gm-Lb for qemu-devel@nongnu.org; Wed, 06 Nov 2019 11:24:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSO6U-0000MO-9T for qemu-devel@nongnu.org; Wed, 06 Nov 2019 11:24:19 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:34941) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSO6U-0000L9-08 for qemu-devel@nongnu.org; Wed, 06 Nov 2019 11:24:18 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MOzCW-1iIPpd1KP6-00PLNF; Wed, 06 Nov 2019 17:24:09 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v3 1/3] hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers Date: Wed, 6 Nov 2019 17:24:04 +0100 Message-Id: <20191106162406.27030-2-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191106162406.27030-1-laurent@vivier.eu> References: <20191106162406.27030-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:xqHxOuOcbR5HhkI7dFHILMKAOXOpewRa3IX2sKcI9+qQ7MRYhjw 7fRePBurg3PpvUzY7B3Rl0xvDcXD4W5P0ZLELkjUi/I4vO2jVsIqfIujbKQyUbqPoJBFWlr vKKfbvdYXfgxAC0B4DDG+naYiWrgWWETOtsY+HSw6eGxfgTQkG78LG+bLjI+zLEbPyrMk/y bI1hk6SQoBpOF8boaxodg== X-UI-Out-Filterresults: notjunk:1;V03:K0:gzDSXSbdnVM=:9eHUV01wpuZOcw4CUEHEd7 HA/XccQvPUYCikGIzzknVZeRaV86xt/PMAhDSX7OPdprYeUTCDAh7xCe08lVPOj5m2kKQhGbA iKJ6WQmB1Qrg0v+FC1+AKWCgp3mR6w64LPw4fs+QIA5L8Xnk9kLX/o+4dCRNqkzgIf+3PjEIb XSCO3RutTUjAKnHpp/FTL3Gk+E+QXxXdS7pMiGdxpUy1l3f55sAsETisAXRskwpNPorlyJtu1 /w7k/GX7/dSuPG6fcDUKkJfDNP8GHRurgMKKkdCiolakzJiiTMwPl0dSqsbMriDgsQkIDPwp9 JeMyN2E9tG+LGsB5leaxxhYKzCrIkJkMIbN0FGbxlJ0E9kD7rGybiM8yUqiub6arwFBNDFUnX kL3prlP4L/mi3abrn92upGS/eIVdttWjya5lG6Dgudi6f3kZsop857b6+qiA+WwJ8mZjegtAs TZ7qGUaOXvt/+s6s4Jg35kvoX5HrF+7Bvjz81XHEvuQWRVDFbScxBP2r4gG6hEQ7FmtMfrnkW potRmDkAqBFl44fgRjGPZF3LUd5LwLslGJxcpXReuD/TmDZ9yBmttgZ2a/SdJJiv6xZLP7tom 5R/lXA+EcomVNnuQ2+T812G1zQxfJh/Vtnd/QUey7kE4u/rftu8WSCrk9pRDGREBy3TMq/v6b fun+cuqK5IPCq6VbHfaQzCP/CfG9yuMiNuPFwSYLw8DvINXeY0q8Vp2JmVWb23C/wHM1Q296n QZBS/DLGMnNbLfb36pTxJwld2Z4Wdy01o6Zp8PWkppXm6xHVnY2WpT29g+0Blao8lFVtWmTcv VJ4nAzWMkGJ5IIK6llqFz/K6kx/DAJQ1HIV7AHlOY0Xe0VCSCdLzRb7Q6KFtAseBvwkIPIpZF nOmNEm+d4gCUvjFpGgAq1zw+83LM75AKS9ruVGb7k= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.131 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: KONRAD Frederic , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Guests can crash QEMU when writting to PnP registers: $ echo 'writeb 0x800ff042 69' | qemu-system-sparc -M leon3_generic -S -bi= os /etc/magic -qtest stdio [I 1571938309.932255] OPENED [R +0.063474] writeb 0x800ff042 69 Segmentation fault (core dumped) (gdb) bt #0 0x0000000000000000 in () #1 0x0000555f4bcdf0bc in memory_region_write_with_attrs_accessor (mr=3D0= x555f4d7be8c0, addr=3D66, value=3D0x7fff07d00f08, size=3D1, shift=3D0, mask= =3D255, attrs=3D...) at memory.c:503 #2 0x0000555f4bcdf185 in access_with_adjusted_size (addr=3D66, value=3D0= x7fff07d00f08, size=3D1, access_size_min=3D1, access_size_max=3D4, access_f= n=3D0x555f4bcdeff4 , mr=3D0x555f4d= 7be8c0, attrs=3D...) at memory.c:539 #3 0x0000555f4bce2243 in memory_region_dispatch_write (mr=3D0x555f4d7be8= c0, addr=3D66, data=3D69, op=3DMO_8, attrs=3D...) at memory.c:1489 #4 0x0000555f4bc80b20 in flatview_write_continue (fv=3D0x555f4d92c400, a= ddr=3D2148528194, attrs=3D..., buf=3D0x7fff07d01120 "E", len=3D1, addr1=3D6= 6, l=3D1, mr=3D0x555f4d7be8c0) at exec.c:3161 #5 0x0000555f4bc80c65 in flatview_write (fv=3D0x555f4d92c400, addr=3D214= 8528194, attrs=3D..., buf=3D0x7fff07d01120 "E", len=3D1) at exec.c:3201 #6 0x0000555f4bc80fb0 in address_space_write (as=3D0x555f4d7aa460, addr= =3D2148528194, attrs=3D..., buf=3D0x7fff07d01120 "E", len=3D1) at exec.c:32= 91 #7 0x0000555f4bc8101d in address_space_rw (as=3D0x555f4d7aa460, addr=3D2= 148528194, attrs=3D..., buf=3D0x7fff07d01120 "E", len=3D1, is_write=3Dtrue)= at exec.c:3301 #8 0x0000555f4bcdb388 in qtest_process_command (chr=3D0x555f4c2ed7e0 , words=3D0x555f4db0c5d0) at qtest.c:432 Instead of crashing, log the access as unimplemented. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: KONRAD Frederic Message-Id: <20191025110114.27091-2-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/misc/grlib_ahb_apb_pnp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/misc/grlib_ahb_apb_pnp.c b/hw/misc/grlib_ahb_apb_pnp.c index 7338461694c9..f3c015d2c35f 100644 --- a/hw/misc/grlib_ahb_apb_pnp.c +++ b/hw/misc/grlib_ahb_apb_pnp.c @@ -22,6 +22,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/sysbus.h" #include "hw/misc/grlib_ahb_apb_pnp.h" =20 @@ -231,8 +232,15 @@ static uint64_t grlib_apb_pnp_read(void *opaque, hwadd= r offset, unsigned size) return apb_pnp->regs[offset >> 2]; } =20 +static void grlib_apb_pnp_write(void *opaque, hwaddr addr, + uint64_t val, unsigned size) +{ + qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__); +} + static const MemoryRegionOps grlib_apb_pnp_ops =3D { .read =3D grlib_apb_pnp_read, + .write =3D grlib_apb_pnp_write, .endianness =3D DEVICE_BIG_ENDIAN, }; =20 --=20 2.21.0 From nobody Sat Apr 20 16:37:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1573057715; cv=none; d=zoho.com; s=zohoarc; b=hIjLs/JLFtSxFmyVm/H/msyCwZ7HOf8ptvXtM74/WnBhZ3magVS3PcMqBba1OOvDlGF/1kXY8vWK+We5Reqg9iG+v0T5BnVEUTN+glC9bNcmuom6IW6T/MvgElyMGehd5Le5axp2tatHDGK3YA7Soh2DFyyFyAhG/R+ztD6zNi0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573057715; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lkBVhE+DGu4iin+pTeTvS1RXP+Ew7BhO+1q4xCrzvpU=; b=CEOgr0WX2H4DKNvvtL8WCDGc8i/AMyPKBxiTa8/Jr9C9KZjLYbA3KgNg+bj9/LE1/rg4YY3BtzVD8suFIYgQQrCI3Tgx7ep8Zz0el8goZHg7el1YAiOgVQRsmtwJNQOYMxkm5x8DIijUBfZyXw66clyuZ4p3apDZR4lD9tyqLSw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1573057715701890.2086180098221; Wed, 6 Nov 2019 08:28:35 -0800 (PST) Received: from localhost ([::1]:32780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSOAc-00066r-DF for importer@patchew.org; Wed, 06 Nov 2019 11:28:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33803) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSO6U-0002eX-LD for qemu-devel@nongnu.org; Wed, 06 Nov 2019 11:24:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSO6T-0000LF-Gh for qemu-devel@nongnu.org; Wed, 06 Nov 2019 11:24:18 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:55159) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSO6T-0000KH-7o for qemu-devel@nongnu.org; Wed, 06 Nov 2019 11:24:17 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Md6dH-1hsm2D0fvH-00aHic; Wed, 06 Nov 2019 17:24:10 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v3 2/3] hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses Date: Wed, 6 Nov 2019 17:24:05 +0100 Message-Id: <20191106162406.27030-3-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191106162406.27030-1-laurent@vivier.eu> References: <20191106162406.27030-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:8H19g5k0tZ5IS5wAvLOztZOlZfVwgHdxyki+sekE5FPdVJ7EBSP De5aqro8pcUaqxGlE29PoAbTCJzFz38j3u8EdAKz+A4l8YFehKD34OXiqKNTTjBBM/v4XKz MES7BHvVfhoTOypHczoCh8JVLqcTKWyY8A+tGwQ4KSgcExcPf/SC71YnWmGj32a6PTKimKd c4t2z31Xo8II/L1Lb0Jwg== X-UI-Out-Filterresults: notjunk:1;V03:K0:4fZm/hmD2b8=:hfm8+RpWPB01q0cpvF6UY4 0MXf0xSpT9nkF4rbPdOhGirpbN8l/60eXU/wg5jJgw+Obw+rNR4TpqdnZEMa1V+9LGmh62Jmy Zrr2+NApVtGATGNm5D/AofbS9ToNM/UL48/Sg10zzRZuV1iIASjKUyrkIZguEats9YlKaWM+n peoEWAEcFjP2WKO9jMhEee8swT6dChOVj38eIaC0XN08nnQMKhUOfJwAJ25DTPs+uo2R3QRsX 0AAPYh8/qMJXxvfAUDu/DFtB8auIbOW98Va4XFDzuC9IbwvHjJ2QXtTEgU4jN4MN0EP7JG0kT pgaKtD50pKSBM+mrASk8gdpdPq8obOlpXhw5sNNZ3j9qrXVoWdeZFuYidbURYdwAjYMSqCfvn j/k1LfGPj3Z0SG5dsvDlgdzZf22UrBWDVgz7ttBseW6Ae67QcOzo/1G88yFsnN7Bex8loll5M KbYhfs80+yozd/2BWiX+XkXqDo4asium3XfQqHUlgtqyR0WEA5uRF1k3mdPruP65+qk9LB4ND xxbcTR5o9VznFVduIaQw68+mLLRY/Wl5E7UQTJ70uexfOGre7yAeoc3//TR5qKMQkiC+PZXRK 35ex6+xg8/04JlcYGF3JTFQsb0hdYGR55wEQY3UcqwvsVb6ivnutUKnrFWWh8tbaZstdu/30f gSbW0rwvP42Q10DVHcZARVr4PnHNx0viaAx5Un0dl/cjHoxVqrpSvElRaO2Jrui14OE3Dsf45 2EIBQ1DiMCcSWE4mgzHMzdXEI3CzMm6LV+CLBEVX6vQSRmW7P01sCsI0Qg7WbTla8ipBhCOfm sv/BSmjbrSqfOW51uaeYAHWyOMj5sG4nHijNOj9k652YK8zNChs67UDwOF2pDjMzehBNxC72G 5VVRo95W5QJpEp8fOnn3Z4yfO84UCd3mGnSy5Tk34= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.187 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: KONRAD Frederic , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Jiri Gaisler Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 The Plug & Play region of the AHB/APB bridge can be accessed by various word size, however the implementation is clearly restricted to 32-bit: static uint64_t grlib_apb_pnp_read(void *opaque, hwaddr offset, unsigned = size) { APBPnp *apb_pnp =3D GRLIB_APB_PNP(opaque); return apb_pnp->regs[offset >> 2]; } Set the MemoryRegionOps::impl min/max fields to 32-bit, so memory.c::access_with_adjusted_size() can adjust when the access is not 32-bit. This is required to run RTEMS on leon3, the grlib scanning functions do byte accesses. Reported-by: Jiri Gaisler Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: KONRAD Frederic Message-Id: <20191025110114.27091-3-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/misc/grlib_ahb_apb_pnp.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/misc/grlib_ahb_apb_pnp.c b/hw/misc/grlib_ahb_apb_pnp.c index f3c015d2c35f..e230e2536361 100644 --- a/hw/misc/grlib_ahb_apb_pnp.c +++ b/hw/misc/grlib_ahb_apb_pnp.c @@ -242,6 +242,10 @@ static const MemoryRegionOps grlib_apb_pnp_ops =3D { .read =3D grlib_apb_pnp_read, .write =3D grlib_apb_pnp_write, .endianness =3D DEVICE_BIG_ENDIAN, + .impl =3D { + .min_access_size =3D 4, + .max_access_size =3D 4, + }, }; =20 static void grlib_apb_pnp_realize(DeviceState *dev, Error **errp) --=20 2.21.0 From nobody Sat Apr 20 16:37:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1573057572; cv=none; d=zoho.com; s=zohoarc; b=mnR6MZgUqu7E6uMY03aLvSSH7vl7m/bRiQdZw8E7x276jIzVhh6M8p+OzC21kxg4zYEUS1BxLzw45Lre/IM+U/WzT4kmUIuboPLDVkT5ApOFmjHupXwpM/tUVzIPp3Z1NdbLGp330jlERNBVB2qSXfQYAKi3Z1kJXXcvmyrX8MA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573057572; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Nq47bNZY567IpOqnJkwcUKtAByE3epyeMXuztl/1Txg=; b=UkZgLTrXFfetQ7BsHpwHYeQTJB4zxdfbH6jaIi+3iUsmpdH8gh4VsNWWVBIVmBsQpD1myizCuE/Jq924FVpLpC2oFNJZyAvICSDpCZVrioCSaMCq1IJb9kkJJin+JlPjoYCvO2E2PMKp/JEa6vzSFx7kH8Nvaw65qsrvC4vJtgI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1573057572987515.3449828869265; Wed, 6 Nov 2019 08:26:12 -0800 (PST) Received: from localhost ([::1]:60974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSO8J-0004ST-Ud for importer@patchew.org; Wed, 06 Nov 2019 11:26:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33785) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSO6T-0002au-2N for qemu-devel@nongnu.org; Wed, 06 Nov 2019 11:24:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSO6R-0000I6-NL for qemu-devel@nongnu.org; Wed, 06 Nov 2019 11:24:16 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:50377) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSO6R-0000HI-Da for qemu-devel@nongnu.org; Wed, 06 Nov 2019 11:24:15 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M8yU2-1iXK3Q30g2-0069Yt; Wed, 06 Nov 2019 17:24:10 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v3 3/3] global: Squash 'the the' Date: Wed, 6 Nov 2019 17:24:06 +0100 Message-Id: <20191106162406.27030-4-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191106162406.27030-1-laurent@vivier.eu> References: <20191106162406.27030-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:XEdVWtA5HY1feE8iQtxEShbY8h+fghhbUFGdd51gkZIq/jb0DeN IOPxCF+fOBcuIPQ899MQBeAoOFf3Qu6HutgatHBeKQ2GuAou9HYESk1ZJ7Ke0jgxZc8JHZk RgPfeXM8886nkQYYPTIRKKy2VpKsFwc3w3AFDmrf6R1JUNoySFZSmBWczuF/CdgX/BYQidC +9Zdj5RFEssn9nE9yA+Ig== X-UI-Out-Filterresults: notjunk:1;V03:K0:V3vcKe5r2Ak=:22Ni7v0Qp5XGnhS1wvXh+6 9pTGI/ffrCEB2nAOFyu8LEbUVWMvUpRjrv+ddBxBgd78EGXCZ/reYM4+iC5uv4DhuoDBvrwUT CDlV3abGIe6UZabJyktM0zcFsOXZAZALdzY+RX4m4ybmlyX5KA467uIN2FM57uVd1nM1DaJKs DkHcEVnXH0oBkP3HjBTsByGt5Fjx1waSw6eFLSsaYZQlH6ZzbWmHNjnhix15x3FyA+/JNk5Z0 C+OuVlzrPH4t7xBQ109yET1STUXpgTORwCzM5/rG7rB4XFR4hxB8VMjj8RkDi5zZ+PwRVi3OU IFf0SkicBlWA17aEtVXUOtxvqHdooai3/5cEI38vivMHHe7a1AToW9qJY1GR8BcpYkYgpD+oq draqBV5yW9QYr3dcK3AAXsezYM48yawpWxigvs2U7hp6LhkxnMDoffytWSR6oanFEXl5jns5y oAKKyQKeDK75vdBZi9tz0LPiqAMsgJXzf8VADIZxqfPs8973USEYopHjtjv11na5zaW147OOl 0As5gyX6sg53Nkn3D7Z7l+XZdwYZjgNOzk+d/EJxf/kNMn0uO1E0orsCuekEhL0Sx72NESSLk 1t+yO7FETuLubGIvrv9Dwf2sNVUs5bVKiOZ5THjhvhxp1BXk6iIcKbxgwtFpitRmy2qq19ja6 UpyxNDiH04hrSpDeGkRX2if8J6cLvGhccW/scd2jN2amo9hRLz/sR4qJxcN8DZ1zRKhu3EinP yXcqjFA3nH0J9fkekCtGY/Ok3JJgK7QeOdZPqcCcsig7SJ8rzSrUbhhjLvbMdeYzUvpbmv+aQ MPWz/abgiPp4nRBkQWIAj3gr4oVD5LdVBUEWH0wsM0q4nHlpecH4PGbZyQCk+E482L8alnUfi soW366m+QqCgL6xboDavHpPMxw9fgxpFS8Syoa0II= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.135 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , "Dr. David Alan Gilbert" , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: "Dr. David Alan Gilbert" 'the' has a tendency to double up; squash them back down. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20191104185202.102504-1-dgilbert@redhat.com> [lv: removed disas/libvixl/vixl/invalset.h change] Signed-off-by: Laurent Vivier --- docs/interop/pr-helper.rst | 2 +- docs/specs/ppc-spapr-hotplug.txt | 2 +- docs/specs/ppc-xive.rst | 2 +- docs/specs/tpm.txt | 2 +- include/hw/xen/interface/io/blkif.h | 2 +- scripts/dump-guest-memory.py | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/interop/pr-helper.rst b/docs/interop/pr-helper.rst index 9f76d5bcf98f..e926f0a6c9cb 100644 --- a/docs/interop/pr-helper.rst +++ b/docs/interop/pr-helper.rst @@ -10,7 +10,7 @@ can delegate implementation of persistent reservations to= an external restricting access to block devices to specific initiators in a shared storage setup. =20 -For a more detailed reference please refer the the SCSI Primary +For a more detailed reference please refer to the SCSI Primary Commands standard, specifically the section on Reservations and the "PERSISTENT RESERVE IN" and "PERSISTENT RESERVE OUT" commands. =20 diff --git a/docs/specs/ppc-spapr-hotplug.txt b/docs/specs/ppc-spapr-hotplu= g.txt index cc7833108e12..859d52cce6c8 100644 --- a/docs/specs/ppc-spapr-hotplug.txt +++ b/docs/specs/ppc-spapr-hotplug.txt @@ -385,7 +385,7 @@ Each LMB list entry consists of the following elements: is used to retrieve the right associativity list to be used for this LMB. - A 32bit flags word. The bit at bit position 0x00000008 defines whether - the LMB is assigned to the the partition as of boot time. + the LMB is assigned to the partition as of boot time. =20 ibm,dynamic-memory-v2 =20 diff --git a/docs/specs/ppc-xive.rst b/docs/specs/ppc-xive.rst index 148d57eb6ab2..83d43f658b90 100644 --- a/docs/specs/ppc-xive.rst +++ b/docs/specs/ppc-xive.rst @@ -163,7 +163,7 @@ Interrupt Priority Register (PIPR) is also updated usin= g the IPB. This register represent the priority of the most favored pending notification. =20 -The PIPR is then compared to the the Current Processor Priority +The PIPR is then compared to the Current Processor Priority Register (CPPR). If it is more favored (numerically less than), the CPU interrupt line is raised and the EO bit of the Notification Source Register (NSR) is updated to notify the presence of an exception for diff --git a/docs/specs/tpm.txt b/docs/specs/tpm.txt index 5d8c26b1adba..9c8cca042da8 100644 --- a/docs/specs/tpm.txt +++ b/docs/specs/tpm.txt @@ -89,7 +89,7 @@ TPM upon reboot. The PPI specification defines the operat= ion requests and the actions the firmware has to take. The system administrator passes the oper= ation request number to the firmware through an ACPI interface which writes this number to a memory location that the firmware knows. Upon reboot, the firm= ware -finds the number and sends commands to the the TPM. The firmware writes th= e TPM +finds the number and sends commands to the TPM. The firmware writes the TPM result code and the operation request number to a memory location that ACP= I can read from and pass the result on to the administrator. =20 diff --git a/include/hw/xen/interface/io/blkif.h b/include/hw/xen/interface= /io/blkif.h index 8b1be50ce81e..d07fa1e07822 100644 --- a/include/hw/xen/interface/io/blkif.h +++ b/include/hw/xen/interface/io/blkif.h @@ -341,7 +341,7 @@ * access (even when it should be read-only). If the frontend hits the * maximum number of allowed persistently mapped grants, it can fallb= ack * to non persistent mode. This will cause a performance degradation, - * since the the backend driver will still try to map those grants + * since the backend driver will still try to map those grants * persistently. Since the persistent grants protocol is compatible w= ith * the previous protocol, a frontend driver can choose to work in * persistent mode even when the backend doesn't support it. diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py index 2c587cbefc57..9371e4581308 100644 --- a/scripts/dump-guest-memory.py +++ b/scripts/dump-guest-memory.py @@ -170,7 +170,7 @@ class ELF(object): self.ehdr.e_phnum +=3D 1 =20 def to_file(self, elf_file): - """Writes all ELF structures to the the passed file. + """Writes all ELF structures to the passed file. =20 Structure: Ehdr --=20 2.21.0