From nobody Tue Feb 10 03:38:34 2026 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1572976325; cv=none; d=zoho.com; s=zohoarc; b=Lyo/Ol6fD4yVH+AWX/nSRmG8lT0/AEicHwtMIhq/+jQDgYqB/DOEduBuVSMpPYoUiL4V6Rd6a02plIXjm5Iie4V06HWwql5PpW2X1KKpf5PyZmPrv1HA7wTSL5P1UO+it9THqw78y4GfassAybHg1gCUne6wkMIfOuSQ7hJ0fYg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572976325; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1BunYw7fwOopyI1YOLj2jhkFifKnbeJ9ibS+r6o+gOk=; b=n28TQNQXg9tMk/YgmKm4qabXJvkxnhDYMuw+wxqfcr2z7vV+VjJW6HM8TEgEwjeGbSLGHNrnCFYostVQnTfzMo6sbbGFrRBlOEoYmULxk+FC5ppj69C14zEWabsvnx7IEMbJvGnvS7BVolXjEmDWMCEJLEPSr5P4OcFu4D1kS2I= ARC-Authentication-Results: i=1; mx.zoho.com; spf=none (zoho.com: 192.237.175.120 is neither permitted nor denied by domain of lists.xenproject.org) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1572976325352384.504445089357; Tue, 5 Nov 2019 09:52:05 -0800 (PST) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iS2yZ-0004Cz-3p; Tue, 05 Nov 2019 17:50:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iS2yX-0004Co-LB for xen-devel@lists.xenproject.org; Tue, 05 Nov 2019 17:50:41 +0000 Received: from mout.kundenserver.de (unknown [217.72.192.74]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c59e0a0c-fff4-11e9-b678-bc764e2007e4; Tue, 05 Nov 2019 17:50:37 +0000 (UTC) Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MS4ab-1iLlQr1IPT-00TQkF; Tue, 05 Nov 2019 18:50:22 +0100 X-Inumbo-ID: c59e0a0c-fff4-11e9-b678-bc764e2007e4 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 5 Nov 2019 18:50:08 +0100 Message-Id: <20191105175010.2591-2-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191105175010.2591-1-laurent@vivier.eu> References: <20191105175010.2591-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:xIRSM2QcNuucJtLEhlYRpyW0YjRZeJsUZwbZz0pkdgW0UYo3LqF H3VqTkrZ07U49UA806XDzr3Eju+3GmLsm40n7fx4b0SzVs56y4F+xbyQCPixXFPc5Q3kgIw EY0j5y8UkYd5jzWOpVGbpISd6LfX6AOdxr175i30dnhQaF4Tim81ZAQcG9k2DA5PhoxKHze nBr5mcduF/rlk8MasQWLg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:+7GRlHCA3/U=:3wOwnQgqgieEE2UdVEQkBf AxFgA2QCER1KmhRTkqiCowOTDjBEHT4p2OJhihJVW4HDKwO9JRZu3zMNaMu+K8l925y4sU/oq tq6brI+MKJ0OWG1UjN5u5U4KphyWdBBVPZVomvckUNPB6O4hfs8nTkQAM4yuDyoqfPLUITO1F lFgUEMy1Sjo7mXi+QoWkF+rruNbYZTOtL2nzQw3W5l3Jvs5NxauTbs6A3iihSn7luS3wptloE BfAwrpiXClbcca518oryCGE944yV+vrYd0HJVNt9AWpFl0bKLvGuP4jtWo1v/qy/XDxQvUpFr j1sz9qF5aTU/u42lDa+YxPfxAqltPozm1ooO0yXHOu7ET1q7pDoFy/fhwhOFknTkYKUogzmzR rmD3j/IPjFsZHxCvnDbpzabNoxAvTiLpI3niJeLjojzjSqKgsphJrMl3FFykSTfwiavWzxahn yh8uIH+1n6COxaqx60fSXDu6zz/2M17c+G1zFRfkEarEt20g1BhWWKX4+8wSyqXIF3FHz6kZ0 LSKjML7WmHEs8oNCzK6hdBTPUGl+LKH5UjwXoen1QojU7dhhEertzAQQJC6d6h2Ve5AcVM0GC qsR77WK7kwyudeZW2+qxomkznEFN6mAcqlNO045GqQ+eTc52iP9Ch8lu5m04350pl1WsiAEGe 4XvlTTPWL8x9eqzkq4/NaRm7k+o34TkBhu+a7UoBySqTv4KGZZA2sMUlMbtjcvL/kIQ8JZwzc NbBoebBQrF0lC/hmPxWPOH0uOShbJZJFX9xgxvpUHm+4zkyI1okfvWFQBNK2O4jy+zCIPWViL bpwnT7JgeXZ1VHg8iQwGja8Lxq52IGp4X8Mnit8BxNRFnWCB7Wk7iPti+7zZHos3EKRHOvaYS N1CjbUT9twQNk3pBFKqsHEwjeLP4r/zwfcikmNwjY= Subject: [Xen-devel] [PULL v2 1/3] hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Eduardo Habkost , Paul Durrant , qemu-trivial@nongnu.org, Claudio Fontana , Cleber Rosa , Michael Tokarev , Laurent Vivier , Fabien Chouteau , KONRAD Frederic , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Anthony Perard , xen-devel@lists.xenproject.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Philippe Mathieu-Daud=C3=A9 Guests can crash QEMU when writting to PnP registers: $ echo 'writeb 0x800ff042 69' | qemu-system-sparc -M leon3_generic -S -bi= os /etc/magic -qtest stdio [I 1571938309.932255] OPENED [R +0.063474] writeb 0x800ff042 69 Segmentation fault (core dumped) (gdb) bt #0 0x0000000000000000 in () #1 0x0000555f4bcdf0bc in memory_region_write_with_attrs_accessor (mr=3D0= x555f4d7be8c0, addr=3D66, value=3D0x7fff07d00f08, size=3D1, shift=3D0, mask= =3D255, attrs=3D...) at memory.c:503 #2 0x0000555f4bcdf185 in access_with_adjusted_size (addr=3D66, value=3D0= x7fff07d00f08, size=3D1, access_size_min=3D1, access_size_max=3D4, access_f= n=3D0x555f4bcdeff4 , mr=3D0x555f4d= 7be8c0, attrs=3D...) at memory.c:539 #3 0x0000555f4bce2243 in memory_region_dispatch_write (mr=3D0x555f4d7be8= c0, addr=3D66, data=3D69, op=3DMO_8, attrs=3D...) at memory.c:1489 #4 0x0000555f4bc80b20 in flatview_write_continue (fv=3D0x555f4d92c400, a= ddr=3D2148528194, attrs=3D..., buf=3D0x7fff07d01120 "E", len=3D1, addr1=3D6= 6, l=3D1, mr=3D0x555f4d7be8c0) at exec.c:3161 #5 0x0000555f4bc80c65 in flatview_write (fv=3D0x555f4d92c400, addr=3D214= 8528194, attrs=3D..., buf=3D0x7fff07d01120 "E", len=3D1) at exec.c:3201 #6 0x0000555f4bc80fb0 in address_space_write (as=3D0x555f4d7aa460, addr= =3D2148528194, attrs=3D..., buf=3D0x7fff07d01120 "E", len=3D1) at exec.c:32= 91 #7 0x0000555f4bc8101d in address_space_rw (as=3D0x555f4d7aa460, addr=3D2= 148528194, attrs=3D..., buf=3D0x7fff07d01120 "E", len=3D1, is_write=3Dtrue)= at exec.c:3301 #8 0x0000555f4bcdb388 in qtest_process_command (chr=3D0x555f4c2ed7e0 , words=3D0x555f4db0c5d0) at qtest.c:432 Instead of crashing, log the access as unimplemented. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: KONRAD Frederic Message-Id: <20191025110114.27091-2-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/misc/grlib_ahb_apb_pnp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/misc/grlib_ahb_apb_pnp.c b/hw/misc/grlib_ahb_apb_pnp.c index 7338461694c9..f3c015d2c35f 100644 --- a/hw/misc/grlib_ahb_apb_pnp.c +++ b/hw/misc/grlib_ahb_apb_pnp.c @@ -22,6 +22,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/sysbus.h" #include "hw/misc/grlib_ahb_apb_pnp.h" =20 @@ -231,8 +232,15 @@ static uint64_t grlib_apb_pnp_read(void *opaque, hwadd= r offset, unsigned size) return apb_pnp->regs[offset >> 2]; } =20 +static void grlib_apb_pnp_write(void *opaque, hwaddr addr, + uint64_t val, unsigned size) +{ + qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__); +} + static const MemoryRegionOps grlib_apb_pnp_ops =3D { .read =3D grlib_apb_pnp_read, + .write =3D grlib_apb_pnp_write, .endianness =3D DEVICE_BIG_ENDIAN, }; =20 --=20 2.21.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel