From nobody Thu Dec 18 22:17:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1572969527; cv=none; d=zoho.com; s=zohoarc; b=EZPGvcZBpZsaBpp2gFXINhBLz2U+kBvzuSDaPh1ScyEj3NHeZHSAgxHxivYvXlsLt7rvmhlb70h7DQe+1tPZNCStvBe17jyjSQbgg7RFaoMqltzzvX1aFKEk2r3Lbq77NMp0HRB3bwZCuTWEBExPsMaLg0pO3+j/TGIXsY0hFXg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572969527; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XYd+75Vh0I232tRLHYDQp9fs9znMgSMu5CD/SE4v7qE=; b=Jp22NsLdfYOyafprDtADz1IeZ3bzVUeW2jmIPSykvNyVg3W/5qucFKRusBbM+nxl2JN7Zm3M0n9MEczYYPYielSNf6LBUr9eIybtAW4KSvhKXcbSvEB+DbGke8HNrjVHpslsyza0wcc80eK7pK+AgDwYi1JKh9eA/S/4tjBuUIE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1572969527138669.1649945034351; Tue, 5 Nov 2019 07:58:47 -0800 (PST) Received: from localhost ([::1]:45570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iS1EB-0002AC-BT for importer@patchew.org; Tue, 05 Nov 2019 10:58:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42727) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iS11L-00060k-E1 for qemu-devel@nongnu.org; Tue, 05 Nov 2019 10:45:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iS11F-0003dX-D8 for qemu-devel@nongnu.org; Tue, 05 Nov 2019 10:45:27 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:24293 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iS11D-0003c7-FV for qemu-devel@nongnu.org; Tue, 05 Nov 2019 10:45:21 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-262-nD2KBzB7MliR3hgUDDpJmw-1; Tue, 05 Nov 2019 10:45:15 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 14A72477; Tue, 5 Nov 2019 15:45:14 +0000 (UTC) Received: from localhost (ovpn-116-232.ams2.redhat.com [10.36.116.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1B80F5D9CD; Tue, 5 Nov 2019 15:45:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572968718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XYd+75Vh0I232tRLHYDQp9fs9znMgSMu5CD/SE4v7qE=; b=iIcfbYeenKzxAvWD24OA1j+SR5CAa3+xLSPcP4CUutOaG/BTzBMNsfliRBuobxCBK6mHVh UdJFEqW/6DbncaJtbcu3xLkxz9NrZP31AK98VnFd4rBLAAZ+4qykplp7M4koS86RKW3aMZ MrLQgtfm/clUQ075oSfNi+D+DkOh0O8= From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PULL 10/11] image-fuzzer: Use errors parameter of subprocess.Popen() Date: Tue, 5 Nov 2019 16:43:31 +0100 Message-Id: <20191105154332.181417-11-stefanha@redhat.com> In-Reply-To: <20191105154332.181417-1-stefanha@redhat.com> References: <20191105154332.181417-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: nD2KBzB7MliR3hgUDDpJmw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , qemu-block@nongnu.org, John Snow , Stefan Hajnoczi , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Eduardo Habkost Instead of manually encoding stderr and stdout output, use `errors` parameter of subprocess.Popen(). This will make process.communicate() return unicode strings instead of bytes objects. Signed-off-by: Eduardo Habkost Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20191016192430.25098-11-ehabkost@redhat.com Message-Id: <20191016192430.25098-11-ehabkost@redhat.com> Signed-off-by: Stefan Hajnoczi --- tests/image-fuzzer/runner.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/image-fuzzer/runner.py b/tests/image-fuzzer/runner.py index 0793234815..4ba5c79e13 100755 --- a/tests/image-fuzzer/runner.py +++ b/tests/image-fuzzer/runner.py @@ -79,16 +79,13 @@ def run_app(fd, q_args): devnull =3D open('/dev/null', 'r+') process =3D subprocess.Popen(q_args, stdin=3Ddevnull, stdout=3Dsubprocess.PIPE, - stderr=3Dsubprocess.PIPE) + stderr=3Dsubprocess.PIPE, + errors=3D'replace') try: out, err =3D process.communicate() signal.alarm(0) - # fd is a text file, so we need to decode the process output before - # writing to it. - # We could be simply using the `errors` parameter of subprocess.Po= pen(), - # but this will be possible only after migrating to Python 3 - fd.write(out.decode(errors=3D'replace')) - fd.write(err.decode(errors=3D'replace')) + fd.write(out) + fd.write(err) fd.flush() return process.returncode =20 --=20 2.23.0