From nobody Sun May 5 12:40:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1572861404; cv=none; d=zoho.com; s=zohoarc; b=d4jn83am8ZorlrMjtQz/jLRs4WXGikpiM6BBMnnetMFCfa1GsLZBogyJnDxEc8K/AddCbjW08DCiLgf+m+TE5WqSWK/k5pjYjxUo8Mj9y8EKcHNZo8q7uyMiAhbQF/MGgWTX3YsxZ/a9+/G12vCXkZrEWRPt3tMYSrICPl5Ovsc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572861404; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=POxRkUG655NJzLBqwtEqRjBLA5mg+aMk7f+i316mJ4Y=; b=fFhb8ZkVNBFCogbEzFDnT81Es4e2xkWzU6ANc+fdDLQb7Fu6Dw3VR1qcsOL3j7e9D6B4dWSatAJ+tKK2Q3UUONbLNODL4O+spsGb9a25NwRtdKtxnzbYXFT5Ry6oqpEx6icSWmLJQCzLBZAyqcKlBFhENW4gIvnyxc4WOpMSqS8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1572861404012156.68908655138705; Mon, 4 Nov 2019 01:56:44 -0800 (PST) Received: from localhost ([::1]:58950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRZ6H-0004GF-GY for importer@patchew.org; Mon, 04 Nov 2019 04:56:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47525) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRZ5c-0003mS-2d for qemu-devel@nongnu.org; Mon, 04 Nov 2019 04:56:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRZ5a-00042q-5r for qemu-devel@nongnu.org; Mon, 04 Nov 2019 04:55:59 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:51386 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iRZ5a-00042h-2G for qemu-devel@nongnu.org; Mon, 04 Nov 2019 04:55:58 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-217-SDDdOPOkPiiPIGksIwcuFg-1; Mon, 04 Nov 2019 04:55:54 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2B3F18017DD; Mon, 4 Nov 2019 09:55:45 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 755175C28C; Mon, 4 Nov 2019 09:55:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572861357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=POxRkUG655NJzLBqwtEqRjBLA5mg+aMk7f+i316mJ4Y=; b=GPmTZy6LKlw6RzlkOpd+Jx8V002i5mbociquOyz7Qkzc8tpsNoIo/5PaF+LNltcSDxF1qZ TuraYzPHYHo3ht5J5EpdjoE/7ih2h3VkIsO+InE8UA9+ILxcac4c8YOcDA5GV7vrpgnKk1 EaHclqS4jxTitO981GOtcujb6yt6Rjo= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Paolo Bonzini , Peter Maydell , qemu-devel@nongnu.org Subject: [PATCH] Makefile: Fix config-devices.mak not regenerated when Kconfig updated Date: Mon, 4 Nov 2019 10:55:30 +0100 Message-Id: <20191104095530.22091-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: SDDdOPOkPiiPIGksIwcuFg-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Markovic , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" When hw/$DIR/Kconfig is changed, the corresponding generated hw/$DIR/config-devices.mak is not being updated. Fix this by including all the hw/*/Kconfig files to the prerequisite names of the rule generating the config-devices.mak files. Fixes: e0e312f3525a (build: switch to Kconfig) Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- If OK, I plan to include this fix in the "hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge" pull request. --- Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 0e994a275d..c1461b21e8 100644 --- a/Makefile +++ b/Makefile @@ -384,7 +384,10 @@ MINIKCONF_ARGS =3D \ CONFIG_LINUX=3D$(CONFIG_LINUX) \ CONFIG_PVRDMA=3D$(CONFIG_PVRDMA) =20 -MINIKCONF_INPUTS =3D $(SRC_PATH)/Kconfig.host $(SRC_PATH)/hw/Kconfig +MINIKCONF_INPUTS =3D $(SRC_PATH)/Kconfig.host $(SRC_PATH)/hw/Kconfig \ + $(patsubst %,$(SRC_PATH)/hw/%,$(shell sed -ne \ + 's/source \(.*\)/\1/p'= \ + < $(SRC_PATH)/hw/Kconf= ig)) MINIKCONF =3D $(PYTHON) $(SRC_PATH)/scripts/minikconf.py \ =20 $(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak $(MINIK= CONF_INPUTS) $(BUILD_DIR)/config-host.mak --=20 2.21.0