From nobody Tue Feb 10 05:45:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1572265182; cv=none; d=zoho.com; s=zohoarc; b=MtxJbj7psXTumdyXUi0wA6l7KDMZYx1Riw7fr2iu/ZWYu8oVQ30blbfKS3Gd8Y2N7ofd65kFIbPKubvTzl1aoENuyPbLBizgg6Xy0hxXcPN7lc+BeNM9CwcOg3yGOpmf8Dcio25IRvXSmDNbAi3boBqRv7HlGJUtXthQ/Kx0PzU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572265182; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WZKGwwrQNIsZCQmXWzekNWbQo7lQgOe1Uzx83/bgdcA=; b=LpkADi8KAabq2xD8hVuSMxizZtU0Mmja+n+ZEPUiX/sVGT0IS5qC/e9Fk5ms969q+5O6x9JPTXCwU/WFkIehUc6cjHolzdnXib+TrcuscAUbL+O+Om8ugf7ztyCkL5R44HOixmq8K0/fK/1TlPtK5qllvGV3faYfMISLnPnVmpo= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157226518279422.097357207138998; Mon, 28 Oct 2019 05:19:42 -0700 (PDT) Received: from localhost ([::1]:53112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iP3zn-0005RC-5F for importer@patchew.org; Mon, 28 Oct 2019 08:19:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49707) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iP3vU-000169-7D for qemu-devel@nongnu.org; Mon, 28 Oct 2019 08:15:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iP3vS-00018X-VY for qemu-devel@nongnu.org; Mon, 28 Oct 2019 08:15:12 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:47099 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iP3vS-00017t-RW for qemu-devel@nongnu.org; Mon, 28 Oct 2019 08:15:10 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-128-cAv2Zm1INu-ZXoyXqgbtYQ-1; Mon, 28 Oct 2019 08:15:06 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D25F7800FF1; Mon, 28 Oct 2019 12:15:05 +0000 (UTC) Received: from localhost (ovpn-117-83.ams2.redhat.com [10.36.117.83]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78793261A7; Mon, 28 Oct 2019 12:15:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572264910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WZKGwwrQNIsZCQmXWzekNWbQo7lQgOe1Uzx83/bgdcA=; b=XQc2qqvYSUaxq0UB4r8+0hLVjnF4hN8LviXHwzwKoUA/WSzmno1tTDpRah2Gpn4CI3k3Kp HHTRyhkGOS1NJyUdT/Z1zhD9VdQfzjMJaybWDKXd86YZJhqG43JInfhjrfpqaGfOSH7AI9 0v0yYyMN1B8kOGdjWiEjOcoHt4In1B0= From: Max Reitz To: qemu-block@nongnu.org Subject: [PULL 01/69] iotests: Prefer null-co over null-aio Date: Mon, 28 Oct 2019 13:13:53 +0100 Message-Id: <20191028121501.15279-2-mreitz@redhat.com> In-Reply-To: <20191028121501.15279-1-mreitz@redhat.com> References: <20191028121501.15279-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: cAv2Zm1INu-ZXoyXqgbtYQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We use null-co basically everywhere in the iotests. Unless we want to test null-aio specifically, we should use it instead (for consistency). Signed-off-by: Max Reitz Reviewed-by: John Snow Reviewed-by: Thomas Huth Message-id: 20190917092004.999-2-mreitz@redhat.com Reviewed-by: Andrey Shinkevich Signed-off-by: Max Reitz --- tests/qemu-iotests/093 | 7 +++---- tests/qemu-iotests/245 | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/093 b/tests/qemu-iotests/093 index 3c4f5173ce..50c1e7f2ec 100755 --- a/tests/qemu-iotests/093 +++ b/tests/qemu-iotests/093 @@ -267,13 +267,12 @@ class ThrottleTestCoroutine(ThrottleTestCase): test_img =3D "null-co://" =20 class ThrottleTestGroupNames(iotests.QMPTestCase): - test_img =3D "null-aio://" max_drives =3D 3 =20 def setUp(self): self.vm =3D iotests.VM() for i in range(0, self.max_drives): - self.vm.add_drive(self.test_img, + self.vm.add_drive("null-co://", "throttling.iops-total=3D100,file.read-zeroe= s=3Don") self.vm.launch() =20 @@ -376,10 +375,10 @@ class ThrottleTestRemovableMedia(iotests.QMPTestCase): =20 def test_removable_media(self): # Add a couple of dummy nodes named cd0 and cd1 - result =3D self.vm.qmp("blockdev-add", driver=3D"null-aio", + result =3D self.vm.qmp("blockdev-add", driver=3D"null-co", read_zeroes=3DTrue, node_name=3D"cd0") self.assert_qmp(result, 'return', {}) - result =3D self.vm.qmp("blockdev-add", driver=3D"null-aio", + result =3D self.vm.qmp("blockdev-add", driver=3D"null-co", read_zeroes=3DTrue, node_name=3D"cd1") self.assert_qmp(result, 'return', {}) =20 diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245 index 41218d5f1d..e66a23c5f0 100644 --- a/tests/qemu-iotests/245 +++ b/tests/qemu-iotests/245 @@ -598,7 +598,7 @@ class TestBlockdevReopen(iotests.QMPTestCase): ################## ###### null ###### ################## - opts =3D {'driver': 'null-aio', 'node-name': 'root', 'size': 1024} + opts =3D {'driver': 'null-co', 'node-name': 'root', 'size': 1024} =20 result =3D self.vm.qmp('blockdev-add', conv_keys =3D False, **opts) self.assert_qmp(result, 'return', {}) --=20 2.21.0