From nobody Wed Dec 17 05:38:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1572034764; cv=none; d=zoho.com; s=zohoarc; b=hPXa9f15zWdd3U2HjqiPpicYoOpfOjUZhsIFMOrmpm6qSss1hYUwddiFouSYN+TrfD/AnQxH5qH0YC35L5/jcALK2RiqklWRF7s21Pkgxf9WIev0eKL4ty80RuwK3AUAcoWdPL/LD7BXgnBKbZm+FPlu5ldBbLIATn7PtwXjF5U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572034764; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1xAy7r308A1eQ7rHywpoy93TJ0OhGHAvpDf8lF/0aAA=; b=BRq2FNS9binscLk5eWDCvTgJyVIqO48UWPwdYo/W9nzT21NbYnirUUw9kz4c3aWiDoYhIhQdbcaabRZhS8B8qJt/fMALxVnpm3rqi5MSS0A9b1T1CPU/HWujTc4F8wdUJktmAt6RVqMHGngn9my7yHuPkMQNWC7YtKEg8ncujpg= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1572034764188600.4629000708347; Fri, 25 Oct 2019 13:19:24 -0700 (PDT) Received: from localhost ([::1]:35864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iO63P-0004Iq-6s for importer@patchew.org; Fri, 25 Oct 2019 16:19:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55823) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iO571-00034H-C1 for qemu-devel@nongnu.org; Fri, 25 Oct 2019 15:19:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iO570-0003yD-0s for qemu-devel@nongnu.org; Fri, 25 Oct 2019 15:19:03 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:30954 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iO56z-0003xv-TX for qemu-devel@nongnu.org; Fri, 25 Oct 2019 15:19:01 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-40-wlOHQ5iOME-02EYr7QgJBA-1; Fri, 25 Oct 2019 15:18:57 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9ACB1800DFB; Fri, 25 Oct 2019 19:18:56 +0000 (UTC) Received: from localhost (ovpn-116-78.ams2.redhat.com [10.36.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7904460600; Fri, 25 Oct 2019 19:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572031141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1xAy7r308A1eQ7rHywpoy93TJ0OhGHAvpDf8lF/0aAA=; b=fSeMiAerPIeFRwLASYa3Cftjwg6LBTP7+CpUsq6qBatUl2S+UdYsyyJ8LISuPb9TcqLEip FsmXKyZOodWktJQ6fMYNPf5w3NuymOCzPdlR5Dzu1wN3D9NlgMWmyzKuWPCncOggbi1jcp m+o+8+VT3We1GNLOGgBH5BFa0028Q6s= From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PULL 1/2] virtio-blk: Add blk_drain() to virtio_blk_device_unrealize() Date: Fri, 25 Oct 2019 21:18:38 +0200 Message-Id: <20191025191839.1215-2-stefanha@redhat.com> In-Reply-To: <20191025191839.1215-1-stefanha@redhat.com> References: <20191025191839.1215-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: wlOHQ5iOME-02EYr7QgJBA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-block@nongnu.org, "Michael S. Tsirkin" , Julia Suvorova , Max Reitz , Stefan Hajnoczi , Fam Zheng Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Julia Suvorova QEMU does not wait for completed I/O requests, assuming that the guest driver will reset the device before calling unrealize(). This does not happen on Windows, and QEMU crashes in virtio_notify(), getting the result of a completed I/O request on hot-unplugged device. Signed-off-by: Julia Suvorova Message-Id: <20191018142856.31870-1-jusual@redhat.com> Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index ed2ddebd2b..14e9f85b8b 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -1207,6 +1207,7 @@ static void virtio_blk_device_unrealize(DeviceState *= dev, Error **errp) VirtIODevice *vdev =3D VIRTIO_DEVICE(dev); VirtIOBlock *s =3D VIRTIO_BLK(dev); =20 + blk_drain(s->blk); virtio_blk_data_plane_destroy(s->dataplane); s->dataplane =3D NULL; qemu_del_vm_change_state_handler(s->change); --=20 2.21.0