From nobody Wed Apr 16 03:51:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1572011587; cv=none; d=zoho.com; s=zohoarc; b=fS3y7mHo8/G2PGLF0a6f/FSoDSxuQks3HlzWN17pMisomPtFtzBKqHn28YmYu2pv10UAJpOeCYNqGntf64+eJ4m2kpI76YSrsvOA5u0lUE3zbUR95ygLARAhFzfXmV3rQ0190qgbxe729fF5CjgiO/N/kZ7arYaumiwErHRALUo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1572011587; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8wE9v+oMYoLM+ZHCSTLatnwuohBVoL4LrjAghHeGwKg=; b=ObjF0b2xG0nJprwhrHRrs1Kye+jVT+pR24TNj38M3FciuZDs8gZ8ne7qM0sb0VDmtT20tnsmpIuEYRpsvktn1SXGvxPKQ1F+B5JrSJlqHF2DA1g1mt6Tfw4cS2ss8tomrW/SoXiO7d9ihQmhCdEmrk+Fij+2dXQPcNuF3l1aNxA= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1572011587958364.871728263127; Fri, 25 Oct 2019 06:53:07 -0700 (PDT) Received: from localhost ([::1]:60258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iO01a-0006gh-8O for importer@patchew.org; Fri, 25 Oct 2019 09:53:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36930) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNzvW-0006ZB-Jd for qemu-devel@nongnu.org; Fri, 25 Oct 2019 09:46:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNzvV-0000PM-Fd for qemu-devel@nongnu.org; Fri, 25 Oct 2019 09:46:50 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:53098 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iNzvV-0000Kg-CK for qemu-devel@nongnu.org; Fri, 25 Oct 2019 09:46:49 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-384-5JuSQiLBOWy8FVTxNkupmw-1; Fri, 25 Oct 2019 09:46:34 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BB10E1005500; Fri, 25 Oct 2019 13:46:23 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-117-223.ams2.redhat.com [10.36.117.223]) by smtp.corp.redhat.com (Postfix) with ESMTP id B43B65D70E; Fri, 25 Oct 2019 13:46:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572011204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8wE9v+oMYoLM+ZHCSTLatnwuohBVoL4LrjAghHeGwKg=; b=NJxmL8ZuD3Zb2UmJoDoA9dOJ2Rn24P7UKis2ivQOOCQTNUDSa2YXi5tpLtueSO5LL8W9vr nKAHM6pfvgU3AuXwR/AQIBeqwHrSYmZljyHZgPjfi/LBI+tkUoD9s7FZe4f2g/J2myu1rS JqfEIU4VpDLFyHMdWThSBZdZFjMa9x4= From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PULL 3/7] blockdev: Use error_report() in hmp_commit() Date: Fri, 25 Oct 2019 15:46:07 +0200 Message-Id: <20191025134611.25920-4-kwolf@redhat.com> In-Reply-To: <20191025134611.25920-1-kwolf@redhat.com> References: <20191025134611.25920-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 5JuSQiLBOWy8FVTxNkupmw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Instead of using monitor_printf() to report errors, hmp_commit() should use error_report() like other places do. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- blockdev.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/blockdev.c b/blockdev.c index 03c7cd7651..ba491e3ef5 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1088,11 +1088,11 @@ void hmp_commit(Monitor *mon, const QDict *qdict) =20 blk =3D blk_by_name(device); if (!blk) { - monitor_printf(mon, "Device '%s' not found\n", device); + error_report("Device '%s' not found", device); return; } if (!blk_is_available(blk)) { - monitor_printf(mon, "Device '%s' has no medium\n", device); + error_report("Device '%s' has no medium", device); return; } =20 @@ -1105,8 +1105,7 @@ void hmp_commit(Monitor *mon, const QDict *qdict) aio_context_release(aio_context); } if (ret < 0) { - monitor_printf(mon, "'commit' error for '%s': %s\n", device, - strerror(-ret)); + error_report("'commit' error for '%s': %s", device, strerror(-ret)= ); } } =20 --=20 2.20.1