From nobody Mon Feb 9 07:55:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571993162; cv=none; d=zoho.com; s=zohoarc; b=eyS+OJ7gADwQSgSQkBLAJWgWHSTUFRRXMwTrmM4StlL3O5YCmV0J+3Y5bXzIEYU7AEkxL6Zzq38gMZHEKtOYlTTho7XUcX4a+uVxpUyisnbtFQauaR97SjCWNUjDiN7131BaN7SuXBPZWGBu/DyazJQhvujTFZ3vxWDR9UWBg7w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571993162; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QwwBNIm4icU6T5Xp+zsrPLUK4URRyVnXz5sXZbtDH4A=; b=N9U3HW3B1kLQt+zhkfYYvf1QbJ4pbsj5GkruCh41Tkvv/3DKdRVP7FmBviTM1jpjOg/wEcFvyUSj5a8MRRjJ39Z1wFNMeBG20Ig2GwgfzTQfOir4N6FsD2xIowh4QAMNeGPhkfaDCY3+GB57FxnN0eXUdJEClaq+NFiDaNkAa/s= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571993162619288.0975324828521; Fri, 25 Oct 2019 01:46:02 -0700 (PDT) Received: from localhost ([::1]:57634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNvEO-00076s-UT for importer@patchew.org; Fri, 25 Oct 2019 04:46:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50101) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNv5A-00013M-JM for qemu-devel@nongnu.org; Fri, 25 Oct 2019 04:36:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNv59-00082X-Cy for qemu-devel@nongnu.org; Fri, 25 Oct 2019 04:36:28 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:27479 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iNv59-00082K-9W for qemu-devel@nongnu.org; Fri, 25 Oct 2019 04:36:27 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-g071UDhGNvKo-cxoOpUmLg-1; Fri, 25 Oct 2019 04:36:23 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A03B11800E00; Fri, 25 Oct 2019 08:36:22 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.36.118.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1811D60BE0; Fri, 25 Oct 2019 08:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571992587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QwwBNIm4icU6T5Xp+zsrPLUK4URRyVnXz5sXZbtDH4A=; b=EXjFX46agD1ycDt9YlOe9VVMSgmkG0kgIGfbPoXdStrAGkQKPtfLZWsVvP8yqP3hERFeqF AivURb/YiT9l7pW1fuowlrqO5kMyTbDj7z/7vAJx3J/IzjQbr+1qaU08/W1vJ/bIGKJBE/ /Es4R9CBIGlDQz7W2PziQTFDfUEJb5A= From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org Subject: [PATCH v7 4/8] virtio: Free rnd virqueue at unrealize() Date: Fri, 25 Oct 2019 10:35:23 +0200 Message-Id: <20191025083527.30803-5-eperezma@redhat.com> In-Reply-To: <20191025083527.30803-1-eperezma@redhat.com> References: <20191025083527.30803-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: g071UDhGNvKo-cxoOpUmLg-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Laurent Vivier , qemu-block@nongnu.org, Amit Shah , Jason Wang , "Michael S. Tsirkin" , Max Reitz , Stefan Hajnoczi , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Fam Zheng , Jens Freimann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The function virtio_del_queue was not called at unrealize() callback. This was detected due to add an allocated element on the vq introduce in future commits (used_elems) and running address sanitizer memory leak detector. Signed-off-by: Eugenio P=C3=A9rez --- hw/virtio/virtio-rng.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index e93bed020f..b498a20332 100644 --- a/hw/virtio/virtio-rng.c +++ b/hw/virtio/virtio-rng.c @@ -238,6 +238,7 @@ static void virtio_rng_device_unrealize(DeviceState *de= v, Error **errp) qemu_del_vm_change_state_handler(vrng->vmstate); timer_del(vrng->rate_limit_timer); timer_free(vrng->rate_limit_timer); + virtio_del_queue(vdev, 0); virtio_cleanup(vdev); } =20 --=20 2.16.5