From nobody Mon Apr 29 08:04:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass header.i=@wdc.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=fail (Bad Signature); dmarc=fail(p=none dis=none) header.from=wdc.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157197788415063.8987557013794; Thu, 24 Oct 2019 21:31:24 -0700 (PDT) Received: from localhost ([::1]:55250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNrFz-0000qg-35 for importer@patchew.org; Fri, 25 Oct 2019 00:31:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53241) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNrDE-0006Hb-1W for qemu-devel@nongnu.org; Fri, 25 Oct 2019 00:28:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNrDB-0007mQ-Mk for qemu-devel@nongnu.org; Fri, 25 Oct 2019 00:28:31 -0400 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:31213) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iNrD7-0007ip-8H; Fri, 25 Oct 2019 00:28:25 -0400 Received: from mail-co1nam04lp2055.outbound.protection.outlook.com (HELO NAM04-CO1-obe.outbound.protection.outlook.com) ([104.47.45.55]) by ob1.hgst.iphmx.com with ESMTP; 25 Oct 2019 12:28:34 +0800 Received: from MN2PR04MB6061.namprd04.prod.outlook.com (20.178.246.15) by MN2PR04MB6048.namprd04.prod.outlook.com (20.178.249.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.24; Fri, 25 Oct 2019 04:28:19 +0000 Received: from MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::1454:87a:13b0:d3a]) by MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::1454:87a:13b0:d3a%7]) with mapi id 15.20.2387.019; Fri, 25 Oct 2019 04:28:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1571977721; x=1603513721; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Sl48DKS1hUGP/Xi+V8xzQK4K9G1qtcbBbyDKuFjoW9g=; b=PaTwWy8b9DqdA4wlmksTqkpKoRVZSRkUzPGvQgSS7tZqzFcnd/rS7LBl RrYOFEyhudklQT5TLW2WKbzrSB7QdT1DLCNguk0FaEE2xdy0fwjeZvm1Z p6NgRLH4k6D9MlWOog8QLLEydb8nY0tNYdPgTJ5BQeRSBG3siRuyPE8MP /EXu3vNq+yPdJTyLZDFepuViu9Cjsmc3hKQxE8s5wn/5MIr6ReknxsZpA l52cJHcPnhuc5EVn30wvhfiQrf+jmAeIcpdzdaIK9oCqOFJ30RGuaUBvf BZ5pBFvMOs+Cwp/wUGKb65OxLlR4qpDhChStqip/1jOOGMZsLRT2wEQCD Q==; IronPort-SDR: ONULl4MySUm1wy/GNjk5buZ6piGuB5YlcMp39G0CIxHCD+BoDUMUitpApdUf1TzL5WuOh1Ewym yDsFWnLeuQ5HdysKvSmztT9Swygh/oLtwfG0CK40EOVqGhqOglpSGec4iRkyRvi3UL9tZU+NFW +ZiJC2fLE1pEOLHUBpbzNR6Hw1sZBay76AhyJ/nd2BjkVlUY3glnbPI1DdGh/t9hcGyXip5wJr 94sVjZQfqhW7PkL0gso2m4u/45/eikHToQlTtVCotCCZ+NEmej4capOzWHQ7bLAsPsYCqhnsEL StE= X-IronPort-AV: E=Sophos;i="5.68,227,1569254400"; d="scan'208";a="222437862" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NQAWo6eJgPtNdJNxCe0mBc/1L47wY881ijp/xW7Y2M56oDn3DxTI7P652xmchRoVcsKvnh6Jb5D2KSCTvOMrJO6QNEaqYIGgKhTNfB7Oot9tBZCwpSpxGKX1Eycof5NMpOvGZM+wE9EIH6jIqpXwKE1d6B6DD+X9VNaHIbcuiU4gYjZ3y+Sb86acVTkZqdBvCqbMjkzaKXtaEf2Ft5ocQxL4Vnw1H/AweWbIpzjROqT3qU0Ka4MOr9Be7+37RlC/8VhXEU5oZ7Z7eH6yqM6rzXmTmwuPOSm1JuYuuoYw8eV6IpWepdGZ/WfApYNidoDbLIOcJj3DErCk4PeybMBI3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9uhRd6JKnm3MLpM/yfdX2Lg9n7p1v0FFe7Fdb0616EM=; b=YMgKKGa8alXqCIfW9boS3cHHNsJR+lRBiSczLPhrfI4o3ns0cBRSy7yHLp9MyfHuQ8VgFXgShlY6wTZEcEGB9kI9Vl380QwVyORW/3UqP+7GSYlwwt/DX+SMepbYdbDWeWEOflB0zSRSBp8Ki5wJAnzvneu5OGXcDe/Dkry07q5o35D5y/1gIncDRTAP2UEkzUL3edh3/cDfD9W1bxQdHDaJaXqW1gzjFTNpQwsu4d8vVN+Dbr+g1AFguZbo0Miy1XZkfRhGGxzh9OID8f5MvRyBtn1f0kWewfFJgH3yem9xGJu/IbtXa3wLJ41oFll9iPAAjEKmKvB/O3ttfrqbsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9uhRd6JKnm3MLpM/yfdX2Lg9n7p1v0FFe7Fdb0616EM=; b=xdC2N5y0GU34cZP6Sg/33Z7Ily83WKBxeBEIS65aQE/T4yIRzjTpjxKRJWHTiC8RfZ5j2UbAbFhQbW4p+u3ai0yILNYf+XyUANG5nU8MbXTUwlNx5Niq/cEHjFSOK4LhxKjp46yK4+Xm2EOsNeCBY9CrSt1yEnnuWCT8SPtH7Ug= From: Anup Patel To: Peter Maydell , Palmer Dabbelt , Alistair Francis , Sagar Karandikar , Bastian Koppelmann Subject: [PATCH v5 1/2] hw: rtc: Add Goldfish RTC device Thread-Topic: [PATCH v5 1/2] hw: rtc: Add Goldfish RTC device Thread-Index: AQHViuygk4vJrE+YcEW3GPSgoX1pYg== Date: Fri, 25 Oct 2019 04:28:19 +0000 Message-ID: <20191025042734.69244-2-anup.patel@wdc.com> References: <20191025042734.69244-1-anup.patel@wdc.com> In-Reply-To: <20191025042734.69244-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MA1PR0101CA0058.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:20::20) To MN2PR04MB6061.namprd04.prod.outlook.com (2603:10b6:208:d8::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [49.207.51.187] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 497ba773-9a7e-4b67-84df-08d75903c2f4 x-ms-traffictypediagnostic: MN2PR04MB6048: x-ms-exchange-purlcount: 2 x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:257; x-forefront-prvs: 02015246A9 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(366004)(346002)(376002)(136003)(39860400002)(396003)(189003)(199004)(14454004)(50226002)(476003)(8936002)(486006)(66556008)(14444005)(81156014)(6512007)(76176011)(6436002)(6486002)(81166006)(4326008)(66476007)(66446008)(64756008)(7736002)(52116002)(2171002)(66066001)(99286004)(66946007)(305945005)(386003)(102836004)(6506007)(478600001)(256004)(25786009)(55236004)(186003)(36756003)(86362001)(54906003)(966005)(71200400001)(8676002)(2616005)(3846002)(6116002)(446003)(11346002)(30864003)(5660300002)(110136005)(2906002)(26005)(1076003)(44832011)(71190400001)(6306002)(316002)(2004002); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR04MB6048; H:MN2PR04MB6061.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I+mbhkUojox+G9HIn0e9I03rVvCxU9cRwhbvt2WVYeTfUGRWtypDfgdHkeFUMyYCI95uxLHraKY1w3rOq7j+jwSugVI08Z+4H88xWaZ3+tWqtXtGXU66cLewgZ37eXKe1YLr2OFBihRJipLBsOlgmM/FsC1VxFtEANJB51ob6rzN/+hcKtnPFF8yErKDTOallRpdAyKUodHQ8ooPRUwF7UTwxGOivyt5ZGHjXchD7zKGB8wBHUoapLX2k2v//5JlAad2o9IXNKcJAMxUn3yT1miQGe2yzTw9fpC89CSjrkPGiN3lSAQF3NOgK8/27KR47T6bdI0SRSM5R3eYgV+519NRQjZe7PXwwY4BWwlJ6TuLiw2kbYD5Lt2pViDWb/UncKi3JIQ1Toxf/4TePmQhn7QRXO9A2KRDakEMg89E1Mv8GIImeCY7FqQ/WkqZI0oFv/PjDXBXyhN/zVL/ex86V/IVNkKLMfLbgS166Q1P3ls= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 497ba773-9a7e-4b67-84df-08d75903c2f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2019 04:28:19.1000 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5VZQ3CblEJtv6Kauzi0+WGUos4xXp1UDbvbo+nONpeox21HFHdk1bcd08T2TNqn+JmXVN3zujhlnO/Rgp2NqmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6048 X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 68.232.143.124 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Atish Patra , Anup Patel , "qemu-riscv@nongnu.org" , "qemu-devel@nongnu.org" , Anup Patel Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @sharedspace.onmicrosoft.com) Content-Type: text/plain; charset="utf-8" This patch adds model for Google Goldfish virtual platform RTC device. We will be adding Goldfish RTC device to the QEMU RISC-V virt machine for providing real date-time to Guest Linux. The corresponding Linux driver for Goldfish RTC device is already available in upstream Linux. For now, VM migration support is available but untested for Goldfish RTC device. It will be hardened in-future when we implement VM migration for KVM RISC-V. Signed-off-by: Anup Patel Reviewed-by: Alistair Francis --- hw/rtc/Kconfig | 3 + hw/rtc/Makefile.objs | 1 + hw/rtc/goldfish_rtc.c | 288 ++++++++++++++++++++++++++++++++++ hw/rtc/trace-events | 4 + include/hw/rtc/goldfish_rtc.h | 46 ++++++ 5 files changed, 342 insertions(+) create mode 100644 hw/rtc/goldfish_rtc.c create mode 100644 include/hw/rtc/goldfish_rtc.h diff --git a/hw/rtc/Kconfig b/hw/rtc/Kconfig index 45daa8d655..bafe6ac2c9 100644 --- a/hw/rtc/Kconfig +++ b/hw/rtc/Kconfig @@ -21,3 +21,6 @@ config MC146818RTC =20 config SUN4V_RTC bool + +config GOLDFISH_RTC + bool diff --git a/hw/rtc/Makefile.objs b/hw/rtc/Makefile.objs index 8dc9fcd3a9..aa208d0d10 100644 --- a/hw/rtc/Makefile.objs +++ b/hw/rtc/Makefile.objs @@ -11,3 +11,4 @@ common-obj-$(CONFIG_EXYNOS4) +=3D exynos4210_rtc.o obj-$(CONFIG_MC146818RTC) +=3D mc146818rtc.o common-obj-$(CONFIG_SUN4V_RTC) +=3D sun4v-rtc.o common-obj-$(CONFIG_ASPEED_SOC) +=3D aspeed_rtc.o +common-obj-$(CONFIG_GOLDFISH_RTC) +=3D goldfish_rtc.o diff --git a/hw/rtc/goldfish_rtc.c b/hw/rtc/goldfish_rtc.c new file mode 100644 index 0000000000..f71f6eaab0 --- /dev/null +++ b/hw/rtc/goldfish_rtc.c @@ -0,0 +1,288 @@ +/* + * Goldfish virtual platform RTC + * + * Copyright (C) 2019 Western Digital Corporation or its affiliates. + * + * For more details on Google Goldfish virtual platform refer: + * https://android.googlesource.com/platform/external/qemu/+/master/docs/G= OLDFISH-VIRTUAL-HARDWARE.TXT + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2 or later, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License f= or + * more details. + * + * You should have received a copy of the GNU General Public License along= with + * this program. If not, see . + */ + +#include "qemu/osdep.h" +#include "qemu-common.h" +#include "hw/rtc/goldfish_rtc.h" +#include "migration/vmstate.h" +#include "hw/irq.h" +#include "hw/qdev-properties.h" +#include "hw/sysbus.h" +#include "qemu/timer.h" +#include "sysemu/sysemu.h" +#include "qemu/cutils.h" +#include "qemu/log.h" + +#include "trace.h" + +#define RTC_TIME_LOW 0x00 +#define RTC_TIME_HIGH 0x04 +#define RTC_ALARM_LOW 0x08 +#define RTC_ALARM_HIGH 0x0c +#define RTC_IRQ_ENABLED 0x10 +#define RTC_CLEAR_ALARM 0x14 +#define RTC_ALARM_STATUS 0x18 +#define RTC_CLEAR_INTERRUPT 0x1c + +static void goldfish_rtc_update(GoldfishRTCState *s) +{ + qemu_set_irq(s->irq, (s->irq_pending & s->irq_enabled) ? 1 : 0); +} + +static void goldfish_rtc_interrupt(void *opaque) +{ + GoldfishRTCState *s =3D (GoldfishRTCState *)opaque; + + s->alarm_running =3D 0; + s->irq_pending =3D 1; + goldfish_rtc_update(s); +} + +static uint64_t goldfish_rtc_get_count(GoldfishRTCState *s) +{ + return s->tick_offset + (uint64_t)qemu_clock_get_ns(rtc_clock); +} + +static void goldfish_rtc_clear_alarm(GoldfishRTCState *s) +{ + timer_del(s->timer); + s->alarm_running =3D 0; +} + +static void goldfish_rtc_set_alarm(GoldfishRTCState *s) +{ + uint64_t ticks =3D goldfish_rtc_get_count(s); + uint64_t event =3D s->alarm_next; + + if (event <=3D ticks) { + goldfish_rtc_clear_alarm(s); + goldfish_rtc_interrupt(s); + } else { + /* + * We should be setting timer expiry to: + * qemu_clock_get_ns(rtc_clock) + (event - ticks) + * but this is equivalent to: + * event - s->tick_offset + */ + timer_mod(s->timer, event - s->tick_offset); + s->alarm_running =3D 1; + } +} + +static uint64_t goldfish_rtc_read(void *opaque, hwaddr offset, + unsigned size) +{ + GoldfishRTCState *s =3D opaque; + uint64_t r =3D 0; + + switch (offset) { + case RTC_TIME_LOW: + r =3D goldfish_rtc_get_count(s) & 0xffffffff; + break; + case RTC_TIME_HIGH: + r =3D goldfish_rtc_get_count(s) >> 32; + break; + case RTC_ALARM_LOW: + r =3D s->alarm_next & 0xffffffff; + break; + case RTC_ALARM_HIGH: + r =3D s->alarm_next >> 32; + break; + case RTC_IRQ_ENABLED: + r =3D s->irq_enabled; + break; + case RTC_ALARM_STATUS: + r =3D s->alarm_running; + break; + default: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad offset 0x%x\n", __func__, (uint32_t)offset); + break; + } + + trace_goldfish_rtc_read(offset, r); + + return r; +} + +static void goldfish_rtc_write(void *opaque, hwaddr offset, + uint64_t value, unsigned size) +{ + GoldfishRTCState *s =3D opaque; + uint64_t current_tick, new_tick; + + switch (offset) { + case RTC_TIME_LOW: + current_tick =3D goldfish_rtc_get_count(s); + new_tick =3D current_tick & (0xffffffffULL << 32); + new_tick |=3D value; + s->tick_offset +=3D new_tick - current_tick; + break; + case RTC_TIME_HIGH: + current_tick =3D goldfish_rtc_get_count(s); + new_tick =3D current_tick & 0xffffffffULL; + new_tick |=3D (value << 32); + s->tick_offset +=3D new_tick - current_tick; + break; + case RTC_ALARM_LOW: + s->alarm_next &=3D (0xffffffffULL << 32); + s->alarm_next |=3D value; + goldfish_rtc_set_alarm(s); + break; + case RTC_ALARM_HIGH: + s->alarm_next &=3D 0xffffffffULL; + s->alarm_next |=3D (value << 32); + break; + case RTC_IRQ_ENABLED: + s->irq_enabled =3D (uint32_t)(value & 0x1); + goldfish_rtc_update(s); + break; + case RTC_CLEAR_ALARM: + goldfish_rtc_clear_alarm(s); + break; + case RTC_CLEAR_INTERRUPT: + s->irq_pending =3D 0; + goldfish_rtc_update(s); + break; + default: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad offset 0x%x\n", __func__, (uint32_t)offset); + break; + } + + trace_goldfish_rtc_write(offset, value); +} + +static int goldfish_rtc_pre_save(void *opaque) +{ + uint64_t delta; + GoldfishRTCState *s =3D opaque; + + /* + * We want to migrate this offset, which sounds straightforward. + * Unfortunately, we cannot directly pass tick_offset because + * rtc_clock on destination Host might not be same source Host. + * + * To tackle, this we pass tick_offset relative to vm_clock from + * source Host and make it relative to rtc_clock at destination Host. + */ + delta =3D qemu_clock_get_ns(rtc_clock) - + qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); + s->tick_offset_vmstate =3D s->tick_offset + delta; + + return 0; +} + +static int goldfish_rtc_post_load(void *opaque, int version_id) +{ + uint64_t delta; + GoldfishRTCState *s =3D opaque; + + /* + * We extract tick_offset from tick_offset_vmstate by doing + * reverse math compared to pre_save() function. + */ + delta =3D qemu_clock_get_ns(rtc_clock) - + qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); + s->tick_offset =3D s->tick_offset_vmstate - delta; + + return 0; +} + +static const MemoryRegionOps goldfish_rtc_ops =3D { + .read =3D goldfish_rtc_read, + .write =3D goldfish_rtc_write, + .endianness =3D DEVICE_LITTLE_ENDIAN, + .valid =3D { + .min_access_size =3D 4, + .max_access_size =3D 4 + } +}; + +static const VMStateDescription goldfish_rtc_vmstate =3D { + .name =3D TYPE_GOLDFISH_RTC, + .version_id =3D 1, + .pre_save =3D goldfish_rtc_pre_save, + .post_load =3D goldfish_rtc_post_load, + .fields =3D (VMStateField[]) { + VMSTATE_UINT64(tick_offset_vmstate, GoldfishRTCState), + VMSTATE_UINT64(alarm_next, GoldfishRTCState), + VMSTATE_UINT32(alarm_running, GoldfishRTCState), + VMSTATE_UINT32(irq_pending, GoldfishRTCState), + VMSTATE_UINT32(irq_enabled, GoldfishRTCState), + VMSTATE_END_OF_LIST() + } +}; + +static void goldfish_rtc_reset(DeviceState *dev) +{ + GoldfishRTCState *s =3D GOLDFISH_RTC(dev); + struct tm tm; + + timer_del(s->timer); + + qemu_get_timedate(&tm, 0); + s->tick_offset =3D mktimegm(&tm); + s->tick_offset *=3D NANOSECONDS_PER_SECOND; + s->tick_offset -=3D qemu_clock_get_ns(rtc_clock); + s->tick_offset_vmstate =3D 0; + s->alarm_next =3D 0; + s->alarm_running =3D 0; + s->irq_pending =3D 0; + s->irq_enabled =3D 0; +} + +static void goldfish_rtc_realize(DeviceState *d, Error **errp) +{ + SysBusDevice *dev =3D SYS_BUS_DEVICE(d); + GoldfishRTCState *s =3D GOLDFISH_RTC(d); + + memory_region_init_io(&s->iomem, OBJECT(s), &goldfish_rtc_ops, s, + "goldfish_rtc", 0x1000); + sysbus_init_mmio(dev, &s->iomem); + + sysbus_init_irq(dev, &s->irq); + + s->timer =3D timer_new_ns(rtc_clock, goldfish_rtc_interrupt, s); +} + +static void goldfish_rtc_class_init(ObjectClass *klass, void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + + dc->realize =3D goldfish_rtc_realize; + dc->reset =3D goldfish_rtc_reset; + dc->vmsd =3D &goldfish_rtc_vmstate; +} + +static const TypeInfo goldfish_rtc_info =3D { + .name =3D TYPE_GOLDFISH_RTC, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(GoldfishRTCState), + .class_init =3D goldfish_rtc_class_init, +}; + +static void goldfish_rtc_register_types(void) +{ + type_register_static(&goldfish_rtc_info); +} + +type_init(goldfish_rtc_register_types) diff --git a/hw/rtc/trace-events b/hw/rtc/trace-events index d6749f4616..0bfaa26cb8 100644 --- a/hw/rtc/trace-events +++ b/hw/rtc/trace-events @@ -17,3 +17,7 @@ pl031_set_alarm(uint32_t ticks) "alarm set for %u ticks" # aspeed-rtc.c aspeed_rtc_read(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value= 0x%08" PRIx64 aspeed_rtc_write(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " valu= e 0x%08" PRIx64 + +# goldfish_rtc.c +goldfish_rtc_read(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " val= ue 0x%08" PRIx64 +goldfish_rtc_write(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " va= lue 0x%08" PRIx64 diff --git a/include/hw/rtc/goldfish_rtc.h b/include/hw/rtc/goldfish_rtc.h new file mode 100644 index 0000000000..3be586bdcb --- /dev/null +++ b/include/hw/rtc/goldfish_rtc.h @@ -0,0 +1,46 @@ +/* + * Goldfish virtual platform RTC + * + * Copyright (C) 2019 Western Digital Corporation or its affiliates. + * + * For more details on Google Goldfish virtual platform refer: + * https://android.googlesource.com/platform/external/qemu/+/master/docs/G= OLDFISH-VIRTUAL-HARDWARE.TXT + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2 or later, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License f= or + * more details. + * + * You should have received a copy of the GNU General Public License along= with + * this program. If not, see . + */ + +#ifndef HW_RTC_GOLDFISH_RTC_H +#define HW_RTC_GOLDFISH_RTC_H + +#include "hw/sysbus.h" + +#define TYPE_GOLDFISH_RTC "goldfish_rtc" +#define GOLDFISH_RTC(obj) \ +OBJECT_CHECK(GoldfishRTCState, (obj), TYPE_GOLDFISH_RTC) + +typedef struct GoldfishRTCState { + SysBusDevice parent_obj; + + MemoryRegion iomem; + QEMUTimer *timer; + qemu_irq irq; + + uint64_t tick_offset; + uint64_t tick_offset_vmstate; + uint64_t alarm_next; + uint32_t alarm_running; + uint32_t irq_pending; + uint32_t irq_enabled; +} GoldfishRTCState; + +#endif --=20 2.17.1 From nobody Mon Apr 29 08:04:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass header.i=@wdc.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=fail (Bad Signature); dmarc=fail(p=none dis=none) header.from=wdc.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157197779493273.43868921310661; Thu, 24 Oct 2019 21:29:54 -0700 (PDT) Received: from localhost ([::1]:55228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNrEW-0007LQ-GC for importer@patchew.org; Fri, 25 Oct 2019 00:29:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53227) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNrDC-0006CY-3M for qemu-devel@nongnu.org; Fri, 25 Oct 2019 00:28:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNrDA-0007ly-UU for qemu-devel@nongnu.org; Fri, 25 Oct 2019 00:28:29 -0400 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:31213) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iNrD8-0007ip-Ba; Fri, 25 Oct 2019 00:28:26 -0400 Received: from mail-co1nam04lp2055.outbound.protection.outlook.com (HELO NAM04-CO1-obe.outbound.protection.outlook.com) ([104.47.45.55]) by ob1.hgst.iphmx.com with ESMTP; 25 Oct 2019 12:28:41 +0800 Received: from MN2PR04MB6061.namprd04.prod.outlook.com (20.178.246.15) by MN2PR04MB6048.namprd04.prod.outlook.com (20.178.249.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.24; Fri, 25 Oct 2019 04:28:24 +0000 Received: from MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::1454:87a:13b0:d3a]) by MN2PR04MB6061.namprd04.prod.outlook.com ([fe80::1454:87a:13b0:d3a%7]) with mapi id 15.20.2387.019; Fri, 25 Oct 2019 04:28:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1571977723; x=1603513723; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=x2LYqHXcC7dq/y3KGLF8LgBgk5NG//4566p8xmnogNQ=; b=XN7I5TjcpZ9b6tbOD/M0imSSon8+GJgHRmQPD+niLgHiJ1u9P762iEnY mCJnRtsduZfnKFfbvBmO94CUGGasXkPfjW/o78Cevsuvo3zUf3OE+07kZ e4fPD2Zp9B2eUA9SDBxa8hWNmKs1au4XuSK10UA5aBFi6GjCkhLuBrw28 TVgAHAtf7ZGH9wGve1vnpMkiunpKIVVY0vZneb5zyaDX2NPLXVJNjEiBZ liLI06+SpTUZlScC6etzdookaa+Pe1bFf3Uv6nzu/uoKydn+Yupjr9Pht gAMPgkI578JCqe5NAPayReMiVQzuUwNsbaxPgp0F0/2VKjYkXRvCYlLKJ g==; IronPort-SDR: c5B2kpsMr77Ppx0cANLNc+I7iXNu4GUDYcYl5nMvFn6ZHtmxjPq1DwWE9zhru3hCozQsyJwldu WcXgILweBZkM9CRy9dsJq1gV6idn/a2cPz9pQ1kDzQLpzpbhzByoe1tn6i6jxvpYjxfwXcSQfa 7cXOlADHfATpDgok9ORDqNI4oCnp+6U0yb68WZD31MV+YfUdDmBSU/8BST8k9zou8GKvcDlmfq rfrAEKcWeLQTgilNROVredMciGEtaBGAfnpw8bas9AfSfPcSsLuj5vSGidi+2Ayd0Wkqm35RoL ZSU= X-IronPort-AV: E=Sophos;i="5.68,227,1569254400"; d="scan'208";a="222437869" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=izRpSa6y2QqgwIElFnq8auHeboI2HHGImxj6Ps3J2VqqOsW/QC60mp1OmBmeIchfURLPzFpL2Y56zbS5FpfXDFRQycOagLd1evFCMnchvZEBJQl+MC4g424uIRoTEy8GcN3GfMdfMYOyNA4hgy2k0Z+qn/HQXTpiUmkj4jVtI60aNzLGaKT3hsrdbQoDi+6QgoCpgLEVOvGxSQ/KFIwJLkRxo+HfKmwZGGSD220JkN++IcgjWV8vGdnQSHbN+lDxPJ+BKJ2YhTHEfp1SSwRk4nQJwGlUnKHunmguUJuJM2/R6rISnPS7W53uI2apU6JG8XzDBGL2uSSNMLeRxevc4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J0y3+h1psXEIRtGMAZtdqQKFI9+CUrcrouf9S7Z1+wE=; b=TI+n0vsnMxpotTcQezguzA0bXCfTZXU54RYfXE1sLm/JngoqylnroKxeGT25mNMXg4oXw/1dTVERAMyVf9U1j+yhmDJdiwuejYcibV7DYQ/srxrUhMpY7OiCeLdTc/Qw6zqpUfMpH9/Oi3yjrV91ZvVbLqnaPz6aZqnh5B1c4LRnAurDel1WihA7Ekhi2wq/BlUdNIpoxe/T2ymxMkSZOLtkV+/yM/IhYd1q/A06wDeWZD3GV3dmPtpFcNB8Kr+rG2gTRN2/LXhsSft4F0pvLLYtEkpXEPW9/ZaqYLLTxSsNwVHaOgiOOzxIRccnJ83WFDBSbQQjz6N3S4nDfWydew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J0y3+h1psXEIRtGMAZtdqQKFI9+CUrcrouf9S7Z1+wE=; b=bL2GlJ0m+7Epm51fvvPkd2loEE7Zt87JKsW4G4QeUkSLeC4sSmfl1iN8xY+x0CWO8l8oBCOIttWp6W/CG66NCrrX2a5Ftju0j3dR3z7aw/RDsxbdinNK8WqZviV4wIsq8NjSJOIF+4SgNKNOTXm8pMz4foOWQVx+oCOAwXrLGrc= From: Anup Patel To: Peter Maydell , Palmer Dabbelt , Alistair Francis , Sagar Karandikar , Bastian Koppelmann Subject: [PATCH v5 2/2] riscv: virt: Use Goldfish RTC device Thread-Topic: [PATCH v5 2/2] riscv: virt: Use Goldfish RTC device Thread-Index: AQHViuyjrZiK5XOhH06iDXRvjySOvA== Date: Fri, 25 Oct 2019 04:28:23 +0000 Message-ID: <20191025042734.69244-3-anup.patel@wdc.com> References: <20191025042734.69244-1-anup.patel@wdc.com> In-Reply-To: <20191025042734.69244-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MA1PR0101CA0058.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:20::20) To MN2PR04MB6061.namprd04.prod.outlook.com (2603:10b6:208:d8::15) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [49.207.51.187] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ce555e46-e0ed-4114-2ce1-08d75903c5f8 x-ms-traffictypediagnostic: MN2PR04MB6048: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:131; x-forefront-prvs: 02015246A9 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(366004)(346002)(376002)(136003)(39860400002)(396003)(189003)(199004)(14454004)(50226002)(476003)(8936002)(486006)(66556008)(81156014)(6512007)(76176011)(6436002)(6486002)(81166006)(4326008)(66476007)(66446008)(64756008)(7736002)(52116002)(2171002)(66066001)(99286004)(66946007)(305945005)(386003)(102836004)(6506007)(478600001)(256004)(25786009)(55236004)(186003)(36756003)(86362001)(54906003)(71200400001)(8676002)(2616005)(3846002)(6116002)(446003)(11346002)(5660300002)(110136005)(2906002)(26005)(1076003)(44832011)(71190400001)(316002); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR04MB6048; H:MN2PR04MB6061.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z4WP8MybwY2lGRPthbvp+XGhzxTqYaithBfHcSakTWFpfnN+Myil6aDuSZ5W1OMLkzLGOwKxHzjeT6IMnG6/MTqS6bbBYMYHQjcY9XnkQlGfnNcPQViiScCEykIeCK+Ndo7FZuhYZhuzTtfOeEpuetSbatdjbz4MjoLAKGrGUwstWnR0BAfEx2XQrVhKibXQfl7K7W7mkmL91j8V2GnK06vn3arvYHfz8fPDzKRBeNYJvLty4Ow7C7/03L9sUvjJkSV4PTVCFYmTr7k7CO8i/NdeaIlA8khrx0rBoiXevkPNLCKBcfLI+EnS+THIIkuin+G2BOI1sByq2xz0DiimPQ7WIR76SzalUWHk300C/QmHSIsb9sZgAYXPa2rMofPMWB8fKMjk6o95ZQi9PMfan30viHXiDd0+IhVIaNVpKFgBmZvAIYp35spjAR70NwP7 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce555e46-e0ed-4114-2ce1-08d75903c5f8 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2019 04:28:23.9293 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SfW3NbAeHrxUIKPc6ONbsxFs4nue7FDR5eCmBOGKLoX7woNsQ7ebdi0LGN4SUmTp2xTu5VpZjyMCVwbLKmdagw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6048 X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 68.232.143.124 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Atish Patra , Anup Patel , "qemu-riscv@nongnu.org" , "qemu-devel@nongnu.org" , Anup Patel Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @sharedspace.onmicrosoft.com) Content-Type: text/plain; charset="utf-8" We extend QEMU RISC-V virt machine by adding Goldfish RTC device to it. This will allow Guest Linux to sync it's local date/time with Host date/time via RTC device. Signed-off-by: Anup Patel Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt Reviewed-by: Alistair Francis --- hw/riscv/Kconfig | 1 + hw/riscv/virt.c | 15 +++++++++++++++ include/hw/riscv/virt.h | 2 ++ 3 files changed, 18 insertions(+) diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig index fb19b2df3a..b33753c780 100644 --- a/hw/riscv/Kconfig +++ b/hw/riscv/Kconfig @@ -34,6 +34,7 @@ config RISCV_VIRT select PCI select HART select SERIAL + select GOLDFISH_RTC select VIRTIO_MMIO select PCI_EXPRESS_GENERIC_BRIDGE select SIFIVE diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index d36f5625ec..95c42ab993 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -57,6 +57,7 @@ static const struct MemmapEntry { [VIRT_DEBUG] =3D { 0x0, 0x100 }, [VIRT_MROM] =3D { 0x1000, 0x11000 }, [VIRT_TEST] =3D { 0x100000, 0x1000 }, + [VIRT_RTC] =3D { 0x101000, 0x1000 }, [VIRT_CLINT] =3D { 0x2000000, 0x10000 }, [VIRT_PLIC] =3D { 0xc000000, 0x4000000 }, [VIRT_UART0] =3D { 0x10000000, 0x100 }, @@ -310,6 +311,17 @@ static void create_fdt(RISCVVirtState *s, const struct= MemmapEntry *memmap, qemu_fdt_setprop_cell(fdt, nodename, "interrupt-parent", plic_phandle); qemu_fdt_setprop_cell(fdt, nodename, "interrupts", UART0_IRQ); =20 + nodename =3D g_strdup_printf("/rtc@%lx", + (long)memmap[VIRT_RTC].base); + qemu_fdt_add_subnode(fdt, nodename); + qemu_fdt_setprop_string(fdt, nodename, "compatible", + "google,goldfish-rtc"); + qemu_fdt_setprop_cells(fdt, nodename, "reg", + 0x0, memmap[VIRT_RTC].base, + 0x0, memmap[VIRT_RTC].size); + qemu_fdt_setprop_cell(fdt, nodename, "interrupt-parent", plic_phandle); + qemu_fdt_setprop_cell(fdt, nodename, "interrupts", RTC_IRQ); + qemu_fdt_add_subnode(fdt, "/chosen"); qemu_fdt_setprop_string(fdt, "/chosen", "stdout-path", nodename); if (cmdline) { @@ -496,6 +508,9 @@ static void riscv_virt_board_init(MachineState *machine) 0, qdev_get_gpio_in(DEVICE(s->plic), UART0_IRQ), 399193, serial_hd(0), DEVICE_LITTLE_ENDIAN); =20 + sysbus_create_simple("goldfish_rtc", memmap[VIRT_RTC].base, + qdev_get_gpio_in(DEVICE(s->plic), RTC_IRQ)); + g_free(plic_hart_config); } =20 diff --git a/include/hw/riscv/virt.h b/include/hw/riscv/virt.h index 6e5fbe5d3b..e6423258d3 100644 --- a/include/hw/riscv/virt.h +++ b/include/hw/riscv/virt.h @@ -37,6 +37,7 @@ enum { VIRT_DEBUG, VIRT_MROM, VIRT_TEST, + VIRT_RTC, VIRT_CLINT, VIRT_PLIC, VIRT_UART0, @@ -49,6 +50,7 @@ enum { =20 enum { UART0_IRQ =3D 10, + RTC_IRQ =3D 11, VIRTIO_IRQ =3D 1, /* 1 to 8 */ VIRTIO_COUNT =3D 8, PCIE_IRQ =3D 0x20, /* 32 to 35 */ --=20 2.17.1