From nobody Mon Feb 9 08:57:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571920521; cv=none; d=zoho.com; s=zohoarc; b=hSM9z1Faa3ex/9S8XXcQdSSA+1gRvuiW3XpZzchdLejAnuvjonKbPUuXwY1EDpK6qOOhDFtLmhUKN9VU66y88xfhsXCauDm9yL0SxYTY7iXPJDwmI5Bj1jEViU6Vl1JrKsKvRRzCiUbu6w4bLM70TfHhzKypqQWxSKhSuvpQijc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571920521; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=15drxuzcOQCQFkvaoMBF/3VHDuJh5Wh8c6TDtfsVpEo=; b=lEampxBG5R8B5rjcV8OKYU7KupcOjYzcEGqWZzxw7Fa1BOil2zVTTGDrFW3O5cCLjn5Vp80hHu8wInqbWjn+G4gR6y9d58PwSG4HefTWEELhqRsO9+NlHL3uPR7gv1l892ZLYM/yVMY5ARda15ISJw7Ibb04R/hdekkQe9zMlxM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1571920521118875.0409909493793; Thu, 24 Oct 2019 05:35:21 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-DsgJlHJLNrm1tfjymFXBZA-1; Thu, 24 Oct 2019 08:35:17 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B947E107AD35; Thu, 24 Oct 2019 12:35:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90F70600CC; Thu, 24 Oct 2019 12:35:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 35F964E58A; Thu, 24 Oct 2019 12:35:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9OCZ8Vs004490 for ; Thu, 24 Oct 2019 08:35:08 -0400 Received: by smtp.corp.redhat.com (Postfix) id CDF3852F7; Thu, 24 Oct 2019 12:35:08 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.118.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B47D52E7; Thu, 24 Oct 2019 12:35:08 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 2177F11328A8; Thu, 24 Oct 2019 14:34:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571920519; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=15drxuzcOQCQFkvaoMBF/3VHDuJh5Wh8c6TDtfsVpEo=; b=VzCE+iElBZLf8ldw2gSwRYvmK84rhPicaYrPkkkLUwo7dPARnkFFa6dzPon7yg33JEDzV4 vjMhaqazUZt6G62g2zdneg5hG5bx+gLy4qpp1wl9MkWtpIUewcQcB7txw+L52KYcx4O2NR aom3lmy004TAwIY/jDV/aWpIEYIk+/o= From: Markus Armbruster To: qemu-devel@nongnu.org Date: Thu, 24 Oct 2019 14:34:51 +0200 Message-Id: <20191024123458.13505-13-armbru@redhat.com> In-Reply-To: <20191024123458.13505-1-armbru@redhat.com> References: <20191024123458.13505-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: libvir-list@redhat.com Subject: [libvirt] [RFC PATCH 12/19] qapi: Replace qmp_dispatch()'s TODO comment by an explanation X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: DsgJlHJLNrm1tfjymFXBZA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster --- qapi/qmp-dispatch.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index 0cbb663097..55bc224c61 100644 --- a/qapi/qmp-dispatch.c +++ b/qapi/qmp-dispatch.c @@ -164,7 +164,11 @@ QDict *qmp_dispatch(QmpCommandList *cmds, QObject *req= uest, g_assert(!ret); return NULL; } else if (!ret) { - /* TODO turn into assertion */ + /*=20 + * When the command's schema has no 'returns', cmd->fn() + * leaves @ret null. The QMP spec calls for an the empty + * object then; supply it. + */ ret =3D QOBJECT(qdict_new()); } =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list