From nobody Sat Feb 7 09:38:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571919873; cv=none; d=zoho.com; s=zohoarc; b=iehwT4ajI7ka0JqTJpi6RVEeIapy2wzd/zpUwUIrekQZF5+uiqJSxtb21hVfG5k8IM1qPz9BFwKryRdvPHjfbn5LjYsZc4Mp4FAmSmvjHUtHTgtGmGYzeSZTAoC+2CTGlm2YZRC2Ch+UruP0fHu+8KAWurZuznO9rCxczeXcNp8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571919873; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gGhKQJOyOC1EYSaaw2IqzcvcqSb54BtgY89/1NGOOpE=; b=nXoJ632/Pv4It+dRk5EMy8kDBvSd42sw/P2Umm2qXQ9RmEZEZshqJHSUnk5Rx/t6CyemFvoXHOGBTXMP4SQJNdrRESZJIbYPW+RLZ4ixtx0l3n55RzM+uQsS2uK4tqXSrfTA/RIyQZHUUiAxoaFa0OY//y/nLAfWIR6+tN6ARd0= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571919873494774.5864961870983; Thu, 24 Oct 2019 05:24:33 -0700 (PDT) Received: from localhost ([::1]:40980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNcAH-0003cA-VS for importer@patchew.org; Thu, 24 Oct 2019 08:24:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39416) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNbID-0003oH-9h for qemu-devel@nongnu.org; Thu, 24 Oct 2019 07:28:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNbIB-00006c-AB for qemu-devel@nongnu.org; Thu, 24 Oct 2019 07:28:37 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:55108 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iNbIB-000050-5y for qemu-devel@nongnu.org; Thu, 24 Oct 2019 07:28:35 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-280-INLMrqsaP-C0pFLcigJtpQ-1; Thu, 24 Oct 2019 07:28:25 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 392EB1800E00; Thu, 24 Oct 2019 11:28:24 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-117-248.ams2.redhat.com [10.36.117.248]) by smtp.corp.redhat.com (Postfix) with ESMTP id E9C4752DD; Thu, 24 Oct 2019 11:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571916509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gGhKQJOyOC1EYSaaw2IqzcvcqSb54BtgY89/1NGOOpE=; b=JHnDL93wBGY+8Ji1NCTBuYXF1XN1tQv4WcuWC78xty0XwsDC5PW2POgO44nImIiECOL2v8 0mjGo6s5O+H8de6oVgOEN4CCoNVfFOy0cVV8wfGtLbVcFeV1jRhg35wJ1vqXCaGu4wuhR7 kTtRRV8D1s79/jwo4mj90rXe3UfudIU= From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, renzhen@linux.alibaba.com, eguan@linux.alibaba.com, ganesh.mahalingam@intel.com, m.mizuma@jp.fujitsu.com, mszeredi@redhat.com, misono.tomohiro@jp.fujitsu.com, tao.peng@linux.alibaba.com, piaojun@huawei.com, stefanha@redhat.com, vgoyal@redhat.com, mst@redhat.com, berrange@redhat.com Subject: [PATCH 14/25] virtiofsd: prevent ".." escape in lo_do_readdir() Date: Thu, 24 Oct 2019 12:27:07 +0100 Message-Id: <20191024112718.34657-15-dgilbert@redhat.com> In-Reply-To: <20191024112718.34657-1-dgilbert@redhat.com> References: <20191024112718.34657-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: INLMrqsaP-C0pFLcigJtpQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Stefan Hajnoczi Construct a fake dirent for the root directory's ".." entry. This hides the parent directory from the FUSE client. Signed-off-by: Stefan Hajnoczi --- contrib/virtiofsd/passthrough_ll.c | 36 ++++++++++++++++++------------ 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/contrib/virtiofsd/passthrough_ll.c b/contrib/virtiofsd/passthr= ough_ll.c index 7a61bf94fe..cb01e3f088 100644 --- a/contrib/virtiofsd/passthrough_ll.c +++ b/contrib/virtiofsd/passthrough_ll.c @@ -1087,18 +1087,24 @@ out_err: static void lo_do_readdir(fuse_req_t req, fuse_ino_t ino, size_t size, off_t offset, struct fuse_file_info *fi, int plus) { + struct lo_data *lo =3D lo_data(req); struct lo_dirp *d; + struct lo_inode *dinode; char *buf =3D NULL; char *p; size_t rem =3D size; - int err =3D ENOMEM; + int err =3D EBADF; =20 - (void) ino; + dinode =3D lo_inode(req, ino); + if (!dinode) { + goto error; + } =20 d =3D lo_dirp(req, fi); if (!d) goto error; =20 + err =3D ENOMEM; buf =3D calloc(1, size); if (!buf) goto error; @@ -1128,15 +1134,21 @@ static void lo_do_readdir(fuse_req_t req, fuse_ino_= t ino, size_t size, } nextoff =3D d->entry->d_off; name =3D d->entry->d_name; + fuse_ino_t entry_ino =3D 0; + struct fuse_entry_param e =3D (struct fuse_entry_param) { + .attr.st_ino =3D d->entry->d_ino, + .attr.st_mode =3D d->entry->d_type << 12, + }; + + /* Hide root's parent directory */ + if (dinode =3D=3D &lo->root && strcmp(name, "..") =3D=3D 0) { + e.attr.st_ino =3D lo->root.ino; + e.attr.st_mode =3D DT_DIR << 12; + } + if (plus) { - struct fuse_entry_param e; - if (is_dot_or_dotdot(name)) { - e =3D (struct fuse_entry_param) { - .attr.st_ino =3D d->entry->d_ino, - .attr.st_mode =3D d->entry->d_type << 12, - }; - } else { + if (!is_dot_or_dotdot(name)) { err =3D lo_do_lookup(req, ino, name, &e); if (err) goto error; @@ -1146,12 +1158,8 @@ static void lo_do_readdir(fuse_req_t req, fuse_ino_t= ino, size_t size, entsize =3D fuse_add_direntry_plus(req, p, rem, name, &e, nextoff); } else { - struct stat st =3D { - .st_ino =3D d->entry->d_ino, - .st_mode =3D d->entry->d_type << 12, - }; entsize =3D fuse_add_direntry(req, p, rem, name, - &st, nextoff); + &e.attr, nextoff); } if (entsize > rem) { if (entry_ino !=3D 0)=20 --=20 2.23.0