[v9] target/arm: Reduce overhead of cpu_get_tb_cpu_state

[PATCH v9 00/24] target/arm: Reduce overhead of cpu_get_tb_cpu_state

Richard Henderson posted 24 patches 4 years, 5 months ago

Diff against v1 v2 v3 v4 v5 v6 v7 v8
Download series mbox

Test asan passed

Test checkpatch passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191023150057.25731-1-richard.henderson@linaro.org

Maintainers: Peter Maydell <peter.maydell@linaro.org>, Riku Voipio <riku.voipio@iki.fi>, Laurent Vivier <laurent@vivier.eu>

target/arm/cpu.h              |  84 +++++---
target/arm/helper.h           |   4 +
target/arm/internals.h        |   9 +
hw/intc/armv7m_nvic.c         |  22 +-
linux-user/aarch64/cpu_loop.c |   1 +
linux-user/arm/cpu_loop.c     |   1 +
linux-user/syscall.c          |   1 +
target/arm/cpu.c              |   1 +
target/arm/helper-a64.c       |   3 +
target/arm/helper.c           | 393 ++++++++++++++++++++++------------
target/arm/m_helper.c         |   6 +
target/arm/machine.c          |   1 +
target/arm/op_helper.c        |   4 +
target/arm/translate-a64.c    |  13 +-
target/arm/translate.c        |  33 ++-
15 files changed, 392 insertions(+), 184 deletions(-)

Expand all Fold all

[PATCH v9 00/24] target/arm: Reduce overhead of cpu_get_tb_cpu_state

Posted by Richard Henderson 4 years, 5 months ago

Changes since v8:
  * Rebuild hflags in linux-user/*/cpu_loop.c, after changing to big-endian.
    This allows the armeb busybox ls to pass.  I don't have a test image for
    aarch64_eb, but the code looks the same.

Changes since v7:
  * Rebuild hflags for all successful nvic writes (Peter).
  * Rebuild hflags for Xscale sctlr writes (Peter).

Changes since v6:
  * Regen hflags in two more places for m-profile (patch 19).
...


r~


Richard Henderson (24):
  target/arm: Split out rebuild_hflags_common
  target/arm: Split out rebuild_hflags_a64
  target/arm: Split out rebuild_hflags_common_32
  target/arm: Split arm_cpu_data_is_big_endian
  target/arm: Split out rebuild_hflags_m32
  target/arm: Reduce tests vs M-profile in cpu_get_tb_cpu_state
  target/arm: Split out rebuild_hflags_a32
  target/arm: Split out rebuild_hflags_aprofile
  target/arm: Hoist XSCALE_CPAR, VECLEN, VECSTRIDE in
    cpu_get_tb_cpu_state
  target/arm: Simplify set of PSTATE_SS in cpu_get_tb_cpu_state
  target/arm: Hoist computation of TBFLAG_A32.VFPEN
  target/arm: Add arm_rebuild_hflags
  target/arm: Split out arm_mmu_idx_el
  target/arm: Hoist store to cs_base in cpu_get_tb_cpu_state
  target/arm: Add HELPER(rebuild_hflags_{a32,a64,m32})
  target/arm: Rebuild hflags at EL changes
  target/arm: Rebuild hflags at MSR writes
  target/arm: Rebuild hflags at CPSR writes
  target/arm: Rebuild hflags at Xscale SCTLR writes
  target/arm: Rebuild hflags for M-profile
  target/arm: Rebuild hflags for M-profile NVIC
  linux-user/aarch64: Rebuild hflags for TARGET_WORDS_BIGENDIAN
  linux-user/arm: Rebuild hflags for TARGET_WORDS_BIGENDIAN
  target/arm: Rely on hflags correct in cpu_get_tb_cpu_state

 target/arm/cpu.h              |  84 +++++---
 target/arm/helper.h           |   4 +
 target/arm/internals.h        |   9 +
 hw/intc/armv7m_nvic.c         |  22 +-
 linux-user/aarch64/cpu_loop.c |   1 +
 linux-user/arm/cpu_loop.c     |   1 +
 linux-user/syscall.c          |   1 +
 target/arm/cpu.c              |   1 +
 target/arm/helper-a64.c       |   3 +
 target/arm/helper.c           | 393 ++++++++++++++++++++++------------
 target/arm/m_helper.c         |   6 +
 target/arm/machine.c          |   1 +
 target/arm/op_helper.c        |   4 +
 target/arm/translate-a64.c    |  13 +-
 target/arm/translate.c        |  33 ++-
 15 files changed, 392 insertions(+), 184 deletions(-)

-- 
2.17.1

Re: [PATCH v9 00/24] target/arm: Reduce overhead of cpu_get_tb_cpu_state

Posted by Peter Maydell 4 years, 5 months ago

On Wed, 23 Oct 2019 at 16:01, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Changes since v8:
>   * Rebuild hflags in linux-user/*/cpu_loop.c, after changing to big-endian.
>     This allows the armeb busybox ls to pass.  I don't have a test image for
>     aarch64_eb, but the code looks the same.
>
> Changes since v7:
>   * Rebuild hflags for all successful nvic writes (Peter).
>   * Rebuild hflags for Xscale sctlr writes (Peter).
>
> Changes since v6:
>   * Regen hflags in two more places for m-profile (patch 19).
> ...


Applied to target-arm.next; planning a pullreq tomorrow.

thanks
-- PMM