[PATCH 0/2] hw/gpio: Fix property accessors of the AST2600 GPIO 1.8V model

Cédric Le Goater posted 2 patches 4 years, 5 months ago
Test asan passed
Test checkpatch passed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191023130455.1347-1-clg@kaod.org
Maintainers: Andrew Jeffery <andrew@aj.id.au>, Joel Stanley <joel@jms.id.au>, "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>
include/hw/arm/aspeed.h |  1 +
hw/arm/aspeed.c         | 23 +++++++++++++++++++++++
hw/gpio/aspeed_gpio.c   |  8 ++++----
3 files changed, 28 insertions(+), 4 deletions(-)
[PATCH 0/2] hw/gpio: Fix property accessors of the AST2600 GPIO 1.8V model
Posted by Cédric Le Goater 4 years, 5 months ago
Hello,

The property names of AST2600 GPIO 1.8V model are one character bigger
than the names of the other ASPEED GPIO model. This change increases
the string buffer size by one and parses the property name with a
better pattern.

This fixes the QOM test of the ast2600-evb machine under :

  Apple LLVM version 10.0.0 (clang-1000.10.44.4)
  Target: x86_64-apple-darwin17.7.0
  Thread model: posix
  InstalledDir: /Library/Developer/CommandLineTools/usr/bin

And all tests for the AST2600 EVB machine should now pass !

Thanks,

C.

Cédric Le Goater (2):
  hw/gpio: Fix property accessors of the AST2600 GPIO 1.8V model
  aspeed: Add an AST2600 eval board

 include/hw/arm/aspeed.h |  1 +
 hw/arm/aspeed.c         | 23 +++++++++++++++++++++++
 hw/gpio/aspeed_gpio.c   |  8 ++++----
 3 files changed, 28 insertions(+), 4 deletions(-)

-- 
2.21.0


Re: [PATCH 0/2] hw/gpio: Fix property accessors of the AST2600 GPIO 1.8V model
Posted by Peter Maydell 4 years, 5 months ago
On Wed, 23 Oct 2019 at 14:05, Cédric Le Goater <clg@kaod.org> wrote:
>
> Hello,
>
> The property names of AST2600 GPIO 1.8V model are one character bigger
> than the names of the other ASPEED GPIO model. This change increases
> the string buffer size by one and parses the property name with a
> better pattern.
>
> This fixes the QOM test of the ast2600-evb machine under :
>
>   Apple LLVM version 10.0.0 (clang-1000.10.44.4)
>   Target: x86_64-apple-darwin17.7.0
>   Thread model: posix
>   InstalledDir: /Library/Developer/CommandLineTools/usr/bin
>
> And all tests for the AST2600 EVB machine should now pass !

Aha, thanks for finding this bug. In theory the compiler
could have caught it, but it looks like this isn't one of
the things -Wformat/-Wformat-security check for.

Applied to target-arm.next.

thanks
-- PMM