[PATCH] buildfix: update texinfo menu

Gerd Hoffmann posted 1 patch 4 years, 5 months ago
Test asan passed
Test checkpatch passed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191023101956.19120-1-kraxel@redhat.com
qemu-doc.texi | 1 +
1 file changed, 1 insertion(+)
[PATCH] buildfix: update texinfo menu
Posted by Gerd Hoffmann 4 years, 5 months ago
Build error message:
qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features' despite being its Up target

Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter")
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 qemu-doc.texi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/qemu-doc.texi b/qemu-doc.texi
index 3c5022050f0f..3ddf5c0a6865 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -44,6 +44,7 @@
 * Security::
 * Implementation notes::
 * Deprecated features::
+* Recently removed features::
 * Supported build platforms::
 * License::
 * Index::
-- 
2.18.1


Re: [PATCH] buildfix: update texinfo menu
Posted by Markus Armbruster 4 years, 5 months ago
Gerd Hoffmann <kraxel@redhat.com> writes:

> Build error message:
> qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features' despite being its Up target
>
> Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter")
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qemu-doc.texi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index 3c5022050f0f..3ddf5c0a6865 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -44,6 +44,7 @@
>  * Security::
>  * Implementation notes::
>  * Deprecated features::
> +* Recently removed features::
>  * Supported build platforms::
>  * License::
>  * Index::

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Cc'ing qemu-trivial.


Re: [PATCH] buildfix: update texinfo menu
Posted by Laszlo Ersek 4 years, 5 months ago
On 10/23/19 12:19, Gerd Hoffmann wrote:
> Build error message:
> qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features' despite being its Up target
> 
> Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter")
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qemu-doc.texi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index 3c5022050f0f..3ddf5c0a6865 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -44,6 +44,7 @@
>  * Security::
>  * Implementation notes::
>  * Deprecated features::
> +* Recently removed features::
>  * Supported build platforms::
>  * License::
>  * Index::
> 

Tested-by: Laszlo Ersek <lersek@redhat.com>

(Applied it on top of ee70fc26a561, and now the tree builds.)

Thanks!
Laszlo


Re: [PATCH] buildfix: update texinfo menu
Posted by Laszlo Ersek 4 years, 4 months ago
On 10/23/19 12:19, Gerd Hoffmann wrote:
> Build error message:
> qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features' despite being its Up target
> 
> Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter")
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qemu-doc.texi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index 3c5022050f0f..3ddf5c0a6865 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -44,6 +44,7 @@
>  * Security::
>  * Implementation notes::
>  * Deprecated features::
> +* Recently removed features::
>  * Supported build platforms::
>  * License::
>  * Index::
> 

Can this patch be included in v4.2.0-rc2 please?

Thanks!
Laszlo


Re: [PATCH] buildfix: update texinfo menu
Posted by Markus Armbruster 4 years, 4 months ago
Laszlo Ersek <lersek@redhat.com> writes:

> On 10/23/19 12:19, Gerd Hoffmann wrote:
>> Build error message:
>> qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features' despite being its Up target
>> 
>> Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter")
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
>>  qemu-doc.texi | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/qemu-doc.texi b/qemu-doc.texi
>> index 3c5022050f0f..3ddf5c0a6865 100644
>> --- a/qemu-doc.texi
>> +++ b/qemu-doc.texi
>> @@ -44,6 +44,7 @@
>>  * Security::
>>  * Implementation notes::
>>  * Deprecated features::
>> +* Recently removed features::
>>  * Supported build platforms::
>>  * License::
>>  * Index::
>> 
>
> Can this patch be included in v4.2.0-rc2 please?

Cc'ing qemu-trivial again, might be a workable path into -rc2.


Re: [PATCH] buildfix: update texinfo menu
Posted by Peter Maydell 4 years, 4 months ago
On Mon, 18 Nov 2019 at 09:13, Markus Armbruster <armbru@redhat.com> wrote:
>
> Laszlo Ersek <lersek@redhat.com> writes:
>
> > On 10/23/19 12:19, Gerd Hoffmann wrote:
> >> Build error message:
> >> qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features' despite being its Up target
> >>
> >> Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter")
> >> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> >> ---
> >>  qemu-doc.texi | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/qemu-doc.texi b/qemu-doc.texi
> >> index 3c5022050f0f..3ddf5c0a6865 100644
> >> --- a/qemu-doc.texi
> >> +++ b/qemu-doc.texi
> >> @@ -44,6 +44,7 @@
> >>  * Security::
> >>  * Implementation notes::
> >>  * Deprecated features::
> >> +* Recently removed features::
> >>  * Supported build platforms::
> >>  * License::
> >>  * Index::
> >>
> >
> > Can this patch be included in v4.2.0-rc2 please?
>
> Cc'ing qemu-trivial again, might be a workable path into -rc2.

I've just applied it directly to master. (Not sure why none
of my build test machines complain about the error.)

thanks
-- PMM

Re: [PATCH] buildfix: update texinfo menu
Posted by Gerd Hoffmann 4 years, 4 months ago
On Mon, Nov 18, 2019 at 11:08:52AM +0000, Peter Maydell wrote:
> On Mon, 18 Nov 2019 at 09:13, Markus Armbruster <armbru@redhat.com> wrote:
> >
> > Laszlo Ersek <lersek@redhat.com> writes:
> >
> > > On 10/23/19 12:19, Gerd Hoffmann wrote:
> > >> Build error message:
> > >> qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features' despite being its Up target
> > >>
> > >> Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter")
> > >> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > >> ---
> > >>  qemu-doc.texi | 1 +
> > >>  1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/qemu-doc.texi b/qemu-doc.texi
> > >> index 3c5022050f0f..3ddf5c0a6865 100644
> > >> --- a/qemu-doc.texi
> > >> +++ b/qemu-doc.texi
> > >> @@ -44,6 +44,7 @@
> > >>  * Security::
> > >>  * Implementation notes::
> > >>  * Deprecated features::
> > >> +* Recently removed features::
> > >>  * Supported build platforms::
> > >>  * License::
> > >>  * Index::
> > >>
> > >
> > > Can this patch be included in v4.2.0-rc2 please?
> >
> > Cc'ing qemu-trivial again, might be a workable path into -rc2.
> 
> I've just applied it directly to master. (Not sure why none
> of my build test machines complain about the error.)

Probably some build dependency for --enable-docs is missing.
sphinx maybe?

cheers,
  Gerd


Re: [PATCH] buildfix: update texinfo menu
Posted by Laszlo Ersek 4 years, 4 months ago
On 11/18/19 12:08, Peter Maydell wrote:
> On Mon, 18 Nov 2019 at 09:13, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Laszlo Ersek <lersek@redhat.com> writes:
>>
>>> On 10/23/19 12:19, Gerd Hoffmann wrote:
>>>> Build error message:
>>>> qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features' despite being its Up target
>>>>
>>>> Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter")
>>>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>>>> ---
>>>>  qemu-doc.texi | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/qemu-doc.texi b/qemu-doc.texi
>>>> index 3c5022050f0f..3ddf5c0a6865 100644
>>>> --- a/qemu-doc.texi
>>>> +++ b/qemu-doc.texi
>>>> @@ -44,6 +44,7 @@
>>>>  * Security::
>>>>  * Implementation notes::
>>>>  * Deprecated features::
>>>> +* Recently removed features::
>>>>  * Supported build platforms::
>>>>  * License::
>>>>  * Index::
>>>>
>>>
>>> Can this patch be included in v4.2.0-rc2 please?
>>
>> Cc'ing qemu-trivial again, might be a workable path into -rc2.
> 
> I've just applied it directly to master.

Thank you!
Laszlo

> (Not sure why none
> of my build test machines complain about the error.)
> 
> thanks
> -- PMM
> 


Re: [PATCH] buildfix: update texinfo menu
Posted by Philippe Mathieu-Daudé 4 years, 5 months ago
Cc'ed trivial@

On 10/23/19 12:19 PM, Gerd Hoffmann wrote:
> Build error message:
> qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed features' despite being its Up target
> 
> Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload parameter")
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>   qemu-doc.texi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index 3c5022050f0f..3ddf5c0a6865 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -44,6 +44,7 @@
>   * Security::
>   * Implementation notes::
>   * Deprecated features::
> +* Recently removed features::
>   * Supported build platforms::
>   * License::
>   * Index::
> 

Re: [PATCH] buildfix: update texinfo menu
Posted by John Snow 4 years, 5 months ago

On 10/23/19 7:10 AM, Philippe Mathieu-Daudé wrote:
> Cc'ed trivial@
> 
> On 10/23/19 12:19 PM, Gerd Hoffmann wrote:
>> Build error message:
>> qemu-doc.texi:34: node `Top' lacks menu item for `Recently removed
>> features' despite being its Up target
>>
>> Fixes: 3264ffced3d0 ("dirty-bitmaps: remove deprecated autoload
>> parameter")
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> 

mea culpa.

Reviewed-by: John Snow <jsnow@redhat.com>