[PULL 0/3] NBD patches for 2019-10-22

Eric Blake posted 3 patches 4 years, 5 months ago
Test asan passed
Test checkpatch passed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test docker-quick@centos7 failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191023020126.24991-1-eblake@redhat.com
Maintainers: Eric Blake <eblake@redhat.com>, Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
include/qemu/coroutine.h      |  23 ++-
block/nbd.c                   | 331 +++++++++++++++++++++++++++-------
util/qemu-coroutine-sleep.c   |  51 ++++--
tests/qemu-iotests/264        |  95 ++++++++++
tests/qemu-iotests/264.out    |  13 ++
tests/qemu-iotests/group      |   1 +
tests/qemu-iotests/iotests.py |  11 ++
7 files changed, 447 insertions(+), 78 deletions(-)
create mode 100755 tests/qemu-iotests/264
create mode 100644 tests/qemu-iotests/264.out
[PULL 0/3] NBD patches for 2019-10-22
Posted by Eric Blake 4 years, 5 months ago
The following changes since commit f9bec781379dd7ccf9d01b4b6a79a9ec82c192e5:

  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20191022' into staging (2019-10-22 13:45:09 +0100)

are available in the Git repository at:

  https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2019-10-22

for you to fetch changes up to 23ee0ec2360b51619cae452c4faa8590dea74a6e:

  iotests: test nbd reconnect (2019-10-22 20:51:31 -0500)

Several other NBD patches have appeared on list, but need respins based
on review comments, and may still be okay after soft freeze. But this one
is a feature addition, so I'm sending the PR now, rather than waiting to
bundle in a few more.

----------------------------------------------------------------
nbd patches for 2019-10-22

- add ability for NBD client reconnect

----------------------------------------------------------------
Vladimir Sementsov-Ogievskiy (3):
      qemu-coroutine-sleep: introduce qemu_co_sleep_wake
      block/nbd: nbd reconnect
      iotests: test nbd reconnect

 include/qemu/coroutine.h      |  23 ++-
 block/nbd.c                   | 331 ++++++++++++++++++++++++++++++++++--------
 util/qemu-coroutine-sleep.c   |  51 +++++--
 tests/qemu-iotests/264        |  95 ++++++++++++
 tests/qemu-iotests/264.out    |  13 ++
 tests/qemu-iotests/group      |   1 +
 tests/qemu-iotests/iotests.py |  11 ++
 7 files changed, 447 insertions(+), 78 deletions(-)
 create mode 100755 tests/qemu-iotests/264
 create mode 100644 tests/qemu-iotests/264.out

Vladimir Sementsov-Ogievskiy (3):
  qemu-coroutine-sleep: introduce qemu_co_sleep_wake
  block/nbd: nbd reconnect
  iotests: test nbd reconnect

 include/qemu/coroutine.h      |  23 ++-
 block/nbd.c                   | 331 +++++++++++++++++++++++++++-------
 util/qemu-coroutine-sleep.c   |  51 ++++--
 tests/qemu-iotests/264        |  95 ++++++++++
 tests/qemu-iotests/264.out    |  13 ++
 tests/qemu-iotests/group      |   1 +
 tests/qemu-iotests/iotests.py |  11 ++
 7 files changed, 447 insertions(+), 78 deletions(-)
 create mode 100755 tests/qemu-iotests/264
 create mode 100644 tests/qemu-iotests/264.out

-- 
2.21.0


Re: [PULL 0/3] NBD patches for 2019-10-22
Posted by Peter Maydell 4 years, 5 months ago
On Wed, 23 Oct 2019 at 03:04, Eric Blake <eblake@redhat.com> wrote:
>
> The following changes since commit f9bec781379dd7ccf9d01b4b6a79a9ec82c192e5:
>
>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20191022' into staging (2019-10-22 13:45:09 +0100)
>
> are available in the Git repository at:
>
>   https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2019-10-22
>
> for you to fetch changes up to 23ee0ec2360b51619cae452c4faa8590dea74a6e:
>
>   iotests: test nbd reconnect (2019-10-22 20:51:31 -0500)
>
> Several other NBD patches have appeared on list, but need respins based
> on review comments, and may still be okay after soft freeze. But this one
> is a feature addition, so I'm sending the PR now, rather than waiting to
> bundle in a few more.
>
> ----------------------------------------------------------------
> nbd patches for 2019-10-22
>
> - add ability for NBD client reconnect


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.

-- PMM

Re: [PULL 0/3] NBD patches for 2019-10-22
Posted by no-reply@patchew.org 4 years, 5 months ago
Patchew URL: https://patchew.org/QEMU/20191023020126.24991-1-eblake@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  TEST    check-unit: tests/test-qht-par
  TEST    check-qtest-x86_64: tests/hd-geo-test
**
ERROR:/tmp/qemu-test/src/tests/migration-test.c:1316:test_migrate_auto_converge: assertion failed (remaining < expected_threshold): (100003840 < 100000000)
ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/migration-test.c:1316:test_migrate_auto_converge: assertion failed (remaining < expected_threshold): (100003840 < 100000000)
make: *** [check-qtest-aarch64] Error 1
make: *** Waiting for unfinished jobs....
  TEST    check-qtest-x86_64: tests/boot-order-test
  TEST    check-unit: tests/test-bitops
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=86253dd98db14281b4ecc7d0ee02fd18', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-kiuiorae/src/docker-src.2019-10-23-07.44.10.23908:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=86253dd98db14281b4ecc7d0ee02fd18
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-kiuiorae/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    11m43.756s
user    0m8.183s


The full log is available at
http://patchew.org/logs/20191023020126.24991-1-eblake@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PULL 0/3] NBD patches for 2019-10-22
Posted by Eric Blake 4 years, 5 months ago
On 10/23/19 6:55 AM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20191023020126.24991-1-eblake@redhat.com/
> 
> 
> 
> Hi,
> 
> This series failed the docker-quick@centos7 build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> make docker-image-centos7 V=1 NETWORK=1
> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
> === TEST SCRIPT END ===
> 
>    TEST    check-unit: tests/test-qht-par
>    TEST    check-qtest-x86_64: tests/hd-geo-test
> **
> ERROR:/tmp/qemu-test/src/tests/migration-test.c:1316:test_migrate_auto_converge: assertion failed (remaining < expected_threshold): (100003840 < 100000000)
> ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/migration-test.c:1316:test_migrate_auto_converge: assertion failed (remaining < expected_threshold): (100003840 < 100000000)

Random race? I could not reproduce it, and don't see how this series 
would break that test.


> The full log is available at
> http://patchew.org/logs/20191023020126.24991-1-eblake@redhat.com/testing.docker-quick@centos7/?type=message.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org