From nobody Fri May 3 18:44:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=fail (BodyHash is different from the expected one) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571755865110998.9234782951485; Tue, 22 Oct 2019 07:51:05 -0700 (PDT) Received: from localhost ([::1]:59642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMvV0-00008U-CR for importer@patchew.org; Tue, 22 Oct 2019 10:51:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42832) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMuiI-0002QL-6L for qemu-devel@nongnu.org; Tue, 22 Oct 2019 10:00:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMuiD-000863-5U for qemu-devel@nongnu.org; Tue, 22 Oct 2019 10:00:41 -0400 Received: from beetle.greensocs.com ([5.135.226.135]:40664) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iMuiC-00084f-NB for qemu-devel@nongnu.org; Tue, 22 Oct 2019 10:00:37 -0400 Received: from chartreuse.bar.greensocs.com (chartreuse.bar.greensocs.com [172.16.11.101]) by beetle.greensocs.com (Postfix) with ESMTPS id 2904796EF0; Tue, 22 Oct 2019 14:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1571752834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8Bl/dB3yMrRzO7X9RsKzoXAfsUARn6t6e6UlCVQ7t14=; b=V5dYW4SAn03KFo1L27WE+y9WZe+Rvh72kuxxmSu5+ixdv7s9MkoUt36SptWJYi0s+c1Ln5 rT/71FEgFf0DTa4SKlMqWln3u5Ko2E4MaxTSB4Odrmp5f1yV7eXuslcQfbrtBgz0TpBUXg HeCtfo+ui5439RUAtEiAiynX6tOvgMo= From: Clement Deschamps To: qemu-devel@nongnu.org Subject: [PATCH] translate-all: fix uninitialized tb->orig_tb Date: Tue, 22 Oct 2019 16:00:16 +0200 Message-Id: <20191022140016.918371-1-clement.deschamps@greensocs.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1571752834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8Bl/dB3yMrRzO7X9RsKzoXAfsUARn6t6e6UlCVQ7t14=; b=mrtd/F3rGt93d53AqBZUJ7NRXsKlLFtot96c7qWZO4QO4vwlPzmL4Z/vdyYRWai4lWZdFD QPP8pa8LcPrtlgi1itz2vcXs+C5+V+14VbxQGO9ghON4gYSaYkI4xV+UoFTbevLqS9TvKb es2lvymtIElcyBEZWMLOuHcT4+aad6I= ARC-Seal: i=1; s=mail; d=greensocs.com; t=1571752834; a=rsa-sha256; cv=none; b=fE9QGONsOEOtC1qV+XxeKg5k/MBypzrG8AnEzRK3U9Z8Wtq0aLKT1+dvM93gvzJYxOTME2 z5h62ZFoHiXVOS6MOKqXh7vT/bkL5s5BPbRoD5Fce3+cJs9p/tc9EhnYqlZxmlpV9zwwZq g+6B8kqRPfZpcr/FjmCGzIfST8o9EI0= ARC-Authentication-Results: i=1; beetle.greensocs.com; none Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.135.226.135 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Clement Deschamps , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This fixes a segmentation fault in icount mode when executing from an IO re= gion. TB is marked as CF_NOCACHE but tb->orig_tb is not initialized (equals previous value in code_gen_buffer). The issue happens in cpu_io_recompile() when it tries to invalidate orig_tb. Signed-off-by: Clement Deschamps Reviewed-by: Richard Henderson --- accel/tcg/translate-all.c | 1 + 1 file changed, 1 insertion(+) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 66d4bc4341..f9b7ba159d 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -1722,6 +1722,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu, tb->cs_base =3D cs_base; tb->flags =3D flags; tb->cflags =3D cflags; + tb->orig_tb =3D NULL; tb->trace_vcpu_dstate =3D *cpu->trace_dstate; tcg_ctx->tb_cflags =3D cflags; tb_overflow: --=20 2.23.0