From nobody Sun Feb 8 19:39:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571731075; cv=none; d=zoho.com; s=zohoarc; b=CxCXq+KwHaDnTWJnXVdDy3VH0vCsid8mzAU0mJ8181xs4Jxzcgr9A1R7rh5IFWy/ki9UML0eXabRTH+4Et1rVcOXBobRVW6cBV/nYgyl6SsJHRcoZ4nrRervMYIXp3njwZ3B4Yd0GWeaow43VDtXLZ+TfHEWv3j4uXen0Z7L5Ig= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571731075; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Lnu+O8bz7gJa5hQzmmGc8TgKxI9BbXzl9kBoZ8kZQBE=; b=PvZTJ/bdtBaERdLbJDxyJadqnfkmQuVED3fEV2CEbggGQ7k+AZBtA+vlvEUik2E9D3xkP91sG8MqlSB1OU1pYSQ7Lv2PwsaO3ZsqAiwcRnq6zILNphjqZMrAvh64HQkrcoqFw6sYoc06Xv7JrFIxrMr9mjtOaPkpFdSccYV2pPQ= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571731075163594.1151298290789; Tue, 22 Oct 2019 00:57:55 -0700 (PDT) Received: from localhost ([::1]:51250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMp3B-0004d7-Qp for importer@patchew.org; Tue, 22 Oct 2019 03:57:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42428) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMp1j-0002iX-6w for qemu-devel@nongnu.org; Tue, 22 Oct 2019 03:56:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMp1i-0005s0-3V for qemu-devel@nongnu.org; Tue, 22 Oct 2019 03:56:23 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27664 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iMp1h-0005pP-Ul for qemu-devel@nongnu.org; Tue, 22 Oct 2019 03:56:22 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-232-WbSwAS4MPTqYpTKlW4H-yA-1; Tue, 22 Oct 2019 03:56:18 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3175A1800D79 for ; Tue, 22 Oct 2019 07:56:17 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.118.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F3CEC60C4E; Tue, 22 Oct 2019 07:56:16 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6C3571132D6D; Tue, 22 Oct 2019 09:56:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571730980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lnu+O8bz7gJa5hQzmmGc8TgKxI9BbXzl9kBoZ8kZQBE=; b=Hbg5EuNcSoPkIxcA+DAAj+BrRcJmleAZxzPfiZK6SIsLAdeWJWolif8QvILDBVqpNVv1cq wnXC64JFL5uweyVr5IrQb8S/20PllQ7od5ffR8dChwwQ9FNmDuvSdtH1PGmiHktKvvIglv 1XvU8MzP392DP0anWo1cOitNmQtiMC0= From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 03/12] qapi: Eliminate accidental global frontend state Date: Tue, 22 Oct 2019 09:56:06 +0200 Message-Id: <20191022075615.956-4-armbru@redhat.com> In-Reply-To: <20191022075615.956-1-armbru@redhat.com> References: <20191022075615.956-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: WbSwAS4MPTqYpTKlW4H-yA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The frontend can't be run more than once due to its global state. A future commit will want to do that. The only global frontend state remaining is accidental: QAPISchemaParser.__init__()'s parameter previously_included=3D[]. Python evaluates the default once, at definition time. Any modifications to it are visible in subsequent calls. Well-known Python trap. Change the default to None and replace it by the real default in the function body. Use the opportunity to convert previously_included to a set. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20191018074345.24034-4-armbru@redhat.com> --- scripts/qapi/common.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index 5abab44302..9d5c05f6a1 100644 --- a/scripts/qapi/common.py +++ b/scripts/qapi/common.py @@ -391,8 +391,9 @@ class QAPIDoc(object): =20 class QAPISchemaParser(object): =20 - def __init__(self, fname, previously_included=3D[], incl_info=3DNone): - previously_included.append(os.path.abspath(fname)) + def __init__(self, fname, previously_included=3DNone, incl_info=3DNone= ): + previously_included =3D previously_included or set() + previously_included.add(os.path.abspath(fname)) =20 try: if sys.version_info[0] >=3D 3: --=20 2.21.0