From nobody Wed Nov 12 16:26:15 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1571421574; cv=none; d=zoho.com; s=zohoarc; b=XEh1Xo335dB8/DUk5TOS5D519zBV5nXVW2n0vmWsNikCNksv8pbVvPjiKA8BEy/eP9QHFZL8EVuRyBRZGzauU0sqsSHlgpb0wWuIgFONqiRSL3LXPgYBNUKaaKjoXgCB3jS0nDOu96MVs7vm2yalrgFGfwO3365etZvr3xVabJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571421574; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Iym+ywFHjEBpwuu12wdHsU0gouX4jDUf3/+DDNH9pyk=; b=fH1PfnSU9lSg88kSjRjgWr6sFa/nuN2LNT+1x5nw8L6S8QEsM70W98ZMjhouKyj8rf3tT+ydBktN6XDEP93cYkDZsVOce8+QaytB3CFxgpTo/8/QEIKFccVSeeJKCXbs0u9nTl1d40ImeDr7UrZFRa/CrwT5Sp0tVt+gE6hPnWE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571421574377981.1247084831116; Fri, 18 Oct 2019 10:59:34 -0700 (PDT) Received: from localhost ([::1]:44482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLWXF-0005pT-4Y for importer@patchew.org; Fri, 18 Oct 2019 13:59:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59457) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLWJ7-0006oz-U4 for qemu-devel@nongnu.org; Fri, 18 Oct 2019 13:44:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLWJ6-0005cl-NH for qemu-devel@nongnu.org; Fri, 18 Oct 2019 13:44:57 -0400 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:45802) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLWJ6-0005c9-I8 for qemu-devel@nongnu.org; Fri, 18 Oct 2019 13:44:56 -0400 Received: by mail-pg1-x544.google.com with SMTP id r1so3739500pgj.12 for ; Fri, 18 Oct 2019 10:44:56 -0700 (PDT) Received: from localhost.localdomain (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id d20sm7857534pfq.88.2019.10.18.10.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 10:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Iym+ywFHjEBpwuu12wdHsU0gouX4jDUf3/+DDNH9pyk=; b=pATM9ssFkxdigDI20QfMiusWkLq9ZFxqjeIY84nbG+ObLMz20Bk5mN8NBKXHLAtYCK SqSxE4tOdn6VrESxF94B1nPMlHxkEi+ROiz9wEXeruDUOJvEz1m8LPuvpAgiE27FzrcV Q875XXTvOR1tnKjLjl6hkAg7+a/SL9rt+XXKaQM/1Xzf4QovmWHlpMpCvx6lmxD2tdcI uWbYbNHtH27PEHBekoL9PEDQM8qatIauBE2asth1uVJ7PX9CPQvtyZwRWAnRNRa0JMJN S/uEHGcknS5SONOXKK+djAeyziJIJQtNLLqBrX+WCcrKNMivoe8f6qB+rKJvL7SoXwS8 RZaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Iym+ywFHjEBpwuu12wdHsU0gouX4jDUf3/+DDNH9pyk=; b=XWMevuYojBWFxaTOfZ01/itFW90111sU8D292cWS9SAyDQIFjEZQJAvnN0ffWjr2wx kvUurmuyld4GO9Qrg1+AdsCdDAkvIZeu4Bl28mQZJxMDJ05GPtVA+8Ud9VdwGgKpL/Rl E+lnh8wKkN4UPVaoxJMp1d2JDTp6hseAmCvOzEe7XXUqNcdTOJf/AR+DVloJjiq/A3I2 FOiXEm5fQ9BSJdKIMkAoZmXmnCgZQ3nE/eD/I1bhMg16rNv/TA8yB25X7tP69IF5Q4PX vdpHYX2P6aX9Q16jktwnbijWUUca/k7FK4zSJk+hwSZpLdheJtUfBfmKYtGBzhCD00WC wCLQ== X-Gm-Message-State: APjAAAXOy/0ixdaka+LGr4oXjEYg6ufi5u66ZvCIeRxplJycc2GcIqEx CIl+YeGCZ/iElURWIcnAud5T6/n7J1k= X-Google-Smtp-Source: APXvYqyEZzJOoYjgY/4/WGnJED6vZ7cCjAez8SeGJXJL9TZ01Ntz0/7YiyycHgQAIRi33qr1X9UFlw== X-Received: by 2002:a63:3104:: with SMTP id x4mr11264412pgx.135.1571420695215; Fri, 18 Oct 2019 10:44:55 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v8 18/22] target/arm: Rebuild hflags at CPSR writes Date: Fri, 18 Oct 2019 10:44:27 -0700 Message-Id: <20191018174431.1784-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191018174431.1784-1-richard.henderson@linaro.org> References: <20191018174431.1784-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Continue setting, but not relying upon, env->hflags. Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Richard Henderson --- target/arm/op_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c index ccc2cecb46..b529d6c1bf 100644 --- a/target/arm/op_helper.c +++ b/target/arm/op_helper.c @@ -224,6 +224,7 @@ uint32_t HELPER(usat16)(CPUARMState *env, uint32_t x, u= int32_t shift) void HELPER(setend)(CPUARMState *env) { env->uncached_cpsr ^=3D CPSR_E; + arm_rebuild_hflags(env); } =20 /* Function checks whether WFx (WFI/WFE) instructions are set up to be tra= pped. @@ -387,6 +388,8 @@ uint32_t HELPER(cpsr_read)(CPUARMState *env) void HELPER(cpsr_write)(CPUARMState *env, uint32_t val, uint32_t mask) { cpsr_write(env, val, mask, CPSRWriteByInstr); + /* TODO: Not all cpsr bits are relevant to hflags. */ + arm_rebuild_hflags(env); } =20 /* Write the CPSR for a 32-bit exception return */ --=20 2.17.1