From nobody Wed Nov 12 14:59:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571415602; cv=none; d=zoho.com; s=zohoarc; b=Tzesu7llslTiqiuGBMF6vbnIhTyX3YTxtQiAxP3Hs4qwj1MF06wuYs0K52XOLU4QN6NnOjkq2Zss7otr1yZwdedONTYCh6F8FJVSLoKWKmzYs8zaCxiC1mk1DhAGi5jaqe1OfRy4qRQkeZUJsVmnIPIRl2rIhKjLGNC6T2GHDiU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571415602; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=COJrhRknkQWmvEzNXMYR9kJVSuAp6FXTGo7oPALRfMY=; b=dcW0QC5Z51XQsdqAMO6liOd297RapoIBXwo1mUcVnuy7NGUlpQJJjCfyAl5rKpXSVZci95Q9yr6YxS9PyRqsCam5/R7iIL3GzDXU4WzCuxx6gCMgy0JaNv3SyCuaubj+TrIlzbdjtB7k3zgyvhPU7mM+p3cLR6dv9Sh+AON18z4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571415602551733.6584145766099; Fri, 18 Oct 2019 09:20:02 -0700 (PDT) Received: from localhost ([::1]:42824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLUyv-0007W5-BX for importer@patchew.org; Fri, 18 Oct 2019 12:20:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48979) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLUqF-0007T4-BX for qemu-devel@nongnu.org; Fri, 18 Oct 2019 12:11:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLUqA-0007Se-Iu for qemu-devel@nongnu.org; Fri, 18 Oct 2019 12:11:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53458) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iLUqA-0007Rx-5O; Fri, 18 Oct 2019 12:10:58 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6354418CCEE2; Fri, 18 Oct 2019 16:10:57 +0000 (UTC) Received: from t460s.redhat.com (unknown [10.36.118.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id D95383DB4; Fri, 18 Oct 2019 16:10:55 +0000 (UTC) From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH v1 3/6] s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTE Date: Fri, 18 Oct 2019 18:10:41 +0200 Message-Id: <20191018161044.6983-4-david@redhat.com> In-Reply-To: <20191018161044.6983-1-david@redhat.com> References: <20191018161044.6983-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.63]); Fri, 18 Oct 2019 16:10:57 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , David Hildenbrand , Ivan Warren , Cornelia Huck , Richard Henderson , qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" We forgot to propagate the highest bit accross the high doubleword in two cases (shift >=3D64). Fixes: 5f724887e3dd ("s390x/tcg: Implement VECTOR SHIFT RIGHT ARITHMETIC") Signed-off-by: David Hildenbrand Reviewed-by: Richard Henderson --- target/s390x/vec_int_helper.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/s390x/vec_int_helper.c b/target/s390x/vec_int_helper.c index 1b3aaecbdb..d38405848f 100644 --- a/target/s390x/vec_int_helper.c +++ b/target/s390x/vec_int_helper.c @@ -70,15 +70,17 @@ static void s390_vec_sar(S390Vector *d, const S390Vecto= r *a, uint64_t count) d->doubleword[0] =3D a->doubleword[0]; d->doubleword[1] =3D a->doubleword[1]; } else if (count =3D=3D 64) { + tmp =3D (int64_t)a->doubleword[0] >> 63; d->doubleword[1] =3D a->doubleword[0]; - d->doubleword[0] =3D 0; + d->doubleword[0] =3D tmp; } else if (count < 64) { tmp =3D a->doubleword[1] >> count; d->doubleword[1] =3D deposit64(tmp, 64 - count, count, a->doublewo= rd[0]); d->doubleword[0] =3D (int64_t)a->doubleword[0] >> count; } else { + tmp =3D (int64_t)a->doubleword[0] >> 63; d->doubleword[1] =3D (int64_t)a->doubleword[0] >> (count - 64); - d->doubleword[0] =3D 0; + d->doubleword[0] =3D tmp; } } =20 --=20 2.21.0