From nobody Wed Nov 12 13:13:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571409053; cv=none; d=zoho.com; s=zohoarc; b=ij9i68om+J8ZpoRZF5DcKir3GWuHo8A9lChZOduqaSr9KYxXDrF6qNWiHrxYIK9W50PTONKRYhpl6xKukIvbcrtKdewEYsQwtpAEb9+Djw6uRdSwB5jWa7RzJCTB7qn+Kq4m1T6NM8hMJWkEkPlZ9qhVSl1OGvw5xH1gUFajfNw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571409053; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=toyzR7f/h463m6DnLut/rgn+Y0HOHUPbIF+aubpyUt0=; b=GlcekJI/NSL3eXKnIG3yhab+7qq1p7Ppp50Wb3fdVJuPuN10pNbn4hAyS5Izemy0PcbTYQy3zK/ZvM/7XGJZ2PIJVvghyUyLtjPiHRqm/uDuU7oPaaMUyObnmDRRh5mgHl5bdpUmXDVcmM+Ll3u/MeiRwGSrkwzwQE67gFvJcYo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571409053822981.2667998026373; Fri, 18 Oct 2019 07:30:53 -0700 (PDT) Received: from localhost ([::1]:40924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLTHG-0007bN-WF for importer@patchew.org; Fri, 18 Oct 2019 10:30:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32995) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLTFq-0006YC-Kz for qemu-devel@nongnu.org; Fri, 18 Oct 2019 10:29:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLTFp-0001pD-K2 for qemu-devel@nongnu.org; Fri, 18 Oct 2019 10:29:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48542) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iLTFp-0001oj-EZ for qemu-devel@nongnu.org; Fri, 18 Oct 2019 10:29:21 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0969518C4287 for ; Fri, 18 Oct 2019 14:29:20 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-204-99.brq.redhat.com [10.40.204.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A76D600C4; Fri, 18 Oct 2019 14:29:05 +0000 (UTC) From: Julia Suvorova To: qemu-devel@nongnu.org Subject: [PATCH] virtio-blk: Add blk_drain() to virtio_blk_device_unrealize() Date: Fri, 18 Oct 2019 16:28:56 +0200 Message-Id: <20191018142856.31870-1-jusual@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Fri, 18 Oct 2019 14:29:20 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Max Reitz , Julia Suvorova , Stefan Hajnoczi , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" QEMU does not wait for completed I/O requests, assuming that the guest driver will reset the device before calling unrealize(). This does not happen on Windows, and QEMU crashes in virtio_notify(), getting the result of a completed I/O request on hot-unplugged device. Signed-off-by: Julia Suvorova --- hw/block/virtio-blk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index ed2ddebd2b..14e9f85b8b 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -1207,6 +1207,7 @@ static void virtio_blk_device_unrealize(DeviceState *= dev, Error **errp) VirtIODevice *vdev =3D VIRTIO_DEVICE(dev); VirtIOBlock *s =3D VIRTIO_BLK(dev); =20 + blk_drain(s->blk); virtio_blk_data_plane_destroy(s->dataplane); s->dataplane =3D NULL; qemu_del_vm_change_state_handler(s->change); --=20 2.21.0