From nobody Wed Nov 12 15:00:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571407430; cv=none; d=zoho.com; s=zohoarc; b=NlQb714PInIEOg4q22b/uC4T8Tiz6bOsbWmbocNMg0SuxOZhkEi+IFnxif/xCZzijdC/1q45Bc6N4NTxpC6gf+WLAAkW9+b0PphWKY97Egtjv1ibrsCMvsy6p+6fvZwJ0ddh4FVGYkV36TUb/ZNOU6jKenSs4swSOQ0SmHVUn6A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571407430; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=k+Lfh03BPdiD8LIhVnBiAcLjKSH27IUIEZTdNYI1450=; b=hHGtMy7bjATabnpiseN8H0DOlJpdclr5cE2hOj2ahvcmav1QtsnjV403NBdfFyN0J/zPHECEhY4QhzBz7y9H5LSXIWSmnhQpSlQ1VOJ4hjXCFXUeBfeFhLDpdXG4pWmdYKorLU627n4V9zRhgAii9aEPX1G2eooqzU0P+XtQWYQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571407430145445.78852458442; Fri, 18 Oct 2019 07:03:50 -0700 (PDT) Received: from localhost ([::1]:40514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLSr6-00037C-KE for importer@patchew.org; Fri, 18 Oct 2019 10:03:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56856) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLSnJ-0008M5-1j for qemu-devel@nongnu.org; Fri, 18 Oct 2019 09:59:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLSnH-0001st-W7 for qemu-devel@nongnu.org; Fri, 18 Oct 2019 09:59:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54072) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iLSnH-0001sk-QZ for qemu-devel@nongnu.org; Fri, 18 Oct 2019 09:59:51 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0F318757C2; Fri, 18 Oct 2019 13:59:51 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A3736012A; Fri, 18 Oct 2019 13:59:48 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 3/5] hw/i386/pc: Move gsi_state creation code Date: Fri, 18 Oct 2019 15:59:08 +0200 Message-Id: <20191018135910.24286-4-philmd@redhat.com> In-Reply-To: <20191018135910.24286-1-philmd@redhat.com> References: <20191018135910.24286-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 18 Oct 2019 13:59:51 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Eduardo Habkost , "Michael S. Tsirkin" , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The code block related to IRQ starts few lines later. Move the comment and the pc_gsi_create() invocation where we start to use the IRQs. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v2: reword comment (Aleksandar) --- hw/i386/pc_q35.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 52261962b8..6d096eff28 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -209,9 +209,6 @@ static void pc_q35_init(MachineState *machine) rom_memory, &ram_memory); } =20 - /* irq lines */ - gsi_state =3D pc_gsi_create(&pcms->gsi, pcmc->pci_enabled); - /* create pci host bus */ q35_host =3D Q35_HOST_DEVICE(qdev_create(NULL, TYPE_Q35_HOST_DEVICE)); =20 @@ -245,6 +242,9 @@ static void pc_q35_init(MachineState *machine) object_property_set_link(OBJECT(machine), OBJECT(lpc), PC_MACHINE_ACPI_DEVICE_PROP, &error_abort); =20 + /* irq lines */ + gsi_state =3D pc_gsi_create(&pcms->gsi, pcmc->pci_enabled); + ich9_lpc =3D ICH9_LPC_DEVICE(lpc); lpc_dev =3D DEVICE(lpc); for (i =3D 0; i < GSI_NUM_PINS; i++) { --=20 2.21.0