From nobody Wed Nov 12 15:00:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571408373; cv=none; d=zoho.com; s=zohoarc; b=bEOm/JJ+eBw1kwlwLjT3r+9wiLhpeWipBoEcy2TK4H8XejBXg3IstGyRQOU6FLw0Fogig308fDlh7uxiggszoqGjUYOFwIBtPZe/8Kv3N+tuU8JGlK+jN8q143ChoHgqmIKiU286bAdsivPtTNI1OxK+mikjYUoUgNjU3a55IDo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571408373; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lwmcjSs8KDUnQKwP0W8bsTX45W08WHJDvHstY3vzAcU=; b=YNIk1Z++gYSN1KSGdrPKErfeNBrynZUC1EdBhUXReNs8Y90lnN0Z55UcWwVypGJii8yLHVAXs4G9Z5vsGFoBLE64uRy/C35+3BZm6KYcWsDNjAru9BhYlRk9svmlpQRrpfpxzPsZYzivsMnb7UgfS14+Kv561cfLi+soKmaKWos= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571408373926394.4429512782275; Fri, 18 Oct 2019 07:19:33 -0700 (PDT) Received: from localhost ([::1]:40752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLT6K-000551-Th for importer@patchew.org; Fri, 18 Oct 2019 10:19:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56833) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLSnG-0008Is-Er for qemu-devel@nongnu.org; Fri, 18 Oct 2019 09:59:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLSnF-0001s8-Ff for qemu-devel@nongnu.org; Fri, 18 Oct 2019 09:59:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39470) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iLSnF-0001rh-6M for qemu-devel@nongnu.org; Fri, 18 Oct 2019 09:59:49 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C014C3071D9F; Fri, 18 Oct 2019 13:59:47 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 669E560566; Fri, 18 Oct 2019 13:59:33 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/5] hw/i386/pc: Reduce gsi_handler scope Date: Fri, 18 Oct 2019 15:59:07 +0200 Message-Id: <20191018135910.24286-3-philmd@redhat.com> In-Reply-To: <20191018135910.24286-1-philmd@redhat.com> References: <20191018135910.24286-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Fri, 18 Oct 2019 13:59:47 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Eduardo Habkost , "Michael S. Tsirkin" , Aleksandar Markovic , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" pc_gsi_create() is the single function that uses gsi_handler. Make it a static variable. Reviewed-by: Aleksandar Markovic Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc.c | 2 +- include/hw/i386/pc.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index e3e191a811..21efde33a5 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -346,7 +346,7 @@ GlobalProperty pc_compat_1_4[] =3D { }; const size_t pc_compat_1_4_len =3D G_N_ELEMENTS(pc_compat_1_4); =20 -void gsi_handler(void *opaque, int n, int level) +static void gsi_handler(void *opaque, int n, int level) { GSIState *s =3D opaque; =20 diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 53b2243788..9ad417cef0 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -176,8 +176,6 @@ typedef struct GSIState { qemu_irq ioapic_irq[IOAPIC_NUM_PINS]; } GSIState; =20 -void gsi_handler(void *opaque, int n, int level); - GSIState *pc_gsi_create(qemu_irq **irqs, bool pci_enabled); =20 /* vmport.c */ --=20 2.21.0