From nobody Fri Sep 20 22:52:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1571325760; cv=none; d=zoho.com; s=zohoarc; b=fE+VCufsp9oLkwSqP+bFOIk2o63RdMD8BYZ7oR/78kb9fQ8boEhu0RuC5ICnyik2Zhh81JHW9OV42B1Ap+uYNKnGDELuwMMp18cVts/5B6gljSRejWlLj688g6PDUbjCwf6Y/7GxuEhubYB1Ao/cm7dUC5vZjaMHBPi7tSGXNrc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571325760; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=r33f+d402IAPPHmtVZ4cXQ2aBgpsTwK8Ra9wwxYWaWo=; b=DyE22hR66Fz7vP/yMq7fFRLKQSPOUAZ4ta8aAVg+N4CcVgSaAInF1atirGdkRsNQIRXFv17HIta+1y+lODp8QJmpXK7w0xX95IkTwoiM1iM6ddKVnxuEgCWaDtP+P0cBGL9iAQyFUqt3hSDNOeioovELvN5gxuKdeAcnVJJIe7Y= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571325760486162.76268031920597; Thu, 17 Oct 2019 08:22:40 -0700 (PDT) Received: from localhost ([::1]:50828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL7bo-0002R1-L5 for importer@patchew.org; Thu, 17 Oct 2019 11:22:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45866) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL6eg-0002Df-RD for qemu-devel@nongnu.org; Thu, 17 Oct 2019 10:21:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iL6ef-0006MD-Mx for qemu-devel@nongnu.org; Thu, 17 Oct 2019 10:21:30 -0400 Received: from relay.sw.ru ([185.231.240.75]:35146) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iL6ed-0006JB-1X; Thu, 17 Oct 2019 10:21:27 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.2) (envelope-from ) id 1iL6eZ-0007Ck-Kx; Thu, 17 Oct 2019 17:21:23 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH] block/backup: drop dead code from backup_job_create Date: Thu, 17 Oct 2019 17:21:22 +0300 Message-Id: <20191017142122.20897-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, jsnow@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" After commit 00e30f05de1d195, there is no more "goto error" points after job creation, so after "error:" @job is always NULL and we don't need roll-back job creation. Reported-by: Coverity (CID 1406402) Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Stefano Garzarella --- block/backup.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/block/backup.c b/block/backup.c index 46978c1785..6e1497f7bb 100644 --- a/block/backup.c +++ b/block/backup.c @@ -474,10 +474,7 @@ BlockJob *backup_job_create(const char *job_id, BlockD= riverState *bs, if (sync_bitmap) { bdrv_reclaim_dirty_bitmap(bs, sync_bitmap, NULL); } - if (job) { - backup_clean(&job->common.job); - job_early_fail(&job->common.job); - } else if (backup_top) { + if (backup_top) { bdrv_backup_top_drop(backup_top); } =20 --=20 2.21.0